diff mbox

[OPW,kernel,2/2] fs: btrfs: Fix quoted string split across lines

Message ID b390b5fec0b60307c3559b9d4b997083c9dab46a.1382349648.git.rashika.kheria@gmail.com
State New, archived
Headers show

Commit Message

Rashika Oct. 21, 2013, 10:03 a.m. UTC
This patch fixes the following checkpatch.pl warning in backref.c-
WARNING: quoted string split across lines 

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 fs/btrfs/backref.c |   22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

Comments

Josh Triplett Oct. 21, 2013, 7:50 p.m. UTC | #1
On Mon, Oct 21, 2013 at 03:33:57PM +0530, Rashika Kheria wrote:
> This patch fixes the following checkpatch.pl warning in backref.c-
> WARNING: quoted string split across lines 
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>.

>  fs/btrfs/backref.c |   22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index c63aa34c..322bcb4 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -313,8 +313,7 @@ static int __resolve_indirect_ref(struct btrfs_fs_info *fs_info,
>  
>  	path->lowest_level = level;
>  	ret = btrfs_search_old_slot(root, &ref->key_for_search, path, time_seq);
> -	pr_debug("search slot in root %llu (level %d, ref count %d) returned "
> -		 "%d for key (%llu %u %llu)\n",
> +	pr_debug("search slot in root %llu (level %d, ref count %d) returned %d for key (%llu %u %llu)\n",
>  		 ref->root_id, level, ref->count, ret,
>  		 ref->key_for_search.objectid, ref->key_for_search.type,
>  		 ref->key_for_search.offset);
> @@ -1354,8 +1353,7 @@ int extent_from_logical(struct btrfs_fs_info *fs_info, u64 logical,
>  	ei = btrfs_item_ptr(eb, path->slots[0], struct btrfs_extent_item);
>  	flags = btrfs_extent_flags(eb, ei);
>  
> -	pr_debug("logical %llu is at position %llu within the extent (%llu "
> -		 "EXTENT_ITEM %llu) flags %#llx size %u\n",
> +	pr_debug("logical %llu is at position %llu within the extent (%llu EXTENT_ITEM %llu) flags %#llx size %u\n",
>  		 logical, logical - found_key->objectid, found_key->objectid,
>  		 found_key->offset, flags, item_size);
>  
> @@ -1469,9 +1467,9 @@ static int iterate_leaf_refs(struct extent_inode_elem *inode_list,
>  	int ret = 0;
>  
>  	for (eie = inode_list; eie; eie = eie->next) {
> -		pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), "
> -			 "root %llu\n", extent_item_objectid,
> -			 eie->inum, eie->offset, root);
> +		pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), root %llu\n",
> +			 extent_item_objectid, eie->inum,
> +			 eie->offset, root);
>  		ret = iterate(eie->inum, eie->offset, root, ctx);
>  		if (ret) {
>  			pr_debug("stopping iteration for %llu due to ret=%d\n",
> @@ -1527,8 +1525,8 @@ int iterate_extent_inodes(struct btrfs_fs_info *fs_info,
>  			break;
>  		ULIST_ITER_INIT(&root_uiter);
>  		while (!ret && (root_node = ulist_next(roots, &root_uiter))) {
> -			pr_debug("root %llu references leaf %llu, data list "
> -				 "%#llx\n", root_node->val, ref_node->val,
> +			pr_debug("root %llu references leaf %llu, data list %#llx\n",
> +				 root_node->val, ref_node->val,
>  				 ref_node->aux);
>  			ret = iterate_leaf_refs((struct extent_inode_elem *)
>  						(uintptr_t)ref_node->aux,
> @@ -1620,9 +1618,9 @@ static int iterate_inode_refs(u64 inum, struct btrfs_root *fs_root,
>  		for (cur = 0; cur < btrfs_item_size(eb, item); cur += len) {
>  			name_len = btrfs_inode_ref_name_len(eb, iref);
>  			/* path must be released before calling iterate()! */
> -			pr_debug("following ref at offset %u for inode %llu in "
> -				 "tree %llu\n", cur, found_key.objectid,
> -				 fs_root->objectid);
> +			pr_debug("following ref at offset %u for inode %llu in tree %llu\n",
> +				  cur, found_key.objectid,
> +				  fs_root->objectid);
>  			ret = iterate(parent, name_len,
>  				      (unsigned long)(iref + 1), eb, ctx);
>  			if (ret)
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Zach Brown Oct. 29, 2013, 11:06 p.m. UTC | #2
On Mon, Oct 21, 2013 at 03:33:57PM +0530, Rashika Kheria wrote:
> This patch fixes the following checkpatch.pl warning in backref.c-
> WARNING: quoted string split across lines 
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Zach Brown <zab@redhat.com>
diff mbox

Patch

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index c63aa34c..322bcb4 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -313,8 +313,7 @@  static int __resolve_indirect_ref(struct btrfs_fs_info *fs_info,
 
 	path->lowest_level = level;
 	ret = btrfs_search_old_slot(root, &ref->key_for_search, path, time_seq);
-	pr_debug("search slot in root %llu (level %d, ref count %d) returned "
-		 "%d for key (%llu %u %llu)\n",
+	pr_debug("search slot in root %llu (level %d, ref count %d) returned %d for key (%llu %u %llu)\n",
 		 ref->root_id, level, ref->count, ret,
 		 ref->key_for_search.objectid, ref->key_for_search.type,
 		 ref->key_for_search.offset);
@@ -1354,8 +1353,7 @@  int extent_from_logical(struct btrfs_fs_info *fs_info, u64 logical,
 	ei = btrfs_item_ptr(eb, path->slots[0], struct btrfs_extent_item);
 	flags = btrfs_extent_flags(eb, ei);
 
-	pr_debug("logical %llu is at position %llu within the extent (%llu "
-		 "EXTENT_ITEM %llu) flags %#llx size %u\n",
+	pr_debug("logical %llu is at position %llu within the extent (%llu EXTENT_ITEM %llu) flags %#llx size %u\n",
 		 logical, logical - found_key->objectid, found_key->objectid,
 		 found_key->offset, flags, item_size);
 
@@ -1469,9 +1467,9 @@  static int iterate_leaf_refs(struct extent_inode_elem *inode_list,
 	int ret = 0;
 
 	for (eie = inode_list; eie; eie = eie->next) {
-		pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), "
-			 "root %llu\n", extent_item_objectid,
-			 eie->inum, eie->offset, root);
+		pr_debug("ref for %llu resolved, key (%llu EXTEND_DATA %llu), root %llu\n",
+			 extent_item_objectid, eie->inum,
+			 eie->offset, root);
 		ret = iterate(eie->inum, eie->offset, root, ctx);
 		if (ret) {
 			pr_debug("stopping iteration for %llu due to ret=%d\n",
@@ -1527,8 +1525,8 @@  int iterate_extent_inodes(struct btrfs_fs_info *fs_info,
 			break;
 		ULIST_ITER_INIT(&root_uiter);
 		while (!ret && (root_node = ulist_next(roots, &root_uiter))) {
-			pr_debug("root %llu references leaf %llu, data list "
-				 "%#llx\n", root_node->val, ref_node->val,
+			pr_debug("root %llu references leaf %llu, data list %#llx\n",
+				 root_node->val, ref_node->val,
 				 ref_node->aux);
 			ret = iterate_leaf_refs((struct extent_inode_elem *)
 						(uintptr_t)ref_node->aux,
@@ -1620,9 +1618,9 @@  static int iterate_inode_refs(u64 inum, struct btrfs_root *fs_root,
 		for (cur = 0; cur < btrfs_item_size(eb, item); cur += len) {
 			name_len = btrfs_inode_ref_name_len(eb, iref);
 			/* path must be released before calling iterate()! */
-			pr_debug("following ref at offset %u for inode %llu in "
-				 "tree %llu\n", cur, found_key.objectid,
-				 fs_root->objectid);
+			pr_debug("following ref at offset %u for inode %llu in tree %llu\n",
+				  cur, found_key.objectid,
+				  fs_root->objectid);
 			ret = iterate(parent, name_len,
 				      (unsigned long)(iref + 1), eb, ctx);
 			if (ret)