From patchwork Wed Jul 31 17:52:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ayman Bagabas X-Patchwork-Id: 11068975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C8EDE1399 for ; Wed, 31 Jul 2019 17:53:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B002826B41 for ; Wed, 31 Jul 2019 17:53:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A072926E3A; Wed, 31 Jul 2019 17:53:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 139DE26B41 for ; Wed, 31 Jul 2019 17:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbfGaRxT (ORCPT ); Wed, 31 Jul 2019 13:53:19 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:41256 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728083AbfGaRxT (ORCPT ); Wed, 31 Jul 2019 13:53:19 -0400 Received: by mail-yb1-f195.google.com with SMTP id x188so2569443yba.8; Wed, 31 Jul 2019 10:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=clQOczYwEsKKHOAzZidWMeMT4c+c0AdrHLZADibcT5I=; b=qtPMGVH9PUQ/+dE6cuBI6LI/EtpmD15PTdVfRTwKmwp+oVagxHGMCTuNcYF1sOKQ6Y u8nS9XEx7lSwYVrEuo91smZFoJltUuxWU+snobEQTKcmzcHgU5Zz6G2SnWnqtUdp070f qCbhdYOFE54xYLAGIhxf+aclreDikaCBgfRecLXMBm92e3EBhAW0hR1b3uyYl5rxpANn oja5mLEK3kqWPtA8uLrS/fgBoiP13kvlQdHLQCEsaAWiDAc4ICNk1VUMq+15bgnWteuD H7jl4GHn6/jj7bOzWINYSIaG5bKn1gLi4w+WRMVB7fPuoaBv/0EgB1UXXNrAQhSHzHVw eOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=clQOczYwEsKKHOAzZidWMeMT4c+c0AdrHLZADibcT5I=; b=LStJiUhAw8HIpuEfKH0uuOxDz2faCGRQX48YtwjoR2esGv2CQ8kfUdrk3siVpbLZnY QUOXHiwN6JQdVb3Uh17rxNA7BUUxPy0Ipyf8qxEy41wOLJfqrxCC2+JKflKLc4Z9F3GC MpXanMZJsJRbl9bmNO6940/qggpLqtXJ0fEH1tsD+m6SO0pt6A8Thqkr0ybDZb8yJgUO ZLXiJltPBi3lX32c2aAg6/0SWwmZ45F+bWSLZSxNJ/+nhWK0u/cCb3dBmxWszYPrid+/ rMrOJrtXXEv9rkUSW8Y4j9m+nJXht9omeeJZd75+0dz29V1zUlulPtoxw9B0Tss+nWxb DrhQ== X-Gm-Message-State: APjAAAWZVLmVwEMMhxbO2ZR8LbplT5KWgCMDrYvmkZupwV4ZCPronmHh 66AyPhoZqTMZnMKDYhR4YA== X-Google-Smtp-Source: APXvYqwit9zPBEeViX3dtDsHj4rWdLwUWJH8Ua/8RJmrOWwoJVi3KhXDMNknjfxTZW2sM6j8lXVznQ== X-Received: by 2002:a25:46c1:: with SMTP id t184mr78929704yba.13.1564595598056; Wed, 31 Jul 2019 10:53:18 -0700 (PDT) Received: from localhost.localdomain ([12.156.111.130]) by smtp.gmail.com with ESMTPSA id w193sm10517294ywa.72.2019.07.31.10.53.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 10:53:17 -0700 (PDT) From: Ayman Bagabas To: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ayman Bagabas Subject: [RFC 0/9] platform/x86: Huawei WMI laptop extras driver Date: Wed, 31 Jul 2019 13:52:46 -0400 Message-Id: <20190731175255.25676-1-ayman.bagabas@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailer: git-send-email 2.20.1 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch series introduce changes to huawei-wmi driver that includes: * Move to platform driver * Implement WMI management interface * Add micmute LED support through WMI * Add battery charging protection support through WMI * Add fn-lock support through WMI * Implement driver quirks and parameters * Add a debugfs interface to WMI # Move to platform driver The current driver offers hotkeys and micmute led support only. With these changes, a platform driver makes more sense since it handles these changes pretty nicely. # Implement WMI management interface Huawei Matebook laptops come with two WMI interfaces. The first being WMI0 which is considered "legacy" and AFAIK only found on the Matebook X released in 2017. The second has a UID of "HWMI" and is found in pretty much all models with a slight difference in implementation except for the Matebook X (2017). Since this model has two interfaces, some aspects are controlled through the legacy interface and some through the other interface. Currently, the legacy interface is not fully implemented and is only used for hotkeys and further debugging has to be done. The WMI interface takes a 64 bit integer, although uses 32 bits most of the time, and returns a 256-260 bytes buffer consists of either one ACPI buffer of 260 bytes, in the case of Matebook X (2017), or one ACPI package of two buffers, one with 4 bytes, and the other with 256 bytes. We only care about the latter 256 buffer in both cases since the 4 bytes always return zeros. The first byte of this 256 buffer always has the return status where 1 indicated error. Some models require calling the WMI interface twice to execute a command. # Add micmute LED support through WMI After implementing the WMI interface, micmute LED can be controlled easily. Models with the legacy interface fall back to ACPI EC method control since the legacy interface is not implemented. # Add battery charging protection support through WMI Most models, that has the WMI interface, are capable of battery protection where it can control battery charging thresholds and limits charging the battery to certain values. # Add fn-lock support through WMI The behavior of hotkeys is not the same among all models. Some models require fn-lock to do things like `Ctrl-Ins` or `Alt-PrtSc`. By default, hotkeys behave as special keys (media keys, Ins, etc), but if a modifier is used (ctrl, alt, shift) these keys behave as F1-F12 keys. If the Fn key is toggled on, the hotkeys with or without a modifier, behave as F1-F12 keys. This makes it impossible to use a modifier and `PrtSc` or `Ins`. Now, some models fix this by excluding `PrtSc` and `Ins` keys from being treated as F11 and F12 keys with the use of a modifier. However, some models do not, and fixes this by the so called fn-lock. Fn-lock inverts the behavior of the top row from special keys to F1-F12 keys. So a modifier and a special key would be possible which make things like `Alt-Ins` possible. Now, with fn-lock we would have 4 modes: * Fn-key off & fn-lock off - hotkeys treated as special keys using a modifier gives F1-F12 keys. * Fn-key on & fn-lock off - hotkeys treated as F1-F12 keys and using a modifier gives F1-F12. * Fn-key off & fn-lock on - hotkeys are treated as F1-F12 keys and using a modifier gives special keys. * Fn-key on & fn-lock on - hotkeys are treated as special keys and using a modifier gives special keys. # Implement driver quirks and parameters The driver introduces 3 quirks and 2 parameters that can change the driver's behavior. These quirks being as: 1. Fixes reporting brightness keys twice since it's already handled by acpi-video. 2. Some models need a short delay when setting battery thresholds to prevent a race condition when two processes read/write. 3. Matebook X (2017) handles micmute led through the "legacy" interface which is not currently implemented. Use ACPI EC method to control this led. and the 2 parameters can enforce the behavior of quirk 1 & 2. # Add a debugfs interface to WMI An interface to the WMI management interface that allows easier debugging. Ayman Bagabas (9): platform/x86: huawei-wmi: rename guid and driver name platform/x86: huawei-wmi: move to platform driver platform/x86: huawei-wmi: implement huawei wmi management interface platform/x86: huawei-wmi: add quirks and module parameters platform/x86: huawei-wmi: control micmute led through wmi interface platform/x86: huawei-wmi: add battery charging thresholds platform/x86: huawei-wmi: add fn-lock support platform/x86: huawei-wmi: add sysfs interface support platform/x86: huawei-wmi: add debugfs support drivers/platform/x86/huawei-wmi.c | 710 ++++++++++++++++++++++++++---- 1 file changed, 629 insertions(+), 81 deletions(-)