| Message ID | 20200502182951.114231-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/x86: intel-vbtn: Fixes + rework to make it work on more devices | expand |
> -----Original Message----- > From: Hans de Goede <hdegoede@redhat.com> > Sent: Saturday, May 2, 2020 1:30 PM > To: Darren Hart; Andy Shevchenko; Limonciello, Mario > Cc: Hans de Goede; linux-acpi@vger.kernel.org; platform-driver- > x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH 0/5] platform/x86: intel-vbtn: Fixes + rework to make it work > on more devices > > > [EXTERNAL EMAIL] > > Hi All, > > Here is a series of fixes, mostly aimed at fixing commit: de9647efeaa9 > ("platform/x86: intel-vbtn: Only activate tablet mode switch on 2-in-1's") > causing the driver to not bind on some devices where it could and > should report SW_TABLET_MODE. > > The last commit makes the driver also work on some devices where it > previously would not work because they lack a VBDL method. > > Mario, can you test this on a Dell XPS 9360 (for which you wrote the > de9647efeaa9 commit) to ensure that this series does not cause a > regression there? Unfortunately I can't double check that with WFH, I don't have access to this hardware. > Also I have a question for you about using the DMI > chassis-type for this / a proposal for dealing with this differently > below the '---' of the commit msg of the 4th patch. OK will look.
Hi All, Here is a series of fixes, mostly aimed at fixing commit: de9647efeaa9 ("platform/x86: intel-vbtn: Only activate tablet mode switch on 2-in-1's") causing the driver to not bind on some devices where it could and should report SW_TABLET_MODE. The last commit makes the driver also work on some devices where it previously would not work because they lack a VBDL method. Mario, can you test this on a Dell XPS 9360 (for which you wrote the de9647efeaa9 commit) to ensure that this series does not cause a regression there? Also I have a question for you about using the DMI chassis-type for this / a proposal for dealing with this differently below the '---' of the commit msg of the 4th patch. Regards, Hans