| Message ID | 20201005160307.39201-1-luzmaximilian@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/surface: Create a platform subdirectory for Microsoft Surface devices | expand |
Hi Maximilian, On 10/5/20 6:03 PM, Maximilian Luz wrote: > As has come up in the discussion around > > [RFC PATCH] Add support for Microsoft Surface System Aggregator Module > > it may make sense to add a Microsoft Surface specific platform > subdirectory. Andy has suggested drivers/platform/surface for that. > This series follows said suggestion and creates that subdirectory, as > well as moves Microsoft Surface related drivers over to it and updates > their MAINTAINERS entries (if available) accordingly. > > This series does not modify any existing driver code, symbols, or help > text. In case you do not know I'm taking over from any as drivers/platform/x86 maintainer. I'm fine with the concept of this series, but who is going to maintain this new drivers/platform/surface directory ? Ah I see that the first patch answers that question and the plan is to keep this part of the pdx86 maintainership. I would prefer for the new dir to have its own MAINTAINERS entry if I'm honest, I would like to try and split maintainership for the surface stuff as follows: 1. Who will review (and add their Reviewed-by or ask for improvements or nack) patches to files in this dir? 2. Who will gather approved patches apply them to a for-next branch and send them out to Linus during the merge Window? I can pick up 2. but I could really use some help with 1. So I was thinking having a separate MAINTAINERS entry for the new dir with you (Maximilian) (and me and Mark Gross) listed as MAINTAINERS; and then I'm hoping that you can do the review of surface related patches. At least those which you have not written yourself. How does that sound ? Regards, Hans > Link to discussion: > https://lore.kernel.org/lkml/CAHp75Vfp86h38Rd-VEgER7ASADdmz5ymAkuHvD0Q6WPDqZBqHw@mail.gmail.com/ > > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > > Changes in v2: > - Rebase onto linux-platform-drivers-x86/for-next to incorporate > changes in Maintainer file. > > For more details regarding changes, refer to the individual patches. > > Maximilian Luz (5): > platform: Add Surface platform directory > platform/surface: Move Surface 3 WMI driver to platform/surface > platform/surface: Move Surface 3 Button driver to platform/surface > platform/surface: Move Surface 3 Power OpRegion driver to > platform/surface > platform/surface: Move Surface Pro 3 Button driver to platform/surface > > MAINTAINERS | 3 +- > drivers/platform/Kconfig | 2 + > drivers/platform/Makefile | 1 + > drivers/platform/surface/Kconfig | 49 +++++++++++++++++++ > drivers/platform/surface/Makefile | 10 ++++ > .../platform/{x86 => surface}/surface3-wmi.c | 0 > .../{x86 => surface}/surface3_button.c | 0 > .../{x86 => surface}/surface3_power.c | 0 > .../{x86 => surface}/surfacepro3_button.c | 0 > drivers/platform/x86/Kconfig | 31 ------------ > drivers/platform/x86/Makefile | 6 --- > 11 files changed, 64 insertions(+), 38 deletions(-) > create mode 100644 drivers/platform/surface/Kconfig > create mode 100644 drivers/platform/surface/Makefile > rename drivers/platform/{x86 => surface}/surface3-wmi.c (100%) > rename drivers/platform/{x86 => surface}/surface3_button.c (100%) > rename drivers/platform/{x86 => surface}/surface3_power.c (100%) > rename drivers/platform/{x86 => surface}/surfacepro3_button.c (100%) >
On 10/8/20 1:44 PM, Hans de Goede wrote: > Hi Maximilian, > > On 10/5/20 6:03 PM, Maximilian Luz wrote: >> As has come up in the discussion around >> >> [RFC PATCH] Add support for Microsoft Surface System Aggregator Module >> >> it may make sense to add a Microsoft Surface specific platform >> subdirectory. Andy has suggested drivers/platform/surface for that. >> This series follows said suggestion and creates that subdirectory, as >> well as moves Microsoft Surface related drivers over to it and updates >> their MAINTAINERS entries (if available) accordingly. >> >> This series does not modify any existing driver code, symbols, or help >> text. > > In case you do not know I'm taking over from any as > drivers/platform/x86 maintainer. > > I'm fine with the concept of this series, but who is going to maintain > this new drivers/platform/surface directory ? > > Ah I see that the first patch answers that question and the plan > is to keep this part of the pdx86 maintainership. > > I would prefer for the new dir to have its own > MAINTAINERS entry if I'm honest, I would like to try and > split maintainership for the surface stuff as follows: > > 1. Who will review (and add their Reviewed-by or ask for improvements > or nack) patches to files in this dir? > > 2. Who will gather approved patches apply them to a for-next branch > and send them out to Linus during the merge Window? > > I can pick up 2. but I could really use some help with 1. So I > was thinking having a separate MAINTAINERS entry for the new > dir with you (Maximilian) (and me and Mark Gross) listed as > MAINTAINERS; and then I'm hoping that you can do the review > of surface related patches. At least those which you have not > written yourself. > > How does that sound ? Sounds good, I'd be happy to help review and approve any Surface related patches. However, I think it would be beneficial if you and Mark still have a final look (and say) over the ones I've reviewed and accepted (if that's not already a given). I feel like I may lack a bit of experience for this job and might miss some things. I'll add the MAINTAINERS entry and send a v3 later today, if that's OK. Regards, Max
Hi, On 10/8/20 2:32 PM, Maximilian Luz wrote: > On 10/8/20 1:44 PM, Hans de Goede wrote: >> Hi Maximilian, >> >> On 10/5/20 6:03 PM, Maximilian Luz wrote: >>> As has come up in the discussion around >>> >>> [RFC PATCH] Add support for Microsoft Surface System Aggregator Module >>> >>> it may make sense to add a Microsoft Surface specific platform >>> subdirectory. Andy has suggested drivers/platform/surface for that. >>> This series follows said suggestion and creates that subdirectory, as >>> well as moves Microsoft Surface related drivers over to it and updates >>> their MAINTAINERS entries (if available) accordingly. >>> >>> This series does not modify any existing driver code, symbols, or help >>> text. >> >> In case you do not know I'm taking over from any as >> drivers/platform/x86 maintainer. >> >> I'm fine with the concept of this series, but who is going to maintain >> this new drivers/platform/surface directory ? >> >> Ah I see that the first patch answers that question and the plan >> is to keep this part of the pdx86 maintainership. >> >> I would prefer for the new dir to have its own >> MAINTAINERS entry if I'm honest, I would like to try and >> split maintainership for the surface stuff as follows: >> >> 1. Who will review (and add their Reviewed-by or ask for improvements >> or nack) patches to files in this dir? >> >> 2. Who will gather approved patches apply them to a for-next branch >> and send them out to Linus during the merge Window? >> >> I can pick up 2. but I could really use some help with 1. So I >> was thinking having a separate MAINTAINERS entry for the new >> dir with you (Maximilian) (and me and Mark Gross) listed as >> MAINTAINERS; and then I'm hoping that you can do the review >> of surface related patches. At least those which you have not >> written yourself. >> >> How does that sound ? > > Sounds good, I'd be happy to help review and approve any Surface related > patches. However, I think it would be beneficial if you and Mark still > have a final look (and say) over the ones I've reviewed and accepted (if > that's not already a given). I feel like I may lack a bit of experience > for this job and might miss some things. Since Mark or I will be merging the patches we will indeed still take a look at them, but it helps if someone else has already done a review first. > I'll add the MAINTAINERS entry and send a v3 later today, if that's OK. That sounds good, thanks. Regards, Hans
On Thu, Oct 8, 2020 at 2:44 PM Hans de Goede <hdegoede@redhat.com> wrote: > On 10/5/20 6:03 PM, Maximilian Luz wrote: > > As has come up in the discussion around > > > > [RFC PATCH] Add support for Microsoft Surface System Aggregator Module > > > > it may make sense to add a Microsoft Surface specific platform > > subdirectory. Andy has suggested drivers/platform/surface for that. > > This series follows said suggestion and creates that subdirectory, as > > well as moves Microsoft Surface related drivers over to it and updates > > their MAINTAINERS entries (if available) accordingly. > > > > This series does not modify any existing driver code, symbols, or help > > text. > > In case you do not know I'm taking over from any as > drivers/platform/x86 maintainer. > > I'm fine with the concept of this series, but who is going to maintain > this new drivers/platform/surface directory ? > > Ah I see that the first patch answers that question and the plan > is to keep this part of the pdx86 maintainership. > > I would prefer for the new dir to have its own > MAINTAINERS entry if I'm honest, I would like to try and > split maintainership for the surface stuff as follows: > > 1. Who will review (and add their Reviewed-by or ask for improvements > or nack) patches to files in this dir? > > 2. Who will gather approved patches apply them to a for-next branch > and send them out to Linus during the merge Window? > > I can pick up 2. but I could really use some help with 1. So I > was thinking having a separate MAINTAINERS entry for the new > dir with you (Maximilian) (and me and Mark Gross) listed as > MAINTAINERS; and then I'm hoping that you can do the review > of surface related patches. At least those which you have not > written yourself. The idea was exactly like you described, i.e. taking 2 while relying on 1 done by someone more familiar with that. JFYI: for Mellanox we required Vadim to Rb their code before us.
On 10/8/20 3:38 PM, Hans de Goede wrote: > Hi, > > On 10/8/20 2:32 PM, Maximilian Luz wrote: >> On 10/8/20 1:44 PM, Hans de Goede wrote: >>> Hi Maximilian, >>> >>> On 10/5/20 6:03 PM, Maximilian Luz wrote: >>>> As has come up in the discussion around >>>> >>>> [RFC PATCH] Add support for Microsoft Surface System Aggregator Module >>>> >>>> it may make sense to add a Microsoft Surface specific platform >>>> subdirectory. Andy has suggested drivers/platform/surface for that. >>>> This series follows said suggestion and creates that subdirectory, as >>>> well as moves Microsoft Surface related drivers over to it and updates >>>> their MAINTAINERS entries (if available) accordingly. >>>> >>>> This series does not modify any existing driver code, symbols, or help >>>> text. >>> >>> In case you do not know I'm taking over from any as >>> drivers/platform/x86 maintainer. >>> >>> I'm fine with the concept of this series, but who is going to maintain >>> this new drivers/platform/surface directory ? >>> >>> Ah I see that the first patch answers that question and the plan >>> is to keep this part of the pdx86 maintainership. >>> >>> I would prefer for the new dir to have its own >>> MAINTAINERS entry if I'm honest, I would like to try and >>> split maintainership for the surface stuff as follows: >>> >>> 1. Who will review (and add their Reviewed-by or ask for improvements >>> or nack) patches to files in this dir? >>> >>> 2. Who will gather approved patches apply them to a for-next branch >>> and send them out to Linus during the merge Window? >>> >>> I can pick up 2. but I could really use some help with 1. So I >>> was thinking having a separate MAINTAINERS entry for the new >>> dir with you (Maximilian) (and me and Mark Gross) listed as >>> MAINTAINERS; and then I'm hoping that you can do the review >>> of surface related patches. At least those which you have not >>> written yourself. >>> >>> How does that sound ? >> >> Sounds good, I'd be happy to help review and approve any Surface related >> patches. However, I think it would be beneficial if you and Mark still >> have a final look (and say) over the ones I've reviewed and accepted (if >> that's not already a given). I feel like I may lack a bit of experience >> for this job and might miss some things. > > Since Mark or I will be merging the patches we will indeed still take > a look at them, but it helps if someone else has already done a review > first. Perfect, thank you! I'll take on 1) then. Regards, Max
Hi, On 10/8/20 2:32 PM, Maximilian Luz wrote: > On 10/8/20 1:44 PM, Hans de Goede wrote: >> Hi Maximilian, >> >> On 10/5/20 6:03 PM, Maximilian Luz wrote: >>> As has come up in the discussion around >>> >>> [RFC PATCH] Add support for Microsoft Surface System Aggregator Module >>> >>> it may make sense to add a Microsoft Surface specific platform >>> subdirectory. Andy has suggested drivers/platform/surface for that. >>> This series follows said suggestion and creates that subdirectory, as >>> well as moves Microsoft Surface related drivers over to it and updates >>> their MAINTAINERS entries (if available) accordingly. >>> >>> This series does not modify any existing driver code, symbols, or help >>> text. >> >> In case you do not know I'm taking over from any as >> drivers/platform/x86 maintainer. >> >> I'm fine with the concept of this series, but who is going to maintain >> this new drivers/platform/surface directory ? >> >> Ah I see that the first patch answers that question and the plan >> is to keep this part of the pdx86 maintainership. >> >> I would prefer for the new dir to have its own >> MAINTAINERS entry if I'm honest, I would like to try and >> split maintainership for the surface stuff as follows: >> >> 1. Who will review (and add their Reviewed-by or ask for improvements >> or nack) patches to files in this dir? >> >> 2. Who will gather approved patches apply them to a for-next branch >> and send them out to Linus during the merge Window? >> >> I can pick up 2. but I could really use some help with 1. So I >> was thinking having a separate MAINTAINERS entry for the new >> dir with you (Maximilian) (and me and Mark Gross) listed as >> MAINTAINERS; and then I'm hoping that you can do the review >> of surface related patches. At least those which you have not >> written yourself. >> >> How does that sound ? > > Sounds good, I'd be happy to help review and approve any Surface related > patches. However, I think it would be beneficial if you and Mark still > have a final look (and say) over the ones I've reviewed and accepted (if > that's not already a given). I feel like I may lack a bit of experience > for this job and might miss some things. Since Mark or I will be merging the patches we will indeed still take a look at them, but it helps if someone else has already done a review first. > I'll add the MAINTAINERS entry and send a v3 later today, if that's OK. That sounds good, thanks. Regards, Hans
As has come up in the discussion around [RFC PATCH] Add support for Microsoft Surface System Aggregator Module it may make sense to add a Microsoft Surface specific platform subdirectory. Andy has suggested drivers/platform/surface for that. This series follows said suggestion and creates that subdirectory, as well as moves Microsoft Surface related drivers over to it and updates their MAINTAINERS entries (if available) accordingly. This series does not modify any existing driver code, symbols, or help text. Thanks, Max Link to discussion: https://lore.kernel.org/lkml/CAHp75Vfp86h38Rd-VEgER7ASADdmz5ymAkuHvD0Q6WPDqZBqHw@mail.gmail.com/ Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Changes in v2: - Rebase onto linux-platform-drivers-x86/for-next to incorporate changes in Maintainer file. For more details regarding changes, refer to the individual patches. Maximilian Luz (5): platform: Add Surface platform directory platform/surface: Move Surface 3 WMI driver to platform/surface platform/surface: Move Surface 3 Button driver to platform/surface platform/surface: Move Surface 3 Power OpRegion driver to platform/surface platform/surface: Move Surface Pro 3 Button driver to platform/surface MAINTAINERS | 3 +- drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/surface/Kconfig | 49 +++++++++++++++++++ drivers/platform/surface/Makefile | 10 ++++ .../platform/{x86 => surface}/surface3-wmi.c | 0 .../{x86 => surface}/surface3_button.c | 0 .../{x86 => surface}/surface3_power.c | 0 .../{x86 => surface}/surfacepro3_button.c | 0 drivers/platform/x86/Kconfig | 31 ------------ drivers/platform/x86/Makefile | 6 --- 11 files changed, 64 insertions(+), 38 deletions(-) create mode 100644 drivers/platform/surface/Kconfig create mode 100644 drivers/platform/surface/Makefile rename drivers/platform/{x86 => surface}/surface3-wmi.c (100%) rename drivers/platform/{x86 => surface}/surface3_button.c (100%) rename drivers/platform/{x86 => surface}/surface3_power.c (100%) rename drivers/platform/{x86 => surface}/surfacepro3_button.c (100%)