[0/7] platform/x86: dell-wmi-sysman: Various error-handling and robustness fixes

Message

Hans de Goede March 20, 2021, 2:34 p.m. UTC

Hi All,

There have been several bug-reports about crashes related to the
dell-wmi-sysman module:

https://bugzilla.redhat.com/show_bug.cgi?id=1936171
https://bugzilla.kernel.org/show_bug.cgi?id=211895
https://bugs.archlinux.org/task/69702

This patch series contains a bunch of fixes for NULL pointer derefs,
double-frees, etc. Which will hopefully fix this.

I don't have any hardware which actually exposes the used interface,
so I've only been able to verify that the driver now cleanly refuses
to load on Dell devices without the interface.

If someone from Dell can test this to ensure that it does not cause
regressions on devices with the interface that would be great.

Regards,

Hans


Hans de Goede (7):
  platform/x86: dell-wmi-sysman: Fix possible NULL pointer deref on exit
  platform/x86: dell-wmi-sysman: Make it safe to call
    exit_foo_attributes() multiple times
  platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting
    called twice on init_bios_attributes() failure
  platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit
    handling
  platform/x86: dell-wmi-sysman: Make sysman_init() return -ENODEV of
    the interfaces are not found
  platform/x86: dell-wmi-sysman: Make init_bios_attributes() ACPI object
    parsing more robust
  platform/x86: dell-wmi-sysman: Cleanup
    create_attributes_level_sysfs_files()

 .../dell/dell-wmi-sysman/enum-attributes.c    |   3 +
 .../x86/dell/dell-wmi-sysman/int-attributes.c |   3 +
 .../dell/dell-wmi-sysman/passobj-attributes.c |   3 +
 .../dell/dell-wmi-sysman/string-attributes.c  |   3 +
 .../x86/dell/dell-wmi-sysman/sysman.c         | 117 +++++++++---------
 5 files changed, 71 insertions(+), 58 deletions(-)