mbox series

[0/2] Remove GA14/15 quirks to acpi/video_detect

Message ID 20210419074915.393433-1-luke@ljones.dev (mailing list archive)
Headers show
Series Remove GA14/15 quirks to acpi/video_detect | expand

Message

Luke Jones April 19, 2021, 7:49 a.m. UTC
Revert two commits to allow a patch to acpi/video_detect to correctly
set the backlight control as native.

Luke D. Jones (2):
  Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
    structures"
  Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus
    G14 and G15"

 drivers/platform/x86/asus-nb-wmi.c | 77 ------------------------------
 1 file changed, 77 deletions(-)

--
2.31.1

Comments

Hans de Goede April 19, 2021, 8 a.m. UTC | #1
Hi Luke,

On 4/19/21 9:49 AM, Luke D. Jones wrote:
> Revert two commits to allow a patch to acpi/video_detect to correctly
> set the backlight control as native.

Thank you for following up on our previous discussion about this.

I'll merge this as soon as Rafael has accepted to matching
drivers/acpi/video_detect.c patch.

Regards,

Hans


> Luke D. Jones (2):
>   Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
>     structures"
>   Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus
>     G14 and G15"
> 
>  drivers/platform/x86/asus-nb-wmi.c | 77 ------------------------------
>  1 file changed, 77 deletions(-)
> 
> --
> 2.31.1
>
Hans de Goede April 19, 2021, 8:16 a.m. UTC | #2
Hi,

On 4/19/21 10:02 AM, Luke Jones wrote:
> NP Hans, sorry about the length of time this took. Other duties etc.
> 
> I appreciated the wealth of insight you were able to provide to enable this.

BTW, I see that your drivers/acpi/video_detect.c patch is marked as [PATCH 1/3] I
guess these 2 patches are patch 2/3 and 3/3 ?  You may want to send a reply to
your own patch to make that clear and to explain that it is a standalone
patch.

Please Cc my on the reply.

Regards,

Hans
Hans de Goede May 21, 2021, 10:24 a.m. UTC | #3
Hi Luke,

On 4/19/21 9:49 AM, Luke D. Jones wrote:
> Revert two commits to allow a patch to acpi/video_detect to correctly
> set the backlight control as native.
> 
> Luke D. Jones (2):
>   Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
>     structures"
>   Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus
>     G14 and G15"

Thank you, since the matching drivers/acpi/video_detect.c have been merged
by Rafael, I've added these to my review-hans branch now.

But there is one problem, these miss a:

Signed-off-by: Luke D. Jones <luke@ljones.dev>

In their commit message, I assume this was an oversight, so I've added
this. If you can let me know if this is ok, then I can push these to
for-next.

I've also rewritten the commit messages to explain why things are being
reverted, see:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Regards,

Hans
Luke Jones May 21, 2021, 10:36 a.m. UTC | #4
Oh, thanks Hans. I wasn't sure how a git revert was meant to work and 
assumed that
whatever git did was fine.

I am absolutely happy for you to take care of those issues and push 
ahead.

Many thanks!

On Fri, May 21 2021 at 12:24:13 +0200, Hans de Goede 
<hdegoede@redhat.com> wrote:
> Hi Luke,
> 
> On 4/19/21 9:49 AM, Luke D. Jones wrote:
>>  Revert two commits to allow a patch to acpi/video_detect to 
>> correctly
>>  set the backlight control as native.
>> 
>>  Luke D. Jones (2):
>>    Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
>>      structures"
>>    Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG 
>> Zephyrus
>>      G14 and G15"
> 
> Thank you, since the matching drivers/acpi/video_detect.c have been 
> merged
> by Rafael, I've added these to my review-hans branch now.
> 
> But there is one problem, these miss a:
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> 
> In their commit message, I assume this was an oversight, so I've added
> this. If you can let me know if this is ok, then I can push these to
> for-next.
> 
> I've also rewritten the commit messages to explain why things are 
> being
> reverted, see:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Regards,
> 
> Hans
>
Hans de Goede May 21, 2021, 4:58 p.m. UTC | #5
Hi,

On 5/21/21 12:35 PM, Luke Jones wrote:
> Oh, thanks Hans. I wasn't sure how a git revert was meant to work and assumed that
> whatever git did was fine.
> 
> I am absolutely happy for you to take care of those issues and push ahead.

Ok, I've pushed these 2 patches to pdx86/for-next now.

Regards,

Hans


> On Fri, May 21 2021 at 12:24:13 +0200, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi Luke, On 4/19/21 9:49 AM, Luke D. Jones wrote:
>>
>>     Revert two commits to allow a patch to acpi/video_detect to correctly set the backlight control as native. Luke D. Jones (2): Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk structures" Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus G14 and G15" 
>>
>> Thank you, since the matching drivers/acpi/video_detect.c have been merged by Rafael, I've added these to my review-hans branch now. But there is one problem, these miss a: Signed-off-by: Luke D. Jones <luke@ljones.dev <mailto:luke@ljones.dev>> In their commit message, I assume this was an oversight, so I've added this. If you can let me know if this is ok, then I can push these to for-next. I've also rewritten the commit messages to explain why things are being reverted, see: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans <https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans> Regards, Hans