| Message ID | 20211018143324.296961-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC/pdx86/input: Introduce and use soc_intel_is_*() helpers | expand |
On Mon, Oct 18, 2021 at 5:33 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > We have been open-coding x86_match_cpu() checks for enabling some > SoC specific behavior in various places. > > The sound/soc/intel drivers used to also open-code this but this was > cleaned up a while ago introducing a number of soc_intel_is_*() helpers. > > This series moves the definition of these helpers to a more public place > and uses it in a couple of more places outside the sound tree. > > Mark, I know we are a bit late in the cycle, but if you can pick up > patch 1/3 (assuming on one objects) for 5.16, then the rest can be I suppose s/on one/no-one/ :-) > applied after 5.16-rc1 is out. What I like about this series is dropping ugly ifdeffery here and there and consolidating it in one place. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> P.S. Btw, since you are the maintainer of PDx86 it means either you or Mark (whoever gives an Ack to the other one) can take at least two patches that makes visible that the change is not just for a single user. > Hans de Goede (3): > ASoC: Intel: Move soc_intel_is_foo() helpers to a generic header > platform/x86: intel_int0002_vgpio: Use the new soc_intel_is_byt/cht > helpers > Input: axp20x-pek - Use new soc_intel_is_cht() helper > > drivers/input/misc/axp20x-pek.c | 26 ++------- > drivers/platform/x86/intel/int0002_vgpio.c | 14 +---- > include/linux/platform_data/x86/soc.h | 65 ++++++++++++++++++++++ > sound/soc/intel/common/soc-intel-quirks.h | 51 +---------------- > 4 files changed, 75 insertions(+), 81 deletions(-) > create mode 100644 include/linux/platform_data/x86/soc.h > > -- > 2.31.1 >
Hi all, On 10/18/21 16:33, Hans de Goede wrote: > Hi All, > > We have been open-coding x86_match_cpu() checks for enabling some > SoC specific behavior in various places. > > The sound/soc/intel drivers used to also open-code this but this was > cleaned up a while ago introducing a number of soc_intel_is_*() helpers. > > This series moves the definition of these helpers to a more public place > and uses it in a couple of more places outside the sound tree. > > Mark, I know we are a bit late in the cycle, but if you can pick up > patch 1/3 (assuming on one objects) for 5.16, then the rest can be > applied after 5.16-rc1 is out. > > Regards, > > Hans Thank you all for the review and acks. I've pushed the entire series to: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans now, with Andy's Reviewed-by and the acks added and Andy's nitpicks addressed. Once the buildbot has had a chance to play with this I'll push this out to platform-drivers-x86/for-next. Regards, Hans > > > Hans de Goede (3): > ASoC: Intel: Move soc_intel_is_foo() helpers to a generic header > platform/x86: intel_int0002_vgpio: Use the new soc_intel_is_byt/cht > helpers > Input: axp20x-pek - Use new soc_intel_is_cht() helper > > drivers/input/misc/axp20x-pek.c | 26 ++------- > drivers/platform/x86/intel/int0002_vgpio.c | 14 +---- > include/linux/platform_data/x86/soc.h | 65 ++++++++++++++++++++++ > sound/soc/intel/common/soc-intel-quirks.h | 51 +---------------- > 4 files changed, 75 insertions(+), 81 deletions(-) > create mode 100644 include/linux/platform_data/x86/soc.h >
Hi All, We have been open-coding x86_match_cpu() checks for enabling some SoC specific behavior in various places. The sound/soc/intel drivers used to also open-code this but this was cleaned up a while ago introducing a number of soc_intel_is_*() helpers. This series moves the definition of these helpers to a more public place and uses it in a couple of more places outside the sound tree. Mark, I know we are a bit late in the cycle, but if you can pick up patch 1/3 (assuming on one objects) for 5.16, then the rest can be applied after 5.16-rc1 is out. Regards, Hans Hans de Goede (3): ASoC: Intel: Move soc_intel_is_foo() helpers to a generic header platform/x86: intel_int0002_vgpio: Use the new soc_intel_is_byt/cht helpers Input: axp20x-pek - Use new soc_intel_is_cht() helper drivers/input/misc/axp20x-pek.c | 26 ++------- drivers/platform/x86/intel/int0002_vgpio.c | 14 +---- include/linux/platform_data/x86/soc.h | 65 ++++++++++++++++++++++ sound/soc/intel/common/soc-intel-quirks.h | 51 +---------------- 4 files changed, 75 insertions(+), 81 deletions(-) create mode 100644 include/linux/platform_data/x86/soc.h