| Message ID | 20221213162359.651529-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/x86: Drop empty platform remove functions | expand |
Hello, On Tue, Dec 13, 2022 at 05:23:56PM +0100, Uwe Kleine-König wrote: > this series removes all platform remove functions that only return zero > below drivers/platform/x86. There is no reason to have these, as the only > caller is platform core code doing: > > if (drv->remove) { > int ret = drv->remove(dev); > > if (ret) > dev_warn(...) > } > > (in platform_remove()) and so having no remove function is both > equivalent and simpler. Gentle ping! I didn't get any feedback for this series yet after nearly a month. Best regards Uwe
Hi Uwe, On 1/12/23 23:01, Uwe Kleine-König wrote: > Hello, > > On Tue, Dec 13, 2022 at 05:23:56PM +0100, Uwe Kleine-König wrote: >> this series removes all platform remove functions that only return zero >> below drivers/platform/x86. There is no reason to have these, as the only >> caller is platform core code doing: >> >> if (drv->remove) { >> int ret = drv->remove(dev); >> >> if (ret) >> dev_warn(...) >> } >> >> (in platform_remove()) and so having no remove function is both >> equivalent and simpler. > > Gentle ping! I didn't get any feedback for this series yet after nearly > a month. This Monday I returned to work after 2 weeks of holiday :) And before that I was dealing with the upcoming merge window. I did do a whole bunch of patch review/merging this week, but those were all fixes for 6.2-rc#. I plan to do another round of patch merging coming Monday and these patches look fine, so I expect to merge them coming Monday. Regards, Hans
Hi, On 12/13/22 17:23, Uwe Kleine-König wrote: > Hello, > > this series removes all platform remove functions that only return zero > below drivers/platform/x86. There is no reason to have these, as the only > caller is platform core code doing: > > if (drv->remove) { > int ret = drv->remove(dev); > > if (ret) > dev_warn(...) > } > > (in platform_remove()) and so having no remove function is both > equivalent and simpler. Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > Uwe Kleine-König (3): > platform/x86: acerhdf: Drop empty platform remove function > platform/x86: intel: oaktrail: Drop empty platform remove function > platform/x86: intel: punit_ipc: Drop empty platform remove function > > drivers/platform/x86/acerhdf.c | 6 ------ > drivers/platform/x86/intel/oaktrail.c | 6 ------ > drivers/platform/x86/intel/punit_ipc.c | 6 ------ > 3 files changed, 18 deletions(-) > > > base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
Hello, this series removes all platform remove functions that only return zero below drivers/platform/x86. There is no reason to have these, as the only caller is platform core code doing: if (drv->remove) { int ret = drv->remove(dev); if (ret) dev_warn(...) } (in platform_remove()) and so having no remove function is both equivalent and simpler. Uwe Kleine-König (3): platform/x86: acerhdf: Drop empty platform remove function platform/x86: intel: oaktrail: Drop empty platform remove function platform/x86: intel: punit_ipc: Drop empty platform remove function drivers/platform/x86/acerhdf.c | 6 ------ drivers/platform/x86/intel/oaktrail.c | 6 ------ drivers/platform/x86/intel/punit_ipc.c | 6 ------ 3 files changed, 18 deletions(-) base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476