| Message ID | 20230301170215.23382-1-henning.schild@siemens.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | leds: simatic-ipc-leds-gpio: split up | expand |
On Wed, Mar 01, 2023 at 06:02:12PM +0100, Henning Schild wrote: > This series mainly splits the one GPIO driver into two. The split allows > to clearly model runtime and compile time dependencies on the GPIO chip > drivers. > > p1 is kind of not too related to that split but also prepares for more > GPIO based drivers to come. > > p2 takes the driver we had and puts some of its content into a -core, > to be used by the two drivers. > > p3 deals with more fine-grained configuration posibilities and compile > time dependencies. > > It is based on > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver Thank you for an update. Not big issues found (except maybe the Makefile).
Am Wed, 1 Mar 2023 19:30:38 +0200 schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > On Wed, Mar 01, 2023 at 06:02:12PM +0100, Henning Schild wrote: > > > This series mainly splits the one GPIO driver into two. The split > > allows to clearly model runtime and compile time dependencies on > > the GPIO chip drivers. > > > > p1 is kind of not too related to that split but also prepares for > > more GPIO based drivers to come. > > > > p2 takes the driver we had and puts some of its content into a > > -core, to be used by the two drivers. > > > > p3 deals with more fine-grained configuration posibilities and > > compile time dependencies. > > > > It is based on > > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO > > providing driver > > Thank you for an update. > Not big issues found (except maybe the Makefile). > The Makefile does work with all Y. So if that was all that was open, and the rest is just optional improvement. I would be happy if this can be merged as is, and deal with improvements later. Thanks! Henning
Ping. As far as i remember this one should be ready to merge. ACKed by Hans, and Andy had no objections given the maintainers would accept the patches. So i think it is the maintainers turn now, Pavel and/or Lee i guess. Henning Am Wed, 1 Mar 2023 18:02:12 +0100 schrieb Henning Schild <henning.schild@siemens.com>: > changes since v1: > - move from header- to -core.c-based implementation > - style changes from review > > This series mainly splits the one GPIO driver into two. The split > allows to clearly model runtime and compile time dependencies on the > GPIO chip drivers. > > p1 is kind of not too related to that split but also prepares for more > GPIO based drivers to come. > > p2 takes the driver we had and puts some of its content into a -core, > to be used by the two drivers. > > p3 deals with more fine-grained configuration posibilities and compile > time dependencies. > > It is based on > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO > providing driver > > Henning Schild (3): > leds: simatic-ipc-leds-gpio: move two extra gpio pins into another > table > leds: simatic-ipc-leds-gpio: split up into multiple drivers > leds: simatic-ipc-leds-gpio: introduce more Kconfig switches > > drivers/leds/simple/Kconfig | 31 +++- > drivers/leds/simple/Makefile | 5 +- > .../simple/simatic-ipc-leds-gpio-apollolake.c | 64 ++++++++ > .../leds/simple/simatic-ipc-leds-gpio-core.c | 103 +++++++++++++ > .../simple/simatic-ipc-leds-gpio-f7188x.c | 64 ++++++++ > drivers/leds/simple/simatic-ipc-leds-gpio.c | 139 > ------------------ drivers/leds/simple/simatic-ipc-leds-gpio.h | > 22 +++ drivers/platform/x86/simatic-ipc.c | 7 +- > 8 files changed, 288 insertions(+), 147 deletions(-) > create mode 100644 > drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c create mode > 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c create mode > 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c delete mode > 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c create mode 100644 > drivers/leds/simple/simatic-ipc-leds-gpio.h >
On Sat, 13 May 2023, Henning Schild wrote: > Ping. > > As far as i remember this one should be ready to merge. > > ACKed by Hans, and Andy had no objections given the maintainers would > accept the patches. > > So i think it is the maintainers turn now, Pavel and/or Lee i guess. Looks like there are lots of mail threads in reply to each of the patches. If these culminated in acceptance, please collect all of the Acks you've received until this point and submit a [RESEND]. If there are changes to be made still, please do the same but submit as a new version.
Am Mon, 15 May 2023 10:50:42 +0100 schrieb Lee Jones <lee@kernel.org>: > On Sat, 13 May 2023, Henning Schild wrote: > > > Ping. > > > > As far as i remember this one should be ready to merge. > > > > ACKed by Hans, and Andy had no objections given the maintainers > > would accept the patches. > > > > So i think it is the maintainers turn now, Pavel and/or Lee i > > guess. > > Looks like there are lots of mail threads in reply to each of the > patches. If these culminated in acceptance, please collect all of the > Acks you've received until this point and submit a [RESEND]. If there > are changes to be made still, please do the same but submit as a new > version. Ok i will send it again and include the ACK from Hans. There would be no code change. Please review the code already, if you find it acceptable we might receive a second ACK from Andy. Henning
On Mon, 15 May 2023, Henning Schild wrote: > Am Mon, 15 May 2023 10:50:42 +0100 > schrieb Lee Jones <lee@kernel.org>: > > > On Sat, 13 May 2023, Henning Schild wrote: > > > > > Ping. > > > > > > As far as i remember this one should be ready to merge. > > > > > > ACKed by Hans, and Andy had no objections given the maintainers > > > would accept the patches. > > > > > > So i think it is the maintainers turn now, Pavel and/or Lee i > > > guess. > > > > Looks like there are lots of mail threads in reply to each of the > > patches. If these culminated in acceptance, please collect all of the > > Acks you've received until this point and submit a [RESEND]. If there > > are changes to be made still, please do the same but submit as a new > > version. > > Ok i will send it again and include the ACK from Hans. There would be no > code change. Please review the code already, if you find it acceptable > we might receive a second ACK from Andy. Not sure what you mean by 'already'. I shall not be reviewing this set until it is resent, thanks.
Am Mon, 15 May 2023 13:12:47 +0100 schrieb Lee Jones <lee@kernel.org>: > On Mon, 15 May 2023, Henning Schild wrote: > > > Am Mon, 15 May 2023 10:50:42 +0100 > > schrieb Lee Jones <lee@kernel.org>: > > > > > On Sat, 13 May 2023, Henning Schild wrote: > > > > > > > Ping. > > > > > > > > As far as i remember this one should be ready to merge. > > > > > > > > ACKed by Hans, and Andy had no objections given the maintainers > > > > would accept the patches. > > > > > > > > So i think it is the maintainers turn now, Pavel and/or Lee i > > > > guess. > > > > > > Looks like there are lots of mail threads in reply to each of the > > > patches. If these culminated in acceptance, please collect all > > > of the Acks you've received until this point and submit a > > > [RESEND]. If there are changes to be made still, please do the > > > same but submit as a new version. > > > > Ok i will send it again and include the ACK from Hans. There would > > be no code change. Please review the code already, if you find it > > acceptable we might receive a second ACK from Andy. > > Not sure what you mean by 'already'. > > I shall not be reviewing this set until it is resent, thanks. I just sent that v3 you requested. It has one Ack from Hans in p3. And some minor style things from Andy, which i decided to take in when having to rebase and test once more. Looking forward to your feedback on that v3. regards, Henning
On Mon, 15 May 2023, Henning Schild wrote: > Am Mon, 15 May 2023 13:12:47 +0100 > schrieb Lee Jones <lee@kernel.org>: > > > On Mon, 15 May 2023, Henning Schild wrote: > > > > > Am Mon, 15 May 2023 10:50:42 +0100 > > > schrieb Lee Jones <lee@kernel.org>: > > > > > > > On Sat, 13 May 2023, Henning Schild wrote: > > > > > > > > > Ping. > > > > > > > > > > As far as i remember this one should be ready to merge. > > > > > > > > > > ACKed by Hans, and Andy had no objections given the maintainers > > > > > would accept the patches. > > > > > > > > > > So i think it is the maintainers turn now, Pavel and/or Lee i > > > > > guess. > > > > > > > > Looks like there are lots of mail threads in reply to each of the > > > > patches. If these culminated in acceptance, please collect all > > > > of the Acks you've received until this point and submit a > > > > [RESEND]. If there are changes to be made still, please do the > > > > same but submit as a new version. > > > > > > Ok i will send it again and include the ACK from Hans. There would > > > be no code change. Please review the code already, if you find it > > > acceptable we might receive a second ACK from Andy. > > > > Not sure what you mean by 'already'. > > > > I shall not be reviewing this set until it is resent, thanks. > > I just sent that v3 you requested. It has one Ack from Hans in p3. And > some minor style things from Andy, which i decided to take in when > having to rebase and test once more. > > Looking forward to your feedback on that v3. Thanks. It's marked for review. Just to set expectation, you are number 49 in the queue.
changes since v1: - move from header- to -core.c-based implementation - style changes from review This series mainly splits the one GPIO driver into two. The split allows to clearly model runtime and compile time dependencies on the GPIO chip drivers. p1 is kind of not too related to that split but also prepares for more GPIO based drivers to come. p2 takes the driver we had and puts some of its content into a -core, to be used by the two drivers. p3 deals with more fine-grained configuration posibilities and compile time dependencies. It is based on [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver Henning Schild (3): leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table leds: simatic-ipc-leds-gpio: split up into multiple drivers leds: simatic-ipc-leds-gpio: introduce more Kconfig switches drivers/leds/simple/Kconfig | 31 +++- drivers/leds/simple/Makefile | 5 +- .../simple/simatic-ipc-leds-gpio-apollolake.c | 64 ++++++++ .../leds/simple/simatic-ipc-leds-gpio-core.c | 103 +++++++++++++ .../simple/simatic-ipc-leds-gpio-f7188x.c | 64 ++++++++ drivers/leds/simple/simatic-ipc-leds-gpio.c | 139 ------------------ drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++ drivers/platform/x86/simatic-ipc.c | 7 +- 8 files changed, 288 insertions(+), 147 deletions(-) create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h