| Message ID | 20230612073902.840435-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform: Switch back to use struct i2c_driver's .probe() | expand |
On 6/12/23 09:38, Uwe Kleine-König wrote: > Hello, > > these three patches convert three i2c drivers back to use .probe() after > its prototype was changed. > > I was unsure if I should put the surface change together with the two > other x86 changes but as surfaces are x86, too, I thought this might be > right. If not: The patches are orthogonal to each other, so they can be > applied to different trees without interdependencies. While Hans is the authority on that, I believe that's fine. Both go through Hans' pdx86 tree. Regards, Max
Hi, On 6/12/23 12:51, Maximilian Luz wrote: > On 6/12/23 09:38, Uwe Kleine-König wrote: >> Hello, >> >> these three patches convert three i2c drivers back to use .probe() after >> its prototype was changed. >> >> I was unsure if I should put the surface change together with the two >> other x86 changes but as surfaces are x86, too, I thought this might be >> right. If not: The patches are orthogonal to each other, so they can be >> applied to different trees without interdependencies. > > While Hans is the authority on that, I believe that's fine. Both go > through Hans' pdx86 tree. Yes, all 3 look good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> and I'll merge this into my pdx86/review-hans branch soon (and after that they'll go to -next once the builders have had a chance to run their test builds on my review-hans branch). Regards, Hans
Hi, On 6/12/23 09:38, Uwe Kleine-König wrote: > Hello, > > these three patches convert three i2c drivers back to use .probe() after > its prototype was changed. > > I was unsure if I should put the surface change together with the two > other x86 changes but as surfaces are x86, too, I thought this might be > right. If not: The patches are orthogonal to each other, so they can be > applied to different trees without interdependencies. > > Best regards > Uwe Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > Uwe Kleine-König (3): > surface: surface3_power: Switch back to use struct i2c_driver's > .probe() > platform/x86: asus-tf103c-dock: Switch back to use struct i2c_driver's > .probe() > platform/x86: int3472: Switch back to use struct i2c_driver's .probe() > > drivers/platform/surface/surface3_power.c | 2 +- > drivers/platform/x86/asus-tf103c-dock.c | 2 +- > drivers/platform/x86/intel/int3472/tps68470.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > base-commit: ac9a78681b921877518763ba0e89202254349d1b
Hello, these three patches convert three i2c drivers back to use .probe() after its prototype was changed. I was unsure if I should put the surface change together with the two other x86 changes but as surfaces are x86, too, I thought this might be right. If not: The patches are orthogonal to each other, so they can be applied to different trees without interdependencies. Best regards Uwe Uwe Kleine-König (3): surface: surface3_power: Switch back to use struct i2c_driver's .probe() platform/x86: asus-tf103c-dock: Switch back to use struct i2c_driver's .probe() platform/x86: int3472: Switch back to use struct i2c_driver's .probe() drivers/platform/surface/surface3_power.c | 2 +- drivers/platform/x86/asus-tf103c-dock.c | 2 +- drivers/platform/x86/intel/int3472/tps68470.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) base-commit: ac9a78681b921877518763ba0e89202254349d1b