mbox series

[v3,0/3] TPMI control and debugfs support

Message ID 20230712225950.171326-1-srinivas.pandruvada@linux.intel.com (mailing list archive)
Headers show
Series TPMI control and debugfs support | expand

Message

srinivas pandruvada July 12, 2023, 10:59 p.m. UTC 
The first patch provides interface to read feature status. This is
generic patch to be used by other feature drivers.

The second patch add support for debugfs. Debugfs also display
feature status using the first patch

Srinivas Pandruvada (3):
  platform/x86/intel/tpmi: Read feature control status
  platform/x86/intel/tpmi: Add debugfs interface
  doc: TPMI: Add debugfs documentation

 Documentation/ABI/testing/debugfs-tpmi |  31 ++
 MAINTAINERS                            |   1 +
 drivers/platform/x86/intel/tpmi.c      | 399 ++++++++++++++++++++++++-
 include/linux/intel_tpmi.h             |   2 +
 4 files changed, 426 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/ABI/testing/debugfs-tpmi

Comments

Andy Shevchenko July 13, 2023, 4:48 p.m. UTC | #1 
On Wed, Jul 12, 2023 at 03:59:47PM -0700, Srinivas Pandruvada wrote:
> The first patch provides interface to read feature status. This is
> generic patch to be used by other feature drivers.
> 
> The second patch add support for debugfs. Debugfs also display
> feature status using the first patch

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

A couple of nit-picks in the individual comments.

> Srinivas Pandruvada (3):
>   platform/x86/intel/tpmi: Read feature control status
>   platform/x86/intel/tpmi: Add debugfs interface
>   doc: TPMI: Add debugfs documentation
> 
>  Documentation/ABI/testing/debugfs-tpmi |  31 ++
>  MAINTAINERS                            |   1 +
>  drivers/platform/x86/intel/tpmi.c      | 399 ++++++++++++++++++++++++-
>  include/linux/intel_tpmi.h             |   2 +
>  4 files changed, 426 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/ABI/testing/debugfs-tpmi
> 
> -- 
> 2.40.1
>
Hans de Goede July 14, 2023, 1:27 p.m. UTC | #2 
Hi,

On 7/13/23 00:59, Srinivas Pandruvada wrote:
> The first patch provides interface to read feature status. This is
> generic patch to be used by other feature drivers.
> 
> The second patch add support for debugfs. Debugfs also display
> feature status using the first patch
> 
> Srinivas Pandruvada (3):
>   platform/x86/intel/tpmi: Read feature control status
>   platform/x86/intel/tpmi: Add debugfs interface
>   doc: TPMI: Add debugfs documentation
> 
>  Documentation/ABI/testing/debugfs-tpmi |  31 ++
>  MAINTAINERS                            |   1 +
>  drivers/platform/x86/intel/tpmi.c      | 399 ++++++++++++++++++++++++-
>  include/linux/intel_tpmi.h             |   2 +
>  4 files changed, 426 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/ABI/testing/debugfs-tpmi

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

With Andy's Reviewed-by added.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans