mbox series

[v2,0/6] platform/x86/amd/pmc: Updates to amd-pmc driver

Message ID 20231228102104.1785383-1-Shyam-sundar.S-k@amd.com (mailing list archive)
Headers show
Series platform/x86/amd/pmc: Updates to amd-pmc driver | expand

Message

Shyam Sundar S K Dec. 28, 2023, 10:20 a.m. UTC
This series is focused on adding support for AMD family 1Ah series (or 
with platforms that support AMDI000A) that adds support for s2idle, VPE
IP block information, STB and idlemask.

(Series based on 'review-hans' branch with "4fd8b09f5bc1" as the tip.)

v1->v2:
-------
- Add missing smu_msg variable to amd_pmc_dev struct

Shyam Sundar S K (6):
  platform/x86/amd/pmc: Send OS_HINT command for AMDI000A platform
  platform/x86/amd/pmc: Add VPE information for AMDI000A platform
  platform/x86/amd/pmc: call amd_pmc_get_ip_info() during driver probe
  platform/x86/amd/pmc: Add idlemask support for 1Ah family
  platform/x86/amd/pmc: Add 1Ah family series to STB support list
  platform/x86/amd/pmc: Modify SMU message port for latest AMD platform

 drivers/platform/x86/amd/pmc/pmc.c | 25 +++++++++++++++++++------
 drivers/platform/x86/amd/pmc/pmc.h |  1 +
 2 files changed, 20 insertions(+), 6 deletions(-)

Comments

Ilpo Järvinen Dec. 29, 2023, 1:47 p.m. UTC | #1
On Thu, 28 Dec 2023, Shyam Sundar S K wrote:

> This series is focused on adding support for AMD family 1Ah series (or 
> with platforms that support AMDI000A) that adds support for s2idle, VPE
> IP block information, STB and idlemask.
> 
> (Series based on 'review-hans' branch with "4fd8b09f5bc1" as the tip.)
> 
> v1->v2:
> -------
> - Add missing smu_msg variable to amd_pmc_dev struct
> 
> Shyam Sundar S K (6):
>   platform/x86/amd/pmc: Send OS_HINT command for AMDI000A platform
>   platform/x86/amd/pmc: Add VPE information for AMDI000A platform
>   platform/x86/amd/pmc: call amd_pmc_get_ip_info() during driver probe
>   platform/x86/amd/pmc: Add idlemask support for 1Ah family
>   platform/x86/amd/pmc: Add 1Ah family series to STB support list
>   platform/x86/amd/pmc: Modify SMU message port for latest AMD platform
> 
>  drivers/platform/x86/amd/pmc/pmc.c | 25 +++++++++++++++++++------
>  drivers/platform/x86/amd/pmc/pmc.h |  1 +
>  2 files changed, 20 insertions(+), 6 deletions(-)

For all patches in this series:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Hans de Goede Jan. 2, 2024, 12:42 p.m. UTC | #2
Hi,

On 12/29/23 14:47, Ilpo Järvinen wrote:
> On Thu, 28 Dec 2023, Shyam Sundar S K wrote:
> 
>> This series is focused on adding support for AMD family 1Ah series (or 
>> with platforms that support AMDI000A) that adds support for s2idle, VPE
>> IP block information, STB and idlemask.
>>
>> (Series based on 'review-hans' branch with "4fd8b09f5bc1" as the tip.)
>>
>> v1->v2:
>> -------
>> - Add missing smu_msg variable to amd_pmc_dev struct
>>
>> Shyam Sundar S K (6):
>>   platform/x86/amd/pmc: Send OS_HINT command for AMDI000A platform
>>   platform/x86/amd/pmc: Add VPE information for AMDI000A platform
>>   platform/x86/amd/pmc: call amd_pmc_get_ip_info() during driver probe
>>   platform/x86/amd/pmc: Add idlemask support for 1Ah family
>>   platform/x86/amd/pmc: Add 1Ah family series to STB support list
>>   platform/x86/amd/pmc: Modify SMU message port for latest AMD platform
>>
>>  drivers/platform/x86/amd/pmc/pmc.c | 25 +++++++++++++++++++------
>>  drivers/platform/x86/amd/pmc/pmc.h |  1 +
>>  2 files changed, 20 insertions(+), 6 deletions(-)
> 
> For all patches in this series:
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Shyam, thank you for the patches. Ilpo, thank you for the review.

I've applied the series to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans