| Message ID | 20240216160526.235594-1-hpa@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KTD2026 indicator LED for X86 Xiaomi Pad2 | expand |
On Sat, 17 Feb 2024, Kate Hsuan wrote: > The v2 patch includes: > 1. Typo and style fixes. > 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since > KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the > sleep can be removed when removing the module. > > Kate Hsuan (3): > platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 > indicator LED > leds: rgb: leds-ktd202x: Get device properties through fwnode to > support ACPI > leds: rgb: leds-ktd202x: Skip requlator settings for Xiaomi pad2 So what's the expectation here? I take the first patch and the two other go through the LED subsys?
Hi llpo, On Mon, Feb 19, 2024 at 9:57 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > On Sat, 17 Feb 2024, Kate Hsuan wrote: > > > The v2 patch includes: > > 1. Typo and style fixes. > > 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since > > KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the > > sleep can be removed when removing the module. > > > > Kate Hsuan (3): > > platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 > > indicator LED > > leds: rgb: leds-ktd202x: Get device properties through fwnode to > > support ACPI > > leds: rgb: leds-ktd202x: Skip requlator settings for Xiaomi pad2 > > So what's the expectation here? Thank you for reviewing it. Sorry for the confusion. This patch enabled the KTD2026 LED controller on a Xiaomi Pad2. The controller controls an indicator LED which indicates the status of the charging or other events. Since it is an x86-based Android tablet, we need to set the device information through swnode and revise the driver to use fwnode APIs. > I take the first patch and the two other > go through the LED subsys? Yes. the first patch is for platform-driver-x86 and the second is for the LED subsystem. If someone would like to test it, they could easily get the necessary part of this work. > > -- > i. >
The v2 patch includes: 1. Typo and style fixes. 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the sleep can be removed when removing the module. Kate Hsuan (3): platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI leds: rgb: leds-ktd202x: Skip requlator settings for Xiaomi pad2 drivers/leds/rgb/Kconfig | 1 - drivers/leds/rgb/leds-ktd202x.c | 73 +++++++++++----- .../platform/x86/x86-android-tablets/other.c | 85 +++++++++++++++++++ .../x86/x86-android-tablets/shared-psy-info.h | 2 + 4 files changed, 141 insertions(+), 20 deletions(-)