mbox series

[0/3] power: supply: power-supply-leds: Add activate() callback to triggers

Message ID 20240510194012.138192-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series power: supply: power-supply-leds: Add activate() callback to triggers | expand

Message

Hans de Goede May 10, 2024, 7:40 p.m. UTC
Hi All,

This series adds an activate callback to the power-supply LED triggers to
ensure that power-supply LEDs get the correct initial value when the LED
gets registered after the power_supply has been registered.

Patches 1-2 do some refactoring / prep work and patch 3 adds the actual
activate callback.

This series applies on top of "[PATCH v9 6/7] power: supply: power-supply-leds:
Add charging_orange_full_green trigger for RGB LED":
https://lore.kernel.org/all/20240504164105.114017-7-hdegoede@redhat.com/

Regards,

Hans


Hans de Goede (3):
  power: supply: power-supply-leds: Add
    power_supply_[un]register_led_trigger()
  power: supply: power-supply-leds: Share trig pointer for online and
    charging_full
  power: supply: power-supply-leds: Add activate() callback to triggers

 drivers/power/supply/power_supply_leds.c | 176 +++++++++++++----------
 include/linux/power_supply.h             |   9 +-
 2 files changed, 101 insertions(+), 84 deletions(-)

Comments

Sebastian Reichel May 27, 2024, 9:37 p.m. UTC | #1
Hi,

On Fri, May 10, 2024 at 09:40:09PM +0200, Hans de Goede wrote:
> This series adds an activate callback to the power-supply LED triggers to
> ensure that power-supply LEDs get the correct initial value when the LED
> gets registered after the power_supply has been registered.
> 
> Patches 1-2 do some refactoring / prep work and patch 3 adds the actual
> activate callback.
> 
> This series applies on top of "[PATCH v9 6/7] power: supply: power-supply-leds:
> Add charging_orange_full_green trigger for RGB LED":
> https://lore.kernel.org/all/20240504164105.114017-7-hdegoede@redhat.com/

Apart from Andy's comments LGTM.

-- Sebastian