mbox series

[v3,0/3] x86/fpu: Allow the In-Field Scan driver to initialize FPU state

Message ID 20240530192739.172566-1-chang.seok.bae@intel.com (mailing list archive)
Headers show
Series x86/fpu: Allow the In-Field Scan driver to initialize FPU state | expand

Message

Chang S. Bae May 30, 2024, 7:27 p.m. UTC
This revision switches to a new approach by providing a helper to
initialize user FPU states for the driver, which is considerably simpler.
This approach could serve as an example for addressing similar situations
from a non-critical path.

I thought fpu_reset_fpregs() as the helper name. There is already one
with this name. Then, I realized the existing one is a bit misaligned, so
renamed it first here.

Thanks to Dave for the reviews and the suggestion.

Thanks,
Chang

The previous postings:
V2: https://lore.kernel.org/all/20240507235344.249103-1-chang.seok.bae@intel.com
V1: https://lore.kernel.org/all/20240430212508.105117-1-chang.seok.bae@intel.com

Chang S. Bae (3):
  x86/fpu: Rename fpu_reset_fpregs() to fpu_reset_fpstate_regs()
  x86/fpu: Allow FPU users to initialize FPU state
  platform/x86/intel/ifs: Initialize FPU states for the scan test

 arch/x86/include/asm/fpu/api.h           |  2 ++
 arch/x86/kernel/fpu/core.c               | 17 ++++++++++++++---
 drivers/platform/x86/intel/ifs/ifs.h     |  1 +
 drivers/platform/x86/intel/ifs/runtest.c |  7 +++++++
 4 files changed, 24 insertions(+), 3 deletions(-)


base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

Comments

Ilpo Järvinen June 3, 2024, 10:11 a.m. UTC | #1
On Thu, 30 May 2024, Chang S. Bae wrote:

> This revision switches to a new approach by providing a helper to
> initialize user FPU states for the driver, which is considerably simpler.
> This approach could serve as an example for addressing similar situations
> from a non-critical path.
> 
> I thought fpu_reset_fpregs() as the helper name. There is already one
> with this name. Then, I realized the existing one is a bit misaligned, so
> renamed it first here.
> 
> Thanks to Dave for the reviews and the suggestion.
> 
> Thanks,
> Chang
> 
> The previous postings:
> V2: https://lore.kernel.org/all/20240507235344.249103-1-chang.seok.bae@intel.com
> V1: https://lore.kernel.org/all/20240430212508.105117-1-chang.seok.bae@intel.com
> 
> Chang S. Bae (3):
>   x86/fpu: Rename fpu_reset_fpregs() to fpu_reset_fpstate_regs()
>   x86/fpu: Allow FPU users to initialize FPU state
>   platform/x86/intel/ifs: Initialize FPU states for the scan test
> 
>  arch/x86/include/asm/fpu/api.h           |  2 ++
>  arch/x86/kernel/fpu/core.c               | 17 ++++++++++++++---
>  drivers/platform/x86/intel/ifs/ifs.h     |  1 +
>  drivers/platform/x86/intel/ifs/runtest.c |  7 +++++++
>  4 files changed, 24 insertions(+), 3 deletions(-)

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Do x86 maintainers plan to take these through their tree?
Dave Hansen June 3, 2024, 12:10 p.m. UTC | #2
On 6/3/24 03:11, Ilpo Järvinen wrote:
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> Do x86 maintainers plan to take these through their tree?

Yes, once we've gone over them very carefully.