| Message ID | 20240531134702.166145-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | power: supply: power-supply-leds: Add activate() callback to triggers | expand |
On Fri, May 31, 2024 at 4:47 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > This series adds an activate callback to the power-supply LED triggers to > ensure that power-supply LEDs get the correct initial value when the LED > gets registered after the power_supply has been registered. > > Note that in 6.10-rc1 commit 822c91e72eac ("leds: trigger: Store brightness > set by led_trigger_event()") already solves this for the case were > the trigger only changes only the brightness. Since the power-supply > triggers can also set blinking and colors of mc LEDs that is not enough. > > Patches 1-2 do some refactoring / prep work and patch 3 adds the actual > activate callback. > > This series applies on top of 6.10-rc1 + "[PATCH v10 0/6] KTD2026 indicator > LED for X86 Xiaomi Pad2" that series should show up in > https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/ > > soon, since this is also LED related I guess this could be merged > through the LED tree too. Or Lee could provide an IB branch for > Sebastian to merge that branch + this series through the psy tree. > Sebastian, what has your preference ? FWIW, LGTM, Reviewed-by: Andy Shevchenko <andy@kernel.org>
On Fri, 31 May 2024 15:46:59 +0200, Hans de Goede wrote: > This series adds an activate callback to the power-supply LED triggers to > ensure that power-supply LEDs get the correct initial value when the LED > gets registered after the power_supply has been registered. > > Note that in 6.10-rc1 commit 822c91e72eac ("leds: trigger: Store brightness > set by led_trigger_event()") already solves this for the case were > the trigger only changes only the brightness. Since the power-supply > triggers can also set blinking and colors of mc LEDs that is not enough. > > [...] Applied, thanks! [1/3] power: supply: power-supply-leds: Add power_supply_[un]register_led_trigger() commit: 964a504b1261b641797d93cdbf79b68ff7d85720 [2/3] power: supply: power-supply-leds: Share trig pointer for online and charging_full commit: 6c951a84dab9c0e051aec54d7497f25e910a4953 [3/3] power: supply: power-supply-leds: Add activate() callback to triggers commit: 8179b068d5cb182a2c61f2f8365837a37f140feb Best regards,
Hi All, This series adds an activate callback to the power-supply LED triggers to ensure that power-supply LEDs get the correct initial value when the LED gets registered after the power_supply has been registered. Note that in 6.10-rc1 commit 822c91e72eac ("leds: trigger: Store brightness set by led_trigger_event()") already solves this for the case were the trigger only changes only the brightness. Since the power-supply triggers can also set blinking and colors of mc LEDs that is not enough. Patches 1-2 do some refactoring / prep work and patch 3 adds the actual activate callback. This series applies on top of 6.10-rc1 + "[PATCH v10 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2" that series should show up in https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/ soon, since this is also LED related I guess this could be merged through the LED tree too. Or Lee could provide an IB branch for Sebastian to merge that branch + this series through the psy tree. Sebastian, what has your preference ? Regards, Hans Hans de Goede (3): power: supply: power-supply-leds: Add power_supply_[un]register_led_trigger() power: supply: power-supply-leds: Share trig pointer for online and charging_full power: supply: power-supply-leds: Add activate() callback to triggers drivers/power/supply/power_supply_leds.c | 178 +++++++++++++---------- include/linux/power_supply.h | 9 +- 2 files changed, 103 insertions(+), 84 deletions(-)