| Message ID | 20240606233540.9774-1-W_Armin@gmx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/x86: lg-laptop: Support 2024 models | expand |
On Fri, 7 Jun 2024, Armin Wolf wrote: > A user complained that the lg-laptop driver does not work on 2024 > models like the LG Gram 16Z90S-G.AD7BF. The underlying reason turned > out to be that the ACPI methods used by this driver where not mapped > under \XINI, but instead under \_SB.XINI. Those ACPI methods are > associated with the LGEX0820 ACPI device, which was not used by this > driver until now. > > The first three patches move the airplane mode hotkey handling out > of lg-laptop and into the wireless-hotkey driver. This necessary > because the airplane mode hotkey is handled by a different ACPI > device (LGEX0815). > > The last patch finally fixes the underlying issue and uses the > LGEX0820 ACPI device to find theWMAB/WMBB ACPI methods. > > The modified drivers where tested by the user which created the > bug report and appear to work without issues. > > Armin Wolf (4): > platform/x86: wireless-hotkey: Add support for LG Airplane Button > platform/x86: lg-laptop: Remove LGEX0815 hotkey handling > platform/x86: lg-laptop: Change ACPI device id > platform/x86: lg-laptop: Use ACPI device handle when evaluating > WMAB/WMBB Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Am 07.06.24 um 01:35 schrieb Armin Wolf: > A user complained that the lg-laptop driver does not work on 2024 > models like the LG Gram 16Z90S-G.AD7BF. The underlying reason turned > out to be that the ACPI methods used by this driver where not mapped > under \XINI, but instead under \_SB.XINI. Those ACPI methods are > associated with the LGEX0820 ACPI device, which was not used by this > driver until now. > > The first three patches move the airplane mode hotkey handling out > of lg-laptop and into the wireless-hotkey driver. This necessary > because the airplane mode hotkey is handled by a different ACPI > device (LGEX0815). > > The last patch finally fixes the underlying issue and uses the > LGEX0820 ACPI device to find theWMAB/WMBB ACPI methods. > > The modified drivers where tested by the user which created the > bug report and appear to work without issues. Hi, any thought from the maintainer of the driver perhaps? Thanks, Armin Wolf > Armin Wolf (4): > platform/x86: wireless-hotkey: Add support for LG Airplane Button > platform/x86: lg-laptop: Remove LGEX0815 hotkey handling > platform/x86: lg-laptop: Change ACPI device id > platform/x86: lg-laptop: Use ACPI device handle when evaluating > WMAB/WMBB > > drivers/platform/x86/lg-laptop.c | 89 ++++++++++---------------- > drivers/platform/x86/wireless-hotkey.c | 2 + > 2 files changed, 36 insertions(+), 55 deletions(-) > > -- > 2.39.2 > >
Hi, On 6/7/24 1:35 AM, Armin Wolf wrote: > A user complained that the lg-laptop driver does not work on 2024 > models like the LG Gram 16Z90S-G.AD7BF. The underlying reason turned > out to be that the ACPI methods used by this driver where not mapped > under \XINI, but instead under \_SB.XINI. Those ACPI methods are > associated with the LGEX0820 ACPI device, which was not used by this > driver until now. > > The first three patches move the airplane mode hotkey handling out > of lg-laptop and into the wireless-hotkey driver. This necessary > because the airplane mode hotkey is handled by a different ACPI > device (LGEX0815). > > The last patch finally fixes the underlying issue and uses the > LGEX0820 ACPI device to find theWMAB/WMBB ACPI methods. > > The modified drivers where tested by the user which created the > bug report and appear to work without issues. > > Armin Wolf (4): > platform/x86: wireless-hotkey: Add support for LG Airplane Button > platform/x86: lg-laptop: Remove LGEX0815 hotkey handling > platform/x86: lg-laptop: Change ACPI device id > platform/x86: lg-laptop: Use ACPI device handle when evaluating > WMAB/WMBB Thank you for your patch-series, I've applied this series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans
A user complained that the lg-laptop driver does not work on 2024 models like the LG Gram 16Z90S-G.AD7BF. The underlying reason turned out to be that the ACPI methods used by this driver where not mapped under \XINI, but instead under \_SB.XINI. Those ACPI methods are associated with the LGEX0820 ACPI device, which was not used by this driver until now. The first three patches move the airplane mode hotkey handling out of lg-laptop and into the wireless-hotkey driver. This necessary because the airplane mode hotkey is handled by a different ACPI device (LGEX0815). The last patch finally fixes the underlying issue and uses the LGEX0820 ACPI device to find theWMAB/WMBB ACPI methods. The modified drivers where tested by the user which created the bug report and appear to work without issues. Armin Wolf (4): platform/x86: wireless-hotkey: Add support for LG Airplane Button platform/x86: lg-laptop: Remove LGEX0815 hotkey handling platform/x86: lg-laptop: Change ACPI device id platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB drivers/platform/x86/lg-laptop.c | 89 ++++++++++---------------- drivers/platform/x86/wireless-hotkey.c | 2 + 2 files changed, 36 insertions(+), 55 deletions(-) -- 2.39.2