mbox series

[0/7] platform/x86/inte-uncore-freq: Cleanups

Message ID 20240617060708.892981-1-tero.kristo@linux.intel.com (mailing list archive)
Headers show
Series platform/x86/inte-uncore-freq: Cleanups | expand

Message

Tero Kristo June 17, 2024, 6:04 a.m. UTC
Hi,

This series introduces some cleanups for the code and driver level APIs.
The purpose is to improve the maintainability of the code and make it
easier to add new features in future.

No functional changes expected from any of the patches in this series.

-Tero

Comments

srinivas pandruvada June 17, 2024, 9:06 a.m. UTC | #1
On Mon, 2024-06-17 at 09:04 +0300, Tero Kristo wrote:
> Hi,
> 
> This series introduces some cleanups for the code and driver level
> APIs.
> The purpose is to improve the maintainability of the code and make it
> easier to add new features in future.
> 
> No functional changes expected from any of the patches in this
> series.

    Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Thanks,
Srinivas

> 

> -Tero
>
Ilpo Järvinen June 18, 2024, 10 a.m. UTC | #2
On Mon, 17 Jun 2024, Tero Kristo wrote:

> Hi,
> 
> This series introduces some cleanups for the code and driver level APIs.
> The purpose is to improve the maintainability of the code and make it
> easier to add new features in future.
> 
> No functional changes expected from any of the patches in this series.

Nice cleanups, thank you.

I've applied these into review-ilpo branch with the following 
modifications:

- I fixed my name on Reviewed-by line. Please don't corrupt my name if
  handwriting a tag instead of copying it. While I don't care that much
  if my name is not always written 100% correctly, an incorrect rev-by 
  line causes my tools to add the correct form one so the rev-by line 
  gets duplicated (luckily I was paying attention to the non-critical 
  part of the output of my tool this time around so I caught it).

- I renamed _min, _max, and _value variables to min, max, and v, 
  respectively, because the reason for using underscores got removed by
  the change.