[v2,0/4] platform/x86: int3472: A few cleanups

Message

Andy Shevchenko Aug. 22, 2024, 1:05 p.m. UTC

A few cleanups to the driver. It includes an amendment to
dev_err_probe() to ignore 0 error code. The patches 1 and 2 are
dependent, while patches 2 and 3 may be applied in any order.

Assumed to go via PDx86 tree if no objections to the code.

v2:
- amended code example in the documentation (Ilpo, Greg)
- added note about -ENOMEM and 0 to the kernel-doc
- fixed kernel-doc warning (no "Return" section)
- added tags (Ilpo)

Andy Shevchenko (4):
  driver core: Ignore 0 in dev_err_probe()
  platform/x86: int3472: Simplify dev_err_probe() usage
  platform/x86: int3472: Use GPIO_LOOKUP() macro
  platform/x86: int3472: Use str_high_low()

 drivers/base/core.c                           | 13 +++++++++++--
 drivers/platform/x86/intel/int3472/discrete.c | 14 ++++----------
 2 files changed, 15 insertions(+), 12 deletions(-)

Comments

Andy Shevchenko Sept. 2, 2024, 10:19 a.m. UTC | #1

On Thu, Aug 22, 2024 at 04:05:37PM +0300, Andy Shevchenko wrote:
> A few cleanups to the driver. It includes an amendment to
> dev_err_probe() to ignore 0 error code. The patches 1 and 2 are
> dependent, while patches 2 and 3 may be applied in any order.
> 
> Assumed to go via PDx86 tree if no objections to the code.

Ilpo, Hans, the patches 3 and 4 are independent from 1&2 and may be applied
separately, if you have no objections.

Hans de Goede Sept. 4, 2024, 1:05 p.m. UTC | #2

Hi,

On 9/2/24 12:19 PM, Andy Shevchenko wrote:
> On Thu, Aug 22, 2024 at 04:05:37PM +0300, Andy Shevchenko wrote:
>> A few cleanups to the driver. It includes an amendment to
>> dev_err_probe() to ignore 0 error code. The patches 1 and 2 are
>> dependent, while patches 2 and 3 may be applied in any order.
>>
>> Assumed to go via PDx86 tree if no objections to the code.
> 
> Ilpo, Hans, the patches 3 and 4 are independent from 1&2 and may be applied
> separately, if you have no objections.

I've applied patches 3 and 4 to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
now.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans