| Message ID | 20240926095344.1291013-1-luke@ljones.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | platfom/x86: asus-wmi: revert ROG Ally quirks | expand |
On 9/26/2024 04:53, Luke D. Jones wrote: > The ASUS ROG Ally (and Ally X) quirks that I added over the last year > are not required. I worked with ASUS to pinpoint the exact cause of > the original issue (MCU USB dev missing every second resume) and the > result is a new MCU firmware which will be released on approx 16/10/24. > > All users should update to MCU FW as soon as released to: > - Ally 1: v319 > - Ally X: v313 > > Luke D. Jones (3): > Revert "platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU > powersave" > Revert "platform/x86: asus-wmi: disable USB0 hub on ROG Ally before > suspend" > platfom/x86: asus-wmi: cleanup after Ally quirk reverts > > drivers/platform/x86/asus-wmi.c | 39 +-------------------------------- > 1 file changed, 1 insertion(+), 38 deletions(-) > This series looks good to me, but I would suggest that you also in the appropriate HID driver that communicates with the MCU to show a warning or notice if the version is below the required version. Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
On Fri, 27 Sep 2024, at 1:36 AM, Mario Limonciello wrote: > On 9/26/2024 04:53, Luke D. Jones wrote: >> The ASUS ROG Ally (and Ally X) quirks that I added over the last year >> are not required. I worked with ASUS to pinpoint the exact cause of >> the original issue (MCU USB dev missing every second resume) and the >> result is a new MCU firmware which will be released on approx 16/10/24. >> >> All users should update to MCU FW as soon as released to: >> - Ally 1: v319 >> - Ally X: v313 >> >> Luke D. Jones (3): >> Revert "platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU >> powersave" >> Revert "platform/x86: asus-wmi: disable USB0 hub on ROG Ally before >> suspend" >> platfom/x86: asus-wmi: cleanup after Ally quirk reverts >> >> drivers/platform/x86/asus-wmi.c | 39 +-------------------------------- >> 1 file changed, 1 insertion(+), 38 deletions(-) >> > > This series looks good to me, but I would suggest that you also in the > appropriate HID driver that communicates with the MCU to show a warning > or notice if the version is below the required version. > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> I have something that works, but it's in the hid-asus-ally driver. Since that might take a while to prepare I think I'll bring it over to this series soon.
The ASUS ROG Ally (and Ally X) quirks that I added over the last year are not required. I worked with ASUS to pinpoint the exact cause of the original issue (MCU USB dev missing every second resume) and the result is a new MCU firmware which will be released on approx 16/10/24. All users should update to MCU FW as soon as released to: - Ally 1: v319 - Ally X: v313 Luke D. Jones (3): Revert "platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU powersave" Revert "platform/x86: asus-wmi: disable USB0 hub on ROG Ally before suspend" platfom/x86: asus-wmi: cleanup after Ally quirk reverts drivers/platform/x86/asus-wmi.c | 39 +-------------------------------- 1 file changed, 1 insertion(+), 38 deletions(-)