[v2,0/2] Fix thermal profile handling

Message

Armin Wolf Nov. 7, 2024, 12:38 a.m. UTC

When support for Vivobook fan profiles was added, the new thermal
profiles where used inconsistently.

This patch series aims to fix this issue. Compile-tested only.

Changes since v1:
- drop already applied patch
- change commit description of first patch
- add second patch based on a suggestion of Hans

Armin Wolf (2):
  platform/x86: asus-wmi: Fix inconsistent use of thermal policies
  platform/x86: asus-wmi: Use platform_profile_cycle()

 drivers/platform/x86/asus-wmi.c | 88 +++++++++------------------------
 1 file changed, 22 insertions(+), 66 deletions(-)

--
2.39.5

Comments

Armin Wolf Nov. 11, 2024, 7 a.m. UTC | #1

Am 07.11.24 um 01:38 schrieb Armin Wolf:

> When support for Vivobook fan profiles was added, the new thermal
> profiles where used inconsistently.
>
> This patch series aims to fix this issue. Compile-tested only.

Whats your opinion on this, Ilpo? The first patch was already tested by Casey, and
the second patch should be low risk despite being only compile-tested by me.

Thanks,
Armin Wolf

> Changes since v1:
> - drop already applied patch
> - change commit description of first patch
> - add second patch based on a suggestion of Hans
>
> Armin Wolf (2):
>    platform/x86: asus-wmi: Fix inconsistent use of thermal policies
>    platform/x86: asus-wmi: Use platform_profile_cycle()
>
>   drivers/platform/x86/asus-wmi.c | 88 +++++++++------------------------
>   1 file changed, 22 insertions(+), 66 deletions(-)
>
> --
> 2.39.5
>
>

Ilpo Järvinen Nov. 12, 2024, 5:17 p.m. UTC | #2

On Thu, 07 Nov 2024 01:38:09 +0100, Armin Wolf wrote:

> When support for Vivobook fan profiles was added, the new thermal
> profiles where used inconsistently.
> 
> This patch series aims to fix this issue. Compile-tested only.
> 
> Changes since v1:
> - drop already applied patch
> - change commit description of first patch
> - add second patch based on a suggestion of Hans
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: asus-wmi: Fix inconsistent use of thermal policies
      commit: 895085ec3f2ed7a26389943729e2904df1f88dc0
[2/2] platform/x86: asus-wmi: Use platform_profile_cycle()
      commit: b0955ce555478e24ed34c7d14f62fdf9c07b15cb

--
 i.