mbox series

[0/5] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10

Message ID 20241109220530.83394-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 | expand

Message

Hans de Goede Nov. 9, 2024, 10:05 p.m. UTC
Hi All,

Here is a patch-series for adding Bluetooth support for the Vexia EDU ATLA
10 tablet to x86-android-tablets.

Due to the LPSS UARTs being enumerated through PCI rather then through
ACPI, this is somewhat involved. Just like how this special case needed
some extra work for instantiating the various i2c-clients.

Regards,

Hans


Hans de Goede (5):
  platform/x86: serdev_helpers: Add get_serdev_controller_from_parent()
    helper
  platform/x86: x86-android-tablets: Add missing __init to
    get_i2c_adap_by_*()
  platform/x86: x86-android-tablets: Change x86_instantiate_serdev()
    prototype
  platform/x86: x86-android-tablets: Add support for getting
    serdev-controller by PCI parent
  platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU
    ATLA 10

 drivers/platform/x86/serdev_helpers.h         | 60 +++++++++++--------
 .../platform/x86/x86-android-tablets/core.c   | 31 +++++++---
 .../platform/x86/x86-android-tablets/other.c  | 12 +++-
 .../x86-android-tablets/x86-android-tablets.h |  6 +-
 4 files changed, 74 insertions(+), 35 deletions(-)

Comments

Andy Shevchenko Nov. 10, 2024, 2:53 p.m. UTC | #1
On Sun, Nov 10, 2024 at 12:05 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> Here is a patch-series for adding Bluetooth support for the Vexia EDU ATLA
> 10 tablet to x86-android-tablets.
>
> Due to the LPSS UARTs being enumerated through PCI rather then through

rather than

> ACPI, this is somewhat involved. Just like how this special case needed
> some extra work for instantiating the various i2c-clients.

All seem reasonable to me
Reviewed-by: Andy Shevchenko <andy@kernel.org>

One patch got a few comments, and I still think it's better to move
the rather long functions to the C file at some point.