[v3,0/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10

Message

Hans de Goede Dec. 4, 2024, 8:42 p.m. UTC

Hi All,

Here is a patch-series for adding Bluetooth support for the Vexia EDU ATLA
10 tablet to x86-android-tablets.

Due to the LPSS UARTs being enumerated through PCI rather than through
ACPI, this is somewhat involved. Just like how this special case needed
some extra work for instantiating the various i2c-clients.

Changes in v3:
- Make the "platform/x86: x86-android-tablets: Add missing __init to
  get_i2c_adap_by_*()" bugfix the first patch in the series
- Add 2 more bugfixes as patches 2 - 3

Changes in v2:
- Use a union in struct x86_serdev_info which stores either ACPI HID + UID
  or the PCI devfn of the serdev-controller

Regards,

Hans


Hans de Goede (8):
  platform/x86: x86-android-tablets: Add missing __init to
    get_i2c_adap_by_*()
  platform/x86: x86-android-tablets: Make variables only used locally
    static
  platform/x86: serdev_helpers: Check for serial_ctrl_uid == NULL
  platform/x86: serdev_helpers: Add get_serdev_controller_from_parent()
    helper
  platform/x86: x86-android-tablets: Change x86_instantiate_serdev()
    prototype
  platform/x86: x86-android-tablets: Store serdev-controller ACPI HID +
    UID in a union
  platform/x86: x86-android-tablets: Add support for getting
    serdev-controller by PCI parent
  platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU
    ATLA 10

 drivers/platform/x86/serdev_helpers.h         | 60 +++++++++++--------
 .../platform/x86/x86-android-tablets/asus.c   |  4 +-
 .../platform/x86/x86-android-tablets/core.c   | 31 +++++++---
 .../platform/x86/x86-android-tablets/lenovo.c |  4 +-
 .../platform/x86/x86-android-tablets/other.c  | 16 ++++-
 .../x86-android-tablets/x86-android-tablets.h | 13 +++-
 6 files changed, 85 insertions(+), 43 deletions(-)

Comments

Ilpo Järvinen Dec. 10, 2024, 2:03 p.m. UTC | #1

On Wed, 04 Dec 2024 21:42:11 +0100, Hans de Goede wrote:

> Here is a patch-series for adding Bluetooth support for the Vexia EDU ATLA
> 10 tablet to x86-android-tablets.
> 
> Due to the LPSS UARTs being enumerated through PCI rather than through
> ACPI, this is somewhat involved. Just like how this special case needed
> some extra work for instantiating the various i2c-clients.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/8] platform/x86: x86-android-tablets: Add missing __init to get_i2c_adap_by_*()
      commit: 981fd70a5ac4347368fa8a3329b7d67f1c567ee7
[2/8] platform/x86: x86-android-tablets: Make variables only used locally static
      commit: f6728073baa172be6223512fffd72796de891536
[3/8] platform/x86: serdev_helpers: Check for serial_ctrl_uid == NULL
      commit: 478b00a623d6c8ae23a1be7bcc96cb5497045cef
[4/8] platform/x86: serdev_helpers: Add get_serdev_controller_from_parent() helper
      commit: a6593c5c50455852cd3b2b51e09bdec90b99738f
[5/8] platform/x86: x86-android-tablets: Change x86_instantiate_serdev() prototype
      commit: c1007dd139b6f8b2b00ba7bdce32a94c3da34dbe
[6/8] platform/x86: x86-android-tablets: Store serdev-controller ACPI HID + UID in a union
      commit: dd6db239cb30ef1ccc0084a530839c9897009a6f
[7/8] platform/x86: x86-android-tablets: Add support for getting serdev-controller by PCI parent
      commit: 7d28fb4d16fb8ad2309616ee3bdcdbf161c13dc5
[8/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10
      commit: c0f1bfc141ea52ea039bd17537b46b705ff8a93d

--
 i.