From patchwork Mon Dec 9 18:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 13900199 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BFCA167DAC for ; Mon, 9 Dec 2024 18:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733769373; cv=none; b=hJDinyHqkhVLNL6OVVFTTjRmeQn0vK71Bdhce4FnoHCTHZumIMoIg/p2nHhdOqok5qDJTouXamCvOJKZEKacMlxt4MFvOE+vsVxx3Cd6wJc9WG+zs3ulp1v6ej6u3p11Fivql33Sc7p+19whKs3gC5NUn/rdVlN6g2MBZQDK3E4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733769373; c=relaxed/simple; bh=ZEYplIOq10xjae08qI9+kU5Z7KB5L1PMHsqZr9IETM4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ebeLNz2oUcs1/yoRc7xbEmh0sxjywK/xGO5EmmAXNR6o2PyjTaywfphsv3N9OndVNWbFY7Nmg1fCPFsc9SRayi40/SxbxWlkdkHJkhNDntq8yQSaVCbp5w3qYa2Qyil0O1zUMOxaZruQw5shUnfHpwKz63orMbArmvYe+PuZrp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bIvPqe7b; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bIvPqe7b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733769370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AAMc5MpMujgl5pX3TiAF+Pgw3NS8Qs1CNeL7AS+qtnc=; b=bIvPqe7bzol2altiIVZPvwNBiAaesjpDR9+InwAWMEX6bfICeBWmoNMLMWwzbhMZXoK5kQ HMKaEx3YsS5nYUIGjTCpKgeWc0yjMr5VgVtOEB/g2XH0OSIIbnrPTCAz5VYYi/wFKAktSq ajJpmizWslyEt3qONtHrLOgoSqZZ5V8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-xa6HUsYWNMmvWtpvWyelAg-1; Mon, 09 Dec 2024 13:36:06 -0500 X-MC-Unique: xa6HUsYWNMmvWtpvWyelAg-1 X-Mimecast-MFC-AGG-ID: xa6HUsYWNMmvWtpvWyelAg Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F3C971954AFF; Mon, 9 Dec 2024 18:36:03 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.52]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3E6771956048; Mon, 9 Dec 2024 18:35:58 +0000 (UTC) From: Hans de Goede To: =?utf-8?q?Pali_Roh=C3=A1r?= , =?utf-8?q?Ilpo_J=C3=A4rvi?= =?utf-8?q?nen?= , Andy Shevchenko , Paul Menzel , Wolfram Sang Cc: Hans de Goede , eric.piel@tremplin-utc.net, Marius Hoch , Dell.Client.Kernel@dell.com, Kai Heng Feng , platform-driver-x86@vger.kernel.org, Jean Delvare , Andi Shyti , linux-i2c@vger.kernel.org Subject: [PATCH v9 0/4] i2c-i801 / dell-lis3lv02d: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d Date: Mon, 9 Dec 2024 19:35:53 +0100 Message-ID: <20241209183557.7560-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Hi All, Here is v9 of my patch series to move the manual instantation of lis3lv02d i2c_client-s for SMO88xx ACPI device from the generic i2c-i801.c code to a SMO88xx specific dell-lis3lv02d driver. The i2c-core and i2c-i801 dependencies have both been merged into 6.13-rc1 so I believe that this series is ready to be merged now . Patch 2/4 does still touch the i2c-i801 code removing the quirk code which is moved to the pdx86 dell-smo8800 code. I think it would be best if Ilpo prepares an immutable branch with this series to be merged into both pdx86/for-next and the i2c-subsystem. Andi can we get your Ack for merging the i2c-i801 changes through the pdx86 tree ? Moving the i2c_client instantiation has the following advantages: 1. This moves the SMO88xx ACPI device quirk handling away from the generic i2c-i801 module which is loaded on all Intel x86 machines to a module which will only be loaded when there is an ACPI SMO88xx device. 2. This removes the duplication of the SMO88xx ACPI Hardware ID (HID) table between the i2c-i801 and dell-smo8800 drivers. 3. This allows extending the quirk handling by adding new code and related module parameters to the dell-lis3lv02d driver, without needing to modify the i2c-i801 code. This series also extends the i2c_client instantiation with support for probing for the i2c-address of the lis3lv02d chip on devices which are not yet listed in the DMI table with i2c-addresses for known models. This probing is only done when requested through a module parameter. Changes in v9: - Rebase on top of v6.13-rc1 - Drop already merged i2c-core and i2c-i801 dependencies Changes in v8: - Address some minor review remarks from Andy Changes in v7: - Rebase on v6.11-rc1 Changes in v6: - Use i2c_new_scanned_device() instead of re-inventing it Changes in v5: - Make match_acpi_device_ids() and match_acpi_device_ids[] __init[const] - Add "Depends on I2C" to Kconfig (to fix kernel-test-robot reported issues) - Add "this may be dangerous warning" to MODULE_PARM_DESC(probe_i2c_addr) Changes in v4: - Move the i2c_client instantiation to a new dell-lis3lv02d driver instead of adding it to the dell-smo8800 driver - Address a couple of other minor review comments Changes in v3: - Use an i2c bus notifier so that the i2c_client will still be instantiated if the i801 i2c_adapter shows up later or is re-probed (removed + added again). This addresses the main concern / review-comments made during review of v2. - Add 2 prep patches to the i2c-core / the i2c-i801 driver to allow bus-notifier use / to avoid the need to duplicate the PCI-ids of IDF i2c-i801 adapters. - Switch to standard dmi_system_id matching to check both sys-vendor + product-name DMI fields - Drop the patch to alternatively use the st_accel IIO driver instead of drivers/misc/lis3lv02d/lis3lv02d.c Changes in v2: - Drop "[PATCH 1/6] platform/x86: dell-smo8800: Only load on Dell laptops" - Use a pci_device_id table to check for IDF (non main) i2c-i801 SMBusses - Add a comment documenting the IDF PCI device ids - Keep using drivers/misc/lis3lv02d/lis3lv02d.c by default - Rename the module-parameter to use_iio_driver which can be set to use the IIO st_accel driver instead - Add a new patch adding the accelerometer address for the 2 models I have tested this on to dell_lis3lv02d_devices[] Since this touches files under both drivers/i2c and drivers/platform/x86 some subsystem coordination is necessary. I think it would be best to just merge the entire series through the i2c subsystem since this touches some core i2c files. As pdx86 subsys co-maintainer I'm fine with doing so. Regards, Hans Hans de Goede (4): platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to dell-smo8800-ids.h platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d platform/x86: dell-smo8800: Add a couple more models to lis3lv02d_devices[] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address drivers/i2c/busses/i2c-i801.c | 124 --------- drivers/platform/x86/dell/Kconfig | 1 + drivers/platform/x86/dell/Makefile | 1 + drivers/platform/x86/dell/dell-lis3lv02d.c | 252 +++++++++++++++++++ drivers/platform/x86/dell/dell-smo8800-ids.h | 27 ++ drivers/platform/x86/dell/dell-smo8800.c | 16 +- 6 files changed, 282 insertions(+), 139 deletions(-) create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h