| Message ID | 20250104-firmware-attributes-simplify-v1-0-949f9709e405@weissschuh.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/x86: firmware_attributes_class: Simplify API | expand |
On 1/3/2025 17:05, Thomas Weißschuh wrote: > Looking at the users of firmware_attributes_class makes my head hurt. > Simplify the subsystem and its users. > > This will break the currently developed samsung-galaxybook driver, > resolving the breakage should be trivial. It will also break the lenovo legion wmi drivers that are in review right now too, but I agree it should be trivial to fix that too. > > Only compile-tested. > > I have some further improvements in the pipeline building on these > changes, but those will need some more time. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > Thomas Weißschuh (6): > platform/x86: firmware_attributes_class: Move include linux/device/class.h > platform/x86: firmware_attributes_class: Simplify API > platform/x86: think-lmi: Directly use firmware_attributes_class > platform/x86: hp-bioscfg: Directly use firmware_attributes_class > platform/x86: dell-sysman: Directly use firmware_attributes_class > platform/x86: firmware_attributes_class: Drop lifecycle functions > > drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 17 +++------ > drivers/platform/x86/firmware_attributes_class.c | 42 +++++----------------- > drivers/platform/x86/firmware_attributes_class.h | 5 +-- > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++------ > drivers/platform/x86/think-lmi.c | 13 ++----- > 5 files changed, 21 insertions(+), 70 deletions(-) > --- > base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf > change-id: 20250103-firmware-attributes-simplify-9ae561459260 > > Best regards,
Hi Thomas, On Fri, Jan 3, 2025, at 6:05 PM, Thomas Weißschuh wrote: > Looking at the users of firmware_attributes_class makes my head hurt. > Simplify the subsystem and its users. > > This will break the currently developed samsung-galaxybook driver, > resolving the breakage should be trivial. > > Only compile-tested. > > I have some further improvements in the pipeline building on these > changes, but those will need some more time. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > Thomas Weißschuh (6): > platform/x86: firmware_attributes_class: Move include linux/device/class.h > platform/x86: firmware_attributes_class: Simplify API > platform/x86: think-lmi: Directly use firmware_attributes_class > platform/x86: hp-bioscfg: Directly use firmware_attributes_class > platform/x86: dell-sysman: Directly use firmware_attributes_class > platform/x86: firmware_attributes_class: Drop lifecycle functions > > drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 17 +++------ > drivers/platform/x86/firmware_attributes_class.c | 42 +++++----------------- > drivers/platform/x86/firmware_attributes_class.h | 5 +-- > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++------ > drivers/platform/x86/think-lmi.c | 13 ++----- > 5 files changed, 21 insertions(+), 70 deletions(-) > --- > base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf > change-id: 20250103-firmware-attributes-simplify-9ae561459260 > > Best regards, > -- > Thomas Weißschuh <linux@weissschuh.net> For the series - looks good to me. Tested on X1 Carbon G12 and confirmed think-lmi is working as expected. Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca> Mark
On Sat, 04 Jan 2025 00:05:08 +0100, Thomas Weißschuh wrote: > Looking at the users of firmware_attributes_class makes my head hurt. > Simplify the subsystem and its users. > > This will break the currently developed samsung-galaxybook driver, > resolving the breakage should be trivial. > > Only compile-tested. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/6] platform/x86: firmware_attributes_class: Move include linux/device/class.h commit: 34a5894672f73ebce2a7efec2a8a7d785c76adab [2/6] platform/x86: firmware_attributes_class: Simplify API commit: ab12105347d50857aece92b65a3edbe93c0d3060 [3/6] platform/x86: think-lmi: Directly use firmware_attributes_class commit: 20d23c51a0d69c38f4f2b02ae969b9cb33cf1555 [4/6] platform/x86: hp-bioscfg: Directly use firmware_attributes_class commit: 2765aa5e28fdab6590e9b4633a2f7ad26f3b7392 [5/6] platform/x86: dell-sysman: Directly use firmware_attributes_class commit: e8866e8892753dcdad48d6aa9192d91dcd32d94c [6/6] platform/x86: firmware_attributes_class: Drop lifecycle functions commit: c200f9b6c2a461fbbdae3a04fee9a045ec215297 -- i.
Looking at the users of firmware_attributes_class makes my head hurt. Simplify the subsystem and its users. This will break the currently developed samsung-galaxybook driver, resolving the breakage should be trivial. Only compile-tested. I have some further improvements in the pipeline building on these changes, but those will need some more time. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- Thomas Weißschuh (6): platform/x86: firmware_attributes_class: Move include linux/device/class.h platform/x86: firmware_attributes_class: Simplify API platform/x86: think-lmi: Directly use firmware_attributes_class platform/x86: hp-bioscfg: Directly use firmware_attributes_class platform/x86: dell-sysman: Directly use firmware_attributes_class platform/x86: firmware_attributes_class: Drop lifecycle functions drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 17 +++------ drivers/platform/x86/firmware_attributes_class.c | 42 +++++----------------- drivers/platform/x86/firmware_attributes_class.h | 5 +-- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++------ drivers/platform/x86/think-lmi.c | 13 ++----- 5 files changed, 21 insertions(+), 70 deletions(-) --- base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf change-id: 20250103-firmware-attributes-simplify-9ae561459260 Best regards,