mbox series

[v3,00/20] platform/x86: alienware-wmi driver rework

Message ID 20250105153019.19206-2-kuurtb@gmail.com (mailing list archive)
Headers show
Series platform/x86: alienware-wmi driver rework | expand

Message

Kurt Borja Jan. 5, 2025, 3:30 p.m. UTC 
Hello :) 

I rebased this series on top of review-ilpo-next to pick up
alienware-wmi's latest commit.

~ Kurt
---
v2 -> v3:

[5/20]
 - Use traditional if statement in zone_attr_visible and return attr->mode

[7/20]
 - Remove quirks from priv

[8/20]
 - Call alienware_alienfx_exit if device_add_groups fails
 - Call device_remove_groups on .remove
 - Return ret on alienware_wmi_init()

[9/20]
 - Directly return create_thermal_profile in alienware_awcc_setup()
 - Assign priv on declaration in alienware_awcc_exit()

[10/20]
 - Fix alienware_wmi_command()

[13/20]
 - Rename x_series_features -> generic_quirks
 - Rename g_series_features -> g_series_quirks
 - Keep previous module parameter logic
 - Additionally rename *quirks -> *alienfx

[16/20]
 - Export *alienfx as an extern variable on alienware-wmi.h
 - Move pr_fmt to alienware-wmi.h

[17/20]
 - 2024 -> 2025

[20/20]
 - 2024 -> 2025

[*/20]
 - Add platform/x86 prefix to commit messages

v2: https://lore.kernel.org/platform-driver-x86/20241229194506.8268-2-kuurtb@gmail.com/

Kurt Borja (20):
  platform/x86: alienware-wmi: Remove unnecessary check at module exit
  platform/x86: alienware-wmi: Move Lighting Control State
  platform/x86: alienware-wmi: Modify parse_rgb() signature
  platform/x86: alienware-wmi: Improve hdmi_mux, amplifier and deepslp
    group creation
  platform/x86: alienware-wmi: Improve rgb-zones group creation
  platform/x86: alienware_wmi: General cleanup of WMAX methods
  platform/x86: alienware-wmi: Add a state container for LED control
    feature
  platform/x86: alienware-wmi: Add WMI Drivers
  platform/x86: alienware-wmi: Add a state container for thermal control
    methods
  platform/x86: alienware-wmi: Refactor LED control methods
  platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods
  platform/x86: alienware-wmi: Refactor thermal control methods
  platform/x86: alienware-wmi: Split DMI table
  MAINTAINERS: Update ALIENWARE WMI DRIVER entry
  platform/x86: Rename alienware-wmi.c
  platform/x86: Add alienware-wmi.h
  platform/x86: Split the alienware-wmi driver
  platform/x86: dell: Modify Makefile alignment
  platform/x86: Update alienware-wmi config entries
  platform/x86: alienware-wmi: Update header and module information

 MAINTAINERS                                   |    4 +-
 drivers/platform/x86/dell/Kconfig             |   30 +-
 drivers/platform/x86/dell/Makefile            |   45 +-
 .../platform/x86/dell/alienware-wmi-base.c    |  488 +++++++
 .../platform/x86/dell/alienware-wmi-legacy.c  |   98 ++
 .../platform/x86/dell/alienware-wmi-wmax.c    |  767 ++++++++++
 drivers/platform/x86/dell/alienware-wmi.c     | 1261 -----------------
 drivers/platform/x86/dell/alienware-wmi.h     |  104 ++
 8 files changed, 1509 insertions(+), 1288 deletions(-)
 create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
 create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
 create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
 delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
 create mode 100644 drivers/platform/x86/dell/alienware-wmi.h


base-commit: 6b228cfc52a6e9b7149cf51e247076963d6561cd

Comments

Armin Wolf Jan. 16, 2025, 10:39 p.m. UTC | #1 
Am 05.01.25 um 16:30 schrieb Kurt Borja:

> Hello :)
>
> I rebased this series on top of review-ilpo-next to pick up
> alienware-wmi's latest commit.

Hi,

sorry for taking a bit long to respond. Could you send a v4 series without
the already applied commits and which cleanly applies onto for-next?

I will then try to review this series till the end of this week.

Thanks,
Armin Wolf

> ~ Kurt
> ---
> v2 -> v3:
>
> [5/20]
>   - Use traditional if statement in zone_attr_visible and return attr->mode
>
> [7/20]
>   - Remove quirks from priv
>
> [8/20]
>   - Call alienware_alienfx_exit if device_add_groups fails
>   - Call device_remove_groups on .remove
>   - Return ret on alienware_wmi_init()
>
> [9/20]
>   - Directly return create_thermal_profile in alienware_awcc_setup()
>   - Assign priv on declaration in alienware_awcc_exit()
>
> [10/20]
>   - Fix alienware_wmi_command()
>
> [13/20]
>   - Rename x_series_features -> generic_quirks
>   - Rename g_series_features -> g_series_quirks
>   - Keep previous module parameter logic
>   - Additionally rename *quirks -> *alienfx
>
> [16/20]
>   - Export *alienfx as an extern variable on alienware-wmi.h
>   - Move pr_fmt to alienware-wmi.h
>
> [17/20]
>   - 2024 -> 2025
>
> [20/20]
>   - 2024 -> 2025
>
> [*/20]
>   - Add platform/x86 prefix to commit messages
>
> v2: https://lore.kernel.org/platform-driver-x86/20241229194506.8268-2-kuurtb@gmail.com/
>
> Kurt Borja (20):
>    platform/x86: alienware-wmi: Remove unnecessary check at module exit
>    platform/x86: alienware-wmi: Move Lighting Control State
>    platform/x86: alienware-wmi: Modify parse_rgb() signature
>    platform/x86: alienware-wmi: Improve hdmi_mux, amplifier and deepslp
>      group creation
>    platform/x86: alienware-wmi: Improve rgb-zones group creation
>    platform/x86: alienware_wmi: General cleanup of WMAX methods
>    platform/x86: alienware-wmi: Add a state container for LED control
>      feature
>    platform/x86: alienware-wmi: Add WMI Drivers
>    platform/x86: alienware-wmi: Add a state container for thermal control
>      methods
>    platform/x86: alienware-wmi: Refactor LED control methods
>    platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods
>    platform/x86: alienware-wmi: Refactor thermal control methods
>    platform/x86: alienware-wmi: Split DMI table
>    MAINTAINERS: Update ALIENWARE WMI DRIVER entry
>    platform/x86: Rename alienware-wmi.c
>    platform/x86: Add alienware-wmi.h
>    platform/x86: Split the alienware-wmi driver
>    platform/x86: dell: Modify Makefile alignment
>    platform/x86: Update alienware-wmi config entries
>    platform/x86: alienware-wmi: Update header and module information
>
>   MAINTAINERS                                   |    4 +-
>   drivers/platform/x86/dell/Kconfig             |   30 +-
>   drivers/platform/x86/dell/Makefile            |   45 +-
>   .../platform/x86/dell/alienware-wmi-base.c    |  488 +++++++
>   .../platform/x86/dell/alienware-wmi-legacy.c  |   98 ++
>   .../platform/x86/dell/alienware-wmi-wmax.c    |  767 ++++++++++
>   drivers/platform/x86/dell/alienware-wmi.c     | 1261 -----------------
>   drivers/platform/x86/dell/alienware-wmi.h     |  104 ++
>   8 files changed, 1509 insertions(+), 1288 deletions(-)
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
>   delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
>   create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
>
>
> base-commit: 6b228cfc52a6e9b7149cf51e247076963d6561cd
Kurt Borja Jan. 17, 2025, 4:33 a.m. UTC | #2 
On Thu Jan 16, 2025 at 5:39 PM -05, Armin Wolf wrote:
> Am 05.01.25 um 16:30 schrieb Kurt Borja:
>
> > Hello :)
> >
> > I rebased this series on top of review-ilpo-next to pick up
> > alienware-wmi's latest commit.
>
> Hi,
>
> sorry for taking a bit long to respond. Could you send a v4 series without
> the already applied commits and which cleanly applies onto for-next?

Don't worry!

I also have to rebase it on top of the latest platform profile API
change.

>
> I will then try to review this series till the end of this week.

Thank you very much!

~ Kurt

>
> Thanks,
> Armin Wolf
>
> > ~ Kurt
> > ---
> > v2 -> v3:
> >
> > [5/20]
> >   - Use traditional if statement in zone_attr_visible and return attr->mode
> >
> > [7/20]
> >   - Remove quirks from priv
> >
> > [8/20]
> >   - Call alienware_alienfx_exit if device_add_groups fails
> >   - Call device_remove_groups on .remove
> >   - Return ret on alienware_wmi_init()
> >
> > [9/20]
> >   - Directly return create_thermal_profile in alienware_awcc_setup()
> >   - Assign priv on declaration in alienware_awcc_exit()
> >
> > [10/20]
> >   - Fix alienware_wmi_command()
> >
> > [13/20]
> >   - Rename x_series_features -> generic_quirks
> >   - Rename g_series_features -> g_series_quirks
> >   - Keep previous module parameter logic
> >   - Additionally rename *quirks -> *alienfx
> >
> > [16/20]
> >   - Export *alienfx as an extern variable on alienware-wmi.h
> >   - Move pr_fmt to alienware-wmi.h
> >
> > [17/20]
> >   - 2024 -> 2025
> >
> > [20/20]
> >   - 2024 -> 2025
> >
> > [*/20]
> >   - Add platform/x86 prefix to commit messages
> >
> > v2: https://lore.kernel.org/platform-driver-x86/20241229194506.8268-2-kuurtb@gmail.com/
> >
> > Kurt Borja (20):
> >    platform/x86: alienware-wmi: Remove unnecessary check at module exit
> >    platform/x86: alienware-wmi: Move Lighting Control State
> >    platform/x86: alienware-wmi: Modify parse_rgb() signature
> >    platform/x86: alienware-wmi: Improve hdmi_mux, amplifier and deepslp
> >      group creation
> >    platform/x86: alienware-wmi: Improve rgb-zones group creation
> >    platform/x86: alienware_wmi: General cleanup of WMAX methods
> >    platform/x86: alienware-wmi: Add a state container for LED control
> >      feature
> >    platform/x86: alienware-wmi: Add WMI Drivers
> >    platform/x86: alienware-wmi: Add a state container for thermal control
> >      methods
> >    platform/x86: alienware-wmi: Refactor LED control methods
> >    platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods
> >    platform/x86: alienware-wmi: Refactor thermal control methods
> >    platform/x86: alienware-wmi: Split DMI table
> >    MAINTAINERS: Update ALIENWARE WMI DRIVER entry
> >    platform/x86: Rename alienware-wmi.c
> >    platform/x86: Add alienware-wmi.h
> >    platform/x86: Split the alienware-wmi driver
> >    platform/x86: dell: Modify Makefile alignment
> >    platform/x86: Update alienware-wmi config entries
> >    platform/x86: alienware-wmi: Update header and module information
> >
> >   MAINTAINERS                                   |    4 +-
> >   drivers/platform/x86/dell/Kconfig             |   30 +-
> >   drivers/platform/x86/dell/Makefile            |   45 +-
> >   .../platform/x86/dell/alienware-wmi-base.c    |  488 +++++++
> >   .../platform/x86/dell/alienware-wmi-legacy.c  |   98 ++
> >   .../platform/x86/dell/alienware-wmi-wmax.c    |  767 ++++++++++
> >   drivers/platform/x86/dell/alienware-wmi.c     | 1261 -----------------
> >   drivers/platform/x86/dell/alienware-wmi.h     |  104 ++
> >   8 files changed, 1509 insertions(+), 1288 deletions(-)
> >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c
> >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c
> >   create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c
> >   delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c
> >   create mode 100644 drivers/platform/x86/dell/alienware-wmi.h
> >
> >
> > base-commit: 6b228cfc52a6e9b7149cf51e247076963d6561cd