mbox series

[v1,0/2] pinctrl: intel: Fix PWM initialisation

Message ID 20250210195230.490904-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series pinctrl: intel: Fix PWM initialisation | expand

Message

andriy.shevchenko@linux.intel.com Feb. 10, 2025, 7:44 p.m. UTC
It appears that PWM instantiated from pinctrl-intel is configured
to a wrong flow. This mini-series to fix the issue. Note, patch 1
is comprehensive documentation paragraph to explain what the difference
in the programming flow and what the SoCs are affected.

The issue had been reported privately, hence no Closes tag.
I haven't added the Tested-by, so to make sure that it (still) works
I ask Alexis to give the formal Tag here in a response to the series.

The idea is to route this via pin control tree as there are already two patches
against PWM handling in pinctrl-intel. There is no need to backport that, it's
optional, because it wasn't worked from day 1, and hence no Cc: stable@.

Cc: Alexis GUILLEMET<alexis.guillemet@dunasys.com>

Andy Shevchenko (2):
  pwm: lpss: Clarify the bypass member semantics in struct
    pwm_lpss_boardinfo
  pinctrl: intel: Fix wrong bypass assignment in
    intel_pinctrl_probe_pwm()

 drivers/pinctrl/intel/pinctrl-intel.c      |  1 -
 include/linux/platform_data/x86/pwm-lpss.h | 33 ++++++++++++++++++++--
 2 files changed, 30 insertions(+), 4 deletions(-)

Comments

Mika Westerberg Feb. 11, 2025, 7:05 a.m. UTC | #1
On Mon, Feb 10, 2025 at 09:44:49PM +0200, Andy Shevchenko wrote:
> It appears that PWM instantiated from pinctrl-intel is configured
> to a wrong flow. This mini-series to fix the issue. Note, patch 1
> is comprehensive documentation paragraph to explain what the difference
> in the programming flow and what the SoCs are affected.
> 
> The issue had been reported privately, hence no Closes tag.
> I haven't added the Tested-by, so to make sure that it (still) works
> I ask Alexis to give the formal Tag here in a response to the series.
> 
> The idea is to route this via pin control tree as there are already two patches
> against PWM handling in pinctrl-intel. There is no need to backport that, it's
> optional, because it wasn't worked from day 1, and hence no Cc: stable@.
> 
> Cc: Alexis GUILLEMET<alexis.guillemet@dunasys.com>
> 
> Andy Shevchenko (2):
>   pwm: lpss: Clarify the bypass member semantics in struct
>     pwm_lpss_boardinfo
>   pinctrl: intel: Fix wrong bypass assignment in
>     intel_pinctrl_probe_pwm()

Both,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>