mbox series

[v6,00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements

Message ID 20250313-hwm-v6-0-17b57f787d77@gmail.com (mailing list archive)
Headers show
Series platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements | expand

Message

Kurt Borja March 13, 2025, 2:29 p.m. UTC
Hi all,

This set mainly adds hwmon and manual fan control support (patches 7-8)
to the alienware-wmi driver, after some improvements.

Thank you for your feedback :)

---
Changes in v6:

[08/12]
  - Define dev_pm_ops statically (kernel test robot)

Link to v5: https://lore.kernel.org/r/20250312-hwm-v5-0-deb15ff8f3c6@gmail.com

---
Kurt Borja (12):
      platform/x86: alienware-wmi-wmax: Rename thermal related symbols
      platform/x86: alienware-wmi-wmax: Refactor is_awcc_thermal_mode()
      platform/x86: alienware-wmi-wmax: Improve internal AWCC API
      platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
      platform/x86: alienware-wmi-wmax: Improve platform profile probe
      platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
      platform/x86: alienware-wmi-wmax: Add HWMON support
      platform/x86: alienware-wmi-wmax: Add support for manual fan control
      platform/x86: alienware-wmi-wmax: Add a DebugFS interface
      Documentation: wmi: Improve and update alienware-wmi documentation
      Documentation: admin-guide: laptops: Add documentation for alienware-wmi
      Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi

 Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
 .../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
 .../admin-guide/laptops/alienware-wmi.rst          |  128 +++
 Documentation/admin-guide/laptops/index.rst        |    1 +
 Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
 MAINTAINERS                                        |    3 +
 drivers/platform/x86/dell/Kconfig                  |    1 +
 drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1023 +++++++++++++++++---
 8 files changed, 1187 insertions(+), 410 deletions(-)
---
base-commit: f895f2493098b862f1ada0568aba278e49bf05b4
change-id: 20250305-hwm-f7bd91902b57

Best regards,

Comments

Armin Wolf March 17, 2025, 12:32 a.m. UTC | #1
Am 13.03.25 um 15:29 schrieb Kurt Borja:

> Hi all,
>
> This set mainly adds hwmon and manual fan control support (patches 7-8)
> to the alienware-wmi driver, after some improvements.
>
> Thank you for your feedback :)

 From my perspective the whole series is ready for inclusion into the mainline kernel.

Thanks,
Armin Wolf

> ---
> Changes in v6:
>
> [08/12]
>    - Define dev_pm_ops statically (kernel test robot)
>
> Link to v5: https://lore.kernel.org/r/20250312-hwm-v5-0-deb15ff8f3c6@gmail.com
>
> ---
> Kurt Borja (12):
>        platform/x86: alienware-wmi-wmax: Rename thermal related symbols
>        platform/x86: alienware-wmi-wmax: Refactor is_awcc_thermal_mode()
>        platform/x86: alienware-wmi-wmax: Improve internal AWCC API
>        platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
>        platform/x86: alienware-wmi-wmax: Improve platform profile probe
>        platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
>        platform/x86: alienware-wmi-wmax: Add HWMON support
>        platform/x86: alienware-wmi-wmax: Add support for manual fan control
>        platform/x86: alienware-wmi-wmax: Add a DebugFS interface
>        Documentation: wmi: Improve and update alienware-wmi documentation
>        Documentation: admin-guide: laptops: Add documentation for alienware-wmi
>        Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi
>
>   Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
>   .../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
>   .../admin-guide/laptops/alienware-wmi.rst          |  128 +++
>   Documentation/admin-guide/laptops/index.rst        |    1 +
>   Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
>   MAINTAINERS                                        |    3 +
>   drivers/platform/x86/dell/Kconfig                  |    1 +
>   drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1023 +++++++++++++++++---
>   8 files changed, 1187 insertions(+), 410 deletions(-)
> ---
> base-commit: f895f2493098b862f1ada0568aba278e49bf05b4
> change-id: 20250305-hwm-f7bd91902b57
>
> Best regards,
Kurt Borja March 25, 2025, 8:14 p.m. UTC | #2
On Thu Mar 13, 2025 at 11:29 AM -03, Kurt Borja wrote:
> Hi all,
>
> This set mainly adds hwmon and manual fan control support (patches 7-8)
> to the alienware-wmi driver, after some improvements.
>
> Thank you for your feedback :)
>
> ---
> Changes in v6:
>
> [08/12]
>   - Define dev_pm_ops statically (kernel test robot)
>
> Link to v5: https://lore.kernel.org/r/20250312-hwm-v5-0-deb15ff8f3c6@gmail.com
>
> ---
> Kurt Borja (12):
>       platform/x86: alienware-wmi-wmax: Rename thermal related symbols
>       platform/x86: alienware-wmi-wmax: Refactor is_awcc_thermal_mode()
>       platform/x86: alienware-wmi-wmax: Improve internal AWCC API
>       platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
>       platform/x86: alienware-wmi-wmax: Improve platform profile probe
>       platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
>       platform/x86: alienware-wmi-wmax: Add HWMON support
>       platform/x86: alienware-wmi-wmax: Add support for manual fan control
>       platform/x86: alienware-wmi-wmax: Add a DebugFS interface
>       Documentation: wmi: Improve and update alienware-wmi documentation
>       Documentation: admin-guide: laptops: Add documentation for alienware-wmi
>       Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi
>
>  Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
>  .../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
>  .../admin-guide/laptops/alienware-wmi.rst          |  128 +++
>  Documentation/admin-guide/laptops/index.rst        |    1 +
>  Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
>  MAINTAINERS                                        |    3 +
>  drivers/platform/x86/dell/Kconfig                  |    1 +
>  drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1023 +++++++++++++++++---
>  8 files changed, 1187 insertions(+), 410 deletions(-)
> ---
> base-commit: f895f2493098b862f1ada0568aba278e49bf05b4
> change-id: 20250305-hwm-f7bd91902b57
>
> Best regards,

Hi Ilpo,

Is there still a chance for this to go into v6.15? or are you planning
to review it on the next cycle?

Thank you either way!
Ilpo Järvinen March 26, 2025, 8:34 a.m. UTC | #3
On Tue, 25 Mar 2025, Kurt Borja wrote:
> On Thu Mar 13, 2025 at 11:29 AM -03, Kurt Borja wrote:
> > Hi all,
> >
> > This set mainly adds hwmon and manual fan control support (patches 7-8)
> > to the alienware-wmi driver, after some improvements.
> >
> > Thank you for your feedback :)
> >
> > ---
> > Changes in v6:
> >
> > [08/12]
> >   - Define dev_pm_ops statically (kernel test robot)
> >
> > Link to v5: https://lore.kernel.org/r/20250312-hwm-v5-0-deb15ff8f3c6@gmail.com
> >
> > ---
> > Kurt Borja (12):
> >       platform/x86: alienware-wmi-wmax: Rename thermal related symbols
> >       platform/x86: alienware-wmi-wmax: Refactor is_awcc_thermal_mode()
> >       platform/x86: alienware-wmi-wmax: Improve internal AWCC API
> >       platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
> >       platform/x86: alienware-wmi-wmax: Improve platform profile probe
> >       platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
> >       platform/x86: alienware-wmi-wmax: Add HWMON support
> >       platform/x86: alienware-wmi-wmax: Add support for manual fan control
> >       platform/x86: alienware-wmi-wmax: Add a DebugFS interface
> >       Documentation: wmi: Improve and update alienware-wmi documentation
> >       Documentation: admin-guide: laptops: Add documentation for alienware-wmi
> >       Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi
> >
> >  Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
> >  .../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
> >  .../admin-guide/laptops/alienware-wmi.rst          |  128 +++
> >  Documentation/admin-guide/laptops/index.rst        |    1 +
> >  Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
> >  MAINTAINERS                                        |    3 +
> >  drivers/platform/x86/dell/Kconfig                  |    1 +
> >  drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1023 +++++++++++++++++---
> >  8 files changed, 1187 insertions(+), 410 deletions(-)
> > ---
> > base-commit: f895f2493098b862f1ada0568aba278e49bf05b4
> > change-id: 20250305-hwm-f7bd91902b57
> >
> > Best regards,
> 
> Hi Ilpo,
> 
> Is there still a chance for this to go into v6.15? or are you planning
> to review it on the next cycle?

Hi,

I'm almost there to make the main PR for 6.15 from what's in for-next 
currently, so no, this won't be part of it.

In general, I don't usually take large series after -rc6 timeframe to give 
time for things to settle and problems to be brought to surface.
Especially if the series is interfacing with other subsystems which is 
prone to lack of select/depends on clauses, etc. so more likely to break 
the build than changes that seem immune to the .config variations.