| Message ID | 1438198283-2180-1-git-send-email-stlman@poczta.fm (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
On Wed, Jul 29, 2015 at 09:31:23PM +0200, ?ukasz Stelmach wrote: > Asus F3M has two keys labeled with an icon of a touchpad. The first, > reported as 0x6B is next to the power key and the second, reported as > 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was > getting "Unknown key 6a pressed" message before applying this patch. > > Asus F3M does not support WMI so the commit does not update key mappings > in the asus-nb-wmi.c file. > > I have not tested this mapping on any other Asus laptop. > > Signed-off-by: ?ukasz Stelmach <stlman@poczta.fm> Thanks ?ukasz. Corentin, any concerns? > --- > drivers/platform/x86/asus-laptop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index 58d29c4..f2b5d0a 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = { > {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */ > {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */ > {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */ > + {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */ > {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */ > {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */ > {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */ > -- > 2.1.4 > >
On Wed, Aug 5, 2015 at 10:29 PM, Darren Hart <dvhart@infradead.org> wrote: > On Wed, Jul 29, 2015 at 09:31:23PM +0200, ?ukasz Stelmach wrote: >> Asus F3M has two keys labeled with an icon of a touchpad. The first, >> reported as 0x6B is next to the power key and the second, reported as >> 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was >> getting "Unknown key 6a pressed" message before applying this patch. >> >> Asus F3M does not support WMI so the commit does not update key mappings >> in the asus-nb-wmi.c file. >> >> I have not tested this mapping on any other Asus laptop. >> >> Signed-off-by: ?ukasz Stelmach <stlman@poczta.fm> > > Thanks ?ukasz. > > Corentin, any concerns? Acked-by: Corentin Chary <corentin.chary@gmail.com> Sorry for the delay, I won't really have a stable internet connection until October. > >> --- >> drivers/platform/x86/asus-laptop.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c >> index 58d29c4..f2b5d0a 100644 >> --- a/drivers/platform/x86/asus-laptop.c >> +++ b/drivers/platform/x86/asus-laptop.c >> @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = { >> {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */ >> {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */ >> {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */ >> + {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */ >> {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */ >> {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */ >> {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */ >> -- >> 2.1.4 >> >> > > -- > Darren Hart > Intel Open Source Technology Center
On Wed, Aug 12, 2015 at 09:06:08AM +0200, Corentin Chary wrote: > On Wed, Aug 5, 2015 at 10:29 PM, Darren Hart <dvhart@infradead.org> wrote: > > On Wed, Jul 29, 2015 at 09:31:23PM +0200, ?ukasz Stelmach wrote: > >> Asus F3M has two keys labeled with an icon of a touchpad. The first, > >> reported as 0x6B is next to the power key and the second, reported as > >> 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was > >> getting "Unknown key 6a pressed" message before applying this patch. > >> > >> Asus F3M does not support WMI so the commit does not update key mappings > >> in the asus-nb-wmi.c file. > >> > >> I have not tested this mapping on any other Asus laptop. > >> > >> Signed-off-by: ?ukasz Stelmach <stlman@poczta.fm> > > > > Thanks ?ukasz. > > > > Corentin, any concerns? > > Acked-by: Corentin Chary <corentin.chary@gmail.com> > > Sorry for the delay, I won't really have a stable internet connection > until October. It's already in next, but thank you for following up.
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 58d29c4..f2b5d0a 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = { {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */ {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */ {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */ + {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */ {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */ {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */ {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */
Asus F3M has two keys labeled with an icon of a touchpad. The first, reported as 0x6B is next to the power key and the second, reported as 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was getting "Unknown key 6a pressed" message before applying this patch. Asus F3M does not support WMI so the commit does not update key mappings in the asus-nb-wmi.c file. I have not tested this mapping on any other Asus laptop. Signed-off-by: ?ukasz Stelmach <stlman@poczta.fm> --- drivers/platform/x86/asus-laptop.c | 1 + 1 file changed, 1 insertion(+)