| Message ID | 1440330069-16537-1-git-send-email-giedrius.statkevicius@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
On Sun, Aug 23, 2015 at 02:41:09PM +0300, Giedrius Statkevi?ius wrote: > acpi_bus_register_driver() already returns an appropriate value (0 on > success, and some negative value on error) to be used in __init functions > so the goto/label is redundant in hpwl_init thus remove it and directly > return the value > > Signed-off-by: Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> Thanks Giedrius, queued.
diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c index 4e4cc8b..988eedb 100644 --- a/drivers/platform/x86/hp-wireless.c +++ b/drivers/platform/x86/hp-wireless.c @@ -114,14 +114,9 @@ static int __init hpwl_init(void) pr_info("Initializing HPQ6001 module\n"); err = acpi_bus_register_driver(&hpwl_driver); - if (err) { + if (err) pr_err("Unable to register HP wireless control driver.\n"); - goto error_acpi_register; - } - - return 0; -error_acpi_register: return err; }
acpi_bus_register_driver() already returns an appropriate value (0 on success, and some negative value on error) to be used in __init functions so the goto/label is redundant in hpwl_init thus remove it and directly return the value Signed-off-by: Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> --- drivers/platform/x86/hp-wireless.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)