From patchwork Tue Jan 12 14:02:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 8017721 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AA17DBEEE5 for ; Tue, 12 Jan 2016 14:09:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D076203C2 for ; Tue, 12 Jan 2016 14:09:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D4F20154 for ; Tue, 12 Jan 2016 14:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762582AbcALOJG (ORCPT ); Tue, 12 Jan 2016 09:09:06 -0500 Received: from mail-lb0-f194.google.com ([209.85.217.194]:34501 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965445AbcALOD1 (ORCPT ); Tue, 12 Jan 2016 09:03:27 -0500 Received: by mail-lb0-f194.google.com with SMTP id oe3so1864199lbb.1 for ; Tue, 12 Jan 2016 06:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Kl2zOT32Na7aHsEb0e3g6MX11wURPvZB0ood3xQfS8U=; b=c8+mdPGrl4U7A3RnK+zVUzWKBPfRAQcSq92nFlM45TX0aVXYOoL9HSfg7KCVb8WOM8 QQ20Gl++iU6UaKgsNusUaJnkvtPL3C9mS/6VaXhgqfr3WN09EvLrsozsYi7os5T/e8Tw I91wzZvaVQEYt+KlILKUmeWBbLPZUw/TJ9Pm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Kl2zOT32Na7aHsEb0e3g6MX11wURPvZB0ood3xQfS8U=; b=IGeOBVQCQBdGzBuaSIyx/QCPhGFm8ZKKErYs0nPuWA4Jf/B4z5QhyKDBZYH8cJj/NS OQTaUuZ7tdZ7zA4xYWIOLg9uPjgoQo05CdruxRwYyDbceFiermwsWXE3zk7EB+ogxrs4 DVZLNuJ/O94FJeT/jZmCP2ouHs/YL/UfadM9UWkfDSPCUskxl4WyZNcKT1QA3PVA9E7Z CCqWvRWdxxw6oll+eGpGU+DyUV3BKRxt1chLQ7WQAH3Xu60gfRnsL6ajeVTLtUrEEiac Obx3SWVEB3YGTm87NUfqa63moETq6Gg137QjO9R5yYVtGSs5OOq/6DELOLhZ358U5+w/ Sz/Q== X-Gm-Message-State: ALoCoQl73iQ0Ca8uFHPtQ/OrC9z3MZd97zn244OjblupugonIG3IbMXAVsLlSNx6HtB+V1li+7F7NOEeyMhElc7ix+6D70ZpeQ== X-Received: by 10.112.165.69 with SMTP id yw5mr48681343lbb.1.1452607405309; Tue, 12 Jan 2016 06:03:25 -0800 (PST) Received: from eudyptula.hq.kempniu.pl. (eudyptula.hq.kempniu.pl. [2001:6a0:200:83b0::fd5a]) by smtp.googlemail.com with ESMTPSA id wu10sm21513794lbb.44.2016.01.12.06.03.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2016 06:03:24 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Darren Hart , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Richard Purdie , Jacek Anaszewski Cc: Alex Hung , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/14] dell-smbios: rename release_buffer() to dell_smbios_release_buffer() Date: Tue, 12 Jan 2016 15:02:52 +0100 Message-Id: <1452607380-20861-7-git-send-email-kernel@kempniu.pl> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1452607380-20861-1-git-send-email-kernel@kempniu.pl> References: <1452607380-20861-1-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As release_buffer() is exported from the module, it has to be renamed to something less generic, so add a "dell_smbios_" prefix to the function name. Signed-off-by: Micha? K?pie? --- drivers/platform/x86/dell-laptop.c | 28 ++++++++++++++-------------- drivers/platform/x86/dell-smbios.c | 4 ++-- drivers/platform/x86/dell-smbios.h | 2 +- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 5df30a9..ab256ae 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -445,7 +445,7 @@ static int dell_rfkill_set(void *data, bool blocked) ret = dell_smbios_buffer->output[0]; out: - release_buffer(); + dell_smbios_release_buffer(); return dell_smi_error(ret); } @@ -487,7 +487,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data) status = dell_smbios_buffer->output[1]; if (ret != 0 || !(status & BIT(0))) { - release_buffer(); + dell_smbios_release_buffer(); return; } @@ -498,7 +498,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data) ret = dell_smbios_buffer->output[0]; hwswitch = dell_smbios_buffer->output[1]; - release_buffer(); + dell_smbios_release_buffer(); if (ret != 0) return; @@ -533,7 +533,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data) hwswitch_ret = dell_smbios_buffer->output[0]; hwswitch_state = dell_smbios_buffer->output[1]; - release_buffer(); + dell_smbios_release_buffer(); seq_printf(s, "return:\t%d\n", ret); seq_printf(s, "status:\t0x%X\n", status); @@ -651,7 +651,7 @@ static void dell_update_rfkill(struct work_struct *ignored) } out: - release_buffer(); + dell_smbios_release_buffer(); } static DECLARE_DELAYED_WORK(dell_rfkill_work, dell_update_rfkill); @@ -714,7 +714,7 @@ static int __init dell_setup_rfkill(void) dell_send_request(17, 11); ret = dell_smbios_buffer->output[0]; status = dell_smbios_buffer->output[1]; - release_buffer(); + dell_smbios_release_buffer(); /* dell wireless info smbios call is not supported */ if (ret != 0) @@ -885,7 +885,7 @@ static int dell_send_intensity(struct backlight_device *bd) ret = dell_smi_error(dell_smbios_buffer->output[0]); - release_buffer(); + dell_smbios_release_buffer(); return ret; } @@ -911,7 +911,7 @@ static int dell_get_intensity(struct backlight_device *bd) else ret = dell_smbios_buffer->output[1]; - release_buffer(); + dell_smbios_release_buffer(); return ret; } @@ -1185,7 +1185,7 @@ static int kbd_get_info(struct kbd_info *info) info->days = (dell_smbios_buffer->output[3] >> 24) & 0xFF; out: - release_buffer(); + dell_smbios_release_buffer(); return ret; } @@ -1269,7 +1269,7 @@ static int kbd_get_state(struct kbd_state *state) state->level = (dell_smbios_buffer->output[2] >> 16) & 0xFF; out: - release_buffer(); + dell_smbios_release_buffer(); return ret; } @@ -1287,7 +1287,7 @@ static int kbd_set_state(struct kbd_state *state) dell_smbios_buffer->input[2] |= (state->level & 0xFF) << 16; dell_send_request(4, 11); ret = dell_smbios_buffer->output[0]; - release_buffer(); + dell_smbios_release_buffer(); return dell_smi_error(ret); } @@ -1329,7 +1329,7 @@ static int kbd_set_token_bit(u8 bit) dell_smbios_buffer->input[1] = da_tokens[id].value; dell_send_request(1, 0); ret = dell_smbios_buffer->output[0]; - release_buffer(); + dell_smbios_release_buffer(); return dell_smi_error(ret); } @@ -1352,7 +1352,7 @@ static int kbd_get_token_bit(u8 bit) dell_send_request(0, 0); ret = dell_smbios_buffer->output[0]; val = dell_smbios_buffer->output[1]; - release_buffer(); + dell_smbios_release_buffer(); if (ret) return dell_smi_error(ret); @@ -2023,7 +2023,7 @@ static int __init dell_init(void) dell_send_request(0, 2); if (dell_smbios_buffer->output[0] == 0) max_intensity = dell_smbios_buffer->output[3]; - release_buffer(); + dell_smbios_release_buffer(); } if (max_intensity) { diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 27dbfb9..20d7f21 100644 --- a/drivers/platform/x86/dell-smbios.c +++ b/drivers/platform/x86/dell-smbios.c @@ -53,11 +53,11 @@ void dell_smbios_get_buffer(void) } EXPORT_SYMBOL_GPL(dell_smbios_get_buffer); -void release_buffer(void) +void dell_smbios_release_buffer(void) { mutex_unlock(&buffer_mutex); } -EXPORT_SYMBOL_GPL(release_buffer); +EXPORT_SYMBOL_GPL(dell_smbios_release_buffer); int find_token_id(int tokenid) { diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h index e3c2014..1ffd680 100644 --- a/drivers/platform/x86/dell-smbios.h +++ b/drivers/platform/x86/dell-smbios.h @@ -40,7 +40,7 @@ extern struct calling_interface_token *da_tokens; void dell_smbios_clear_buffer(void); void dell_smbios_get_buffer(void); -void release_buffer(void); +void dell_smbios_release_buffer(void); int find_token_id(int tokenid); int find_token_location(int tokenid);