From patchwork Fri Jan 22 14:27:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 8090641 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 137EDBEEE5 for ; Fri, 22 Jan 2016 14:31:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 240ED203A1 for ; Fri, 22 Jan 2016 14:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BC2120395 for ; Fri, 22 Jan 2016 14:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbcAVObN (ORCPT ); Fri, 22 Jan 2016 09:31:13 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:33270 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754146AbcAVO2C (ORCPT ); Fri, 22 Jan 2016 09:28:02 -0500 Received: by mail-lf0-f66.google.com with SMTP id z62so4198727lfd.0 for ; Fri, 22 Jan 2016 06:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=Qz2BMXaw23SmIac+vthdq9GxturZRckykoSl4889NJA=; b=SzD752efdL6nfJCPMISlmLPXYsL0H3IMyoeTKQBVFqJGb8lPO0vOQERFEMItAm4kBl ubgbAaG4ZPf4c6M4w35XsI8XZFaG54iwUUR3CjPm/qpT6zn9wV2fM0roMeMGE3RcgY78 /4hpChk8y4K9E36QGMLpPPY02O0oklbO8Wmus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=Qz2BMXaw23SmIac+vthdq9GxturZRckykoSl4889NJA=; b=Ty5uXBD7Ig3HMVFDGppwiBU8YiTsJtX7tPRrlJZWiPj9eH9R/mjQx8IljEmfZfB/zx A0voQy8ZXBQswg97A+3Fk3AETQvgB4KH7WQ9HGJdB+dSd6JDCpC0cHn16LhPXyQeEtRf ud9i7AJdqbQKUJihcoR/ISxthiMJBJ45W0OSYSmrgIEBKbMVxQVd7jyJyBZV+c+E3CRv LOmqL/24gn6AAKJXL1gVncyhKfINgitIMzut5NLVQaQ6V6kCyNTqbGEQ1RE2TfRWJSPY 8HG/4mY0yZ7YURTGPdBXn5zeTJX1mTuyqlnzR3ZWA1vTNifK8skbroqtV7BZsbRMsdCD 8xIQ== X-Gm-Message-State: AG10YOSXe6M5jqrq8uwumKCQK/T1ZcjBYJfKy6i6qG7ViPibUZL42PtXaHcPQZxqod82aQ== X-Received: by 10.25.153.130 with SMTP id b124mr1381298lfe.81.1453472880954; Fri, 22 Jan 2016 06:28:00 -0800 (PST) Received: from eudyptula.hq.kempniu.pl. (eudyptula.hq.kempniu.pl. [2001:6a0:200:83b0::fd5a]) by smtp.googlemail.com with ESMTPSA id o82sm912027lfo.47.2016.01.22.06.27.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2016 06:27:59 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Darren Hart , Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Richard Purdie , Jacek Anaszewski Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/16] dell-led: use dell_smbios_send_request() for performing SMBIOS calls Date: Fri, 22 Jan 2016 15:27:28 +0100 Message-Id: <1453472848-3118-17-git-send-email-kernel@kempniu.pl> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1453472848-3118-1-git-send-email-kernel@kempniu.pl> References: <1453472848-3118-1-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Instead of using the WMI wrapper, dell-led can take advantage of dell_smbios_send_request() for performing the SMBIOS calls required to change the state of the microphone LED. Signed-off-by: Micha? K?pie? Acked-by: Jacek Anaszewski --- drivers/leds/dell-led.c | 65 +++++------------------------------------------ 1 file changed, 6 insertions(+), 59 deletions(-) diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c index bfa7511..b3d6e9c 100644 --- a/drivers/leds/dell-led.c +++ b/drivers/leds/dell-led.c @@ -43,64 +43,13 @@ MODULE_ALIAS("wmi:" DELL_LED_BIOS_GUID); #define CMD_LED_OFF 17 #define CMD_LED_BLINK 18 -struct app_wmi_args { - u16 class; - u16 selector; - u32 arg1; - u32 arg2; - u32 arg3; - u32 arg4; - u32 res1; - u32 res2; - u32 res3; - u32 res4; - char dummy[92]; -}; - #define GLOBAL_MIC_MUTE_ENABLE 0x364 #define GLOBAL_MIC_MUTE_DISABLE 0x365 -static int dell_wmi_perform_query(struct app_wmi_args *args) -{ - struct app_wmi_args *bios_return; - union acpi_object *obj; - struct acpi_buffer input; - struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; - acpi_status status; - u32 rc = -EINVAL; - - input.length = 128; - input.pointer = args; - - status = wmi_evaluate_method(DELL_APP_GUID, 0, 1, &input, &output); - if (!ACPI_SUCCESS(status)) - goto err_out0; - - obj = output.pointer; - if (!obj) - goto err_out0; - - if (obj->type != ACPI_TYPE_BUFFER) - goto err_out1; - - bios_return = (struct app_wmi_args *)obj->buffer.pointer; - rc = bios_return->res1; - if (rc) - goto err_out1; - - memcpy(args, bios_return, sizeof(struct app_wmi_args)); - rc = 0; - - err_out1: - kfree(obj); - err_out0: - return rc; -} - static int dell_micmute_led_set(int state) { + struct calling_interface_buffer *buffer; struct calling_interface_token *token; - struct app_wmi_args args; if (!wmi_has_guid(DELL_APP_GUID)) return -ENODEV; @@ -115,13 +64,11 @@ static int dell_micmute_led_set(int state) if (!token) return -ENODEV; - memset(&args, 0, sizeof(struct app_wmi_args)); - - args.class = 1; - args.arg1 = token->location; - args.arg2 = token->value; - - dell_wmi_perform_query(&args); + buffer = dell_smbios_get_buffer(); + buffer->input[0] = token->location; + buffer->input[1] = token->value; + dell_smbios_send_request(1, 0); + dell_smbios_release_buffer(); return state; }