From patchwork Wed Jan 27 23:26:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 8145151 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 75C69BEEE5 for ; Wed, 27 Jan 2016 23:27:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F343920279 for ; Wed, 27 Jan 2016 23:26:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF1112026F for ; Wed, 27 Jan 2016 23:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932245AbcA0X06 (ORCPT ); Wed, 27 Jan 2016 18:26:58 -0500 Received: from smtprelay0079.hostedemail.com ([216.40.44.79]:59619 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932118AbcA0X05 (ORCPT ); Wed, 27 Jan 2016 18:26:57 -0500 Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id CAE8D6AA92; Wed, 27 Jan 2016 23:26:55 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::, RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3874:3876:4321:5007:6261:7514:7904:8957:10004:10400:10848:11026:11232:11658:11783:11914:12043:12438:12517:12519:12555:12740:13069:13095:13311:13357:13894:14659:21080, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none X-HE-Tag: rain86_1f14335dc2958 X-Filterd-Recvd-Size: 2863 Received: from joe-X200MA.home (pool-173-51-221-2.lsanca.fios.verizon.net [173.51.221.2]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Wed, 27 Jan 2016 23:26:53 +0000 (UTC) Message-ID: <1453937211.10099.31.camel@perches.com> Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" From: Joe Perches To: Eric Curtin , platform-driver-x86@vger.kernel.org Cc: Kernel development list , Darren Hart , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net Date: Wed, 27 Jan 2016 15:26:51 -0800 In-Reply-To: References: X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: > Message gets logged on machines that are well supported. > > Signed-off-by: Eric Curtin > --- >  drivers/platform/x86/thinkpad_acpi.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index a268a7a..4eb41aa 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6661,7 +6661,6 @@ static void __init > tpacpi_detect_brightness_capabilities(void) >                 pr_info("detected a 8-level brightness capable > ThinkPad\n"); >                 break; >         default: > -               pr_info("Unsupported brightness interface\n"); >                 tp_features.bright_unkfw = 1; >                 bright_maxlvl = b - 1; >         } Perhaps this should be something like this instead: ---  drivers/platform/x86/thinkpad_acpi.c | 4 +---  1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index a268a7a..bd12c71 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)   switch (b) {   case 16:   bright_maxlvl = 15; - pr_info("detected a 16-level brightness capable ThinkPad\n");   break;   case 8:   case 0:   bright_maxlvl = 7; - pr_info("detected a 8-level brightness capable ThinkPad\n");   break;   default: - pr_info("Unsupported brightness interface\n");   tp_features.bright_unkfw = 1;   bright_maxlvl = b - 1;   } + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);  }    static int __init brightness_init(struct ibm_init_struct *iibm)