diff mbox

[5/5] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA

Message ID 1454951123-27470-6-git-send-email-jprvita@endlessm.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

João Paulo Rechi Vita Feb. 8, 2016, 5:05 p.m. UTC
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
Reported-by: Ming Shuo Chiu <chiu@endlessm.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Darren Hart Feb. 8, 2016, 9:03 p.m. UTC | #1
On Mon, Feb 08, 2016 at 12:05:23PM -0500, João Paulo Rechi Vita wrote:

I'm waiting for the RFKILL reviews to complete, but quickly, patches 4 and 5
require a commit message. There is always something you can add here, for
example, do these not have a switch or is it handled by a different driver? Etc.

> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> Reported-by: Ming Shuo Chiu <chiu@endlessm.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 4ded187..5adb842 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -328,6 +328,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  		},
>  		.driver_data = &quirk_no_rfkill,
>  	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. Z550MA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Z550MA"),
> +		},
> +		.driver_data = &quirk_no_rfkill,
> +	},
>  	{},
>  };
>  
> -- 
> 2.5.0
> 
>
João Paulo Rechi Vita Feb. 9, 2016, 9:39 p.m. UTC | #2
On 8 February 2016 at 16:03, Darren Hart <dvhart@infradead.org> wrote:
> On Mon, Feb 08, 2016 at 12:05:23PM -0500, João Paulo Rechi Vita wrote:
>
> I'm waiting for the RFKILL reviews to complete, but quickly, patches 4 and 5
> require a commit message. There is always something you can add here, for
> example, do these not have a switch or is it handled by a different driver? Etc.
>

All right, I'll work on the commit messages. Thanks!

--
João Paulo Rechi Vita
http://about.me/jprvita
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 4ded187..5adb842 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -328,6 +328,15 @@  static const struct dmi_system_id asus_quirks[] = {
 		},
 		.driver_data = &quirk_no_rfkill,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. Z550MA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Z550MA"),
+		},
+		.driver_data = &quirk_no_rfkill,
+	},
 	{},
 };