From patchwork Wed Feb 24 07:20:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 8402331 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F6849F1D4 for ; Wed, 24 Feb 2016 07:20:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B805202EC for ; Wed, 24 Feb 2016 07:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D43D202E9 for ; Wed, 24 Feb 2016 07:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234AbcBXHUR (ORCPT ); Wed, 24 Feb 2016 02:20:17 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36250 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757704AbcBXHTg (ORCPT ); Wed, 24 Feb 2016 02:19:36 -0500 Received: by mail-wm0-f52.google.com with SMTP id g62so256977285wme.1 for ; Tue, 23 Feb 2016 23:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=5ABb2MSFBrxBwtQNjkOMVMiydNGGszrvwbRdrd3WU90=; b=T6mPxqf8fkbEfTxacgVhTz0S+wEn7aJI0swG8s/SvrGHp7BBnyQHeYfOtwenrwIisL NR5f2kg6NddJPXOfF+P6L7lFU+qaktTqBZ8+aMdv1Dixv2ceaIHAvnrD81ZbvIgPn6gD TQd3nUcSkCB7iH2ImAEHaY4CK790jRy/rPTyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=5ABb2MSFBrxBwtQNjkOMVMiydNGGszrvwbRdrd3WU90=; b=NkKGY4dzQxeXagpgb+0B0/2QNkAF9mbJsTLICB9aNYjuPVMHUSaW8dq4WeaxKF0G+b fiCVIXDBnf6OFWWg57xCr2QLeWoHqo8dZOQ0RRqLHG0rzVYnh+tQ8I4rKZrm1pjZMCi4 V16AH/K2GtM8PLqYoPc03HXK83v8l/L3kCbi9aAIIMimXG0EdpNFZF/f/Qj4a4CZSGsG i+dqdEQNty3hBZ8gjr/QpiUg/VOyA4HpDCprHmKmjUxIRIbncoZyyOb8cnZkpYtz0UuB 52bVd0a6Q3PWV+IQWTEhyVJpppSchPqnluU54d5ic29EKjNt/TybBFdJdrb+8lUbmWoI S7Qw== X-Gm-Message-State: AG10YOSwG31ecZPty+YsWjypYSh0NmyC/yeG+aCaapDVBAlYzPDTdJqL2EvVC3NZHe4rOA== X-Received: by 10.194.63.43 with SMTP id d11mr35710263wjs.67.1456298374929; Tue, 23 Feb 2016 23:19:34 -0800 (PST) Received: from eudyptula.hq.kempniu.pl. (eudyptula.hq.kempniu.pl. [2001:6a0:200:83b0::fd5a]) by smtp.googlemail.com with ESMTPSA id a128sm1981540wmh.6.2016.02.23.23.19.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2016 23:19:33 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart Cc: Darek Stojaczyk , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Date: Wed, 24 Feb 2016 08:20:14 +0100 Message-Id: <1456298416-29683-5-git-send-email-kernel@kempniu.pl> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1456298416-29683-1-git-send-email-kernel@kempniu.pl> References: <1455634230-1487-1-git-send-email-kernel@kempniu.pl> <1456298416-29683-1-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On models on which an SMBIOS request needs to be issued in order for WMI events to be generated, pressing the Dell Instant Launch hotkey does not raise an i8042 interrupt - only a WMI event is generated (0xe025 on Dell Vostro V131). Thus, the 0xe025 event should only be ignored on machines which do not require an SMBIOS request for enabling WMI. Signed-off-by: Micha? K?pie? --- drivers/platform/x86/dell-wmi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 65edd93..ffc957b5 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c @@ -111,7 +111,7 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { { KE_IGNORE, 0xe020, { KEY_MUTE } }, /* Shortcut and audio panel keys */ - { KE_IGNORE, 0xe025, { KEY_RESERVED } }, + { KE_KEY, 0xe025, { KEY_PROG4 } }, { KE_IGNORE, 0xe026, { KEY_RESERVED } }, { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } }, @@ -235,6 +235,9 @@ static void dell_wmi_process_key(int reported_key) acpi_video_handles_brightness_key_presses()) return; + if (key->keycode == KEY_PROG4 && !wmi_requires_smbios_request) + return; + sparse_keymap_report_entry(dell_wmi_input_dev, key, 1, true); }