From patchwork Mon Feb 29 12:13:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8452591 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9AFB09F52D for ; Mon, 29 Feb 2016 12:14:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B29C02027D for ; Mon, 29 Feb 2016 12:14:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFA0220211 for ; Mon, 29 Feb 2016 12:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbcB2MOf (ORCPT ); Mon, 29 Feb 2016 07:14:35 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:54705 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754013AbcB2MOe (ORCPT ); Mon, 29 Feb 2016 07:14:34 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0Lc8mL-1a9Eso3wBh-00jZCu; Mon, 29 Feb 2016 13:13:40 +0100 From: Arnd Bergmann To: Darren Hart Cc: linux-arm-kernel@lists.infradead.org, Andy Lutomirski , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Arnd Bergmann , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: never 'select DMI' from a driver Date: Mon, 29 Feb 2016 13:13:31 +0100 Message-Id: <1456748014-358588-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:h9iitAZW1iZpi8mMyql3E+Iwv9HNkBZD5VZiofD/dONq7HFrp8d ahu9pmJ06VXioq+IfFD/NnSGQcCYrAJdg9ADoal0ePqjBWW6ewi5jXTOU2P3iACdOvogVhZ e++fMCCnFS4jex5QU7ZWSH4RAnLQF2gFVtWDrP1fMs+SZisGI0xgi5RMbI6gJZr4qMvVXUo PEnom4y5QymD52gkifBxw== X-UI-Out-Filterresults: notjunk:1; V01:K0:FPKmeEuO/zg=:HigwwShyL7+FRHYtD/OAcQ cQ7/WtZSitUJkWqH/BzgDWk3O4euIGsQwwMwtV1UJAlRGFD6fHEjD63rKEQPKHPpoynoDjTLT dvsLkwIQTiF5sDpjwN1aNAKBibDtC/F3U1afjCHirU+2/FKFCvn/D3A/VXDmrSA6T38xdz7nf OUvdNCu5bCGWdlvdBldripSm7Zi6JPfJpbOHrAdBF84nqEIsYv+RulDKpo0+fOcYzOVmvxwfd aQXT+3DqOqJxnwdfw8L6iRp6BzdTwGiKda7BQbhbhrLnNmzdVNGGQKSmvEAu7CReNp/YiflHt H3t26qLuZYn15sunQKmww5ohBvTJ7yp7lbDktvWHB0NZ+Fk3VywJmBrEPfOneRL2c0SvWVXAt yEZuDIWo/6E/iyXrjak4Jl7847XzjtePfMrRd7ih0emujGLFgGSXXUzAMl0y7IQuDXDQ6xfV/ NM+nbwT/wEyZyuxoTXunU4GaFMDdi6jTIssWLRbelgdSwWn8sE30w1ETJLpkDKgiomiOza63S BQfpR4av7kKJvMQRdWt0uzcg64Gkt12Y3zwJRViXuZwNP/sYhnkm91pEGEAMeLFvhGqIYqY4K KuWFhKI4PLnJLyfJjmuEqPgdVWeQd7xUulZarI4y50aVgPV+F5hD3VWaibUbSW9Se8DpfedAL oV2DtT/Q+qAfmjqxJK+bOX/J4KckfKBlXh3L7EK88tIRRV878dTIFo4xPGqE0FezvNQQ= Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP CONFIG_DMI is a user-selectable Kconfig symbol that some drivers depend on. As part of a recent patch, other drivers started adding a 'select' for the same symbol, which now causes a recursive dependency: drivers/gpio/Kconfig:34:error: recursive dependency detected! subsection "Kconfig recursive dependency limitations" drivers/gpio/Kconfig:34: symbol GPIOLIB is selected by GEOS For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" arch/x86/Kconfig:2591: symbol GEOS depends on DMI For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" arch/x86/Kconfig:815: symbol DMI is selected by DELL_LAPTOP For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/platform/x86/Kconfig:104: symbol DELL_LAPTOP depends on BACKLIGHT_CLASS_DEVICE For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/backlight/Kconfig:158: symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:192: symbol FB_BACKLIGHT is selected by FB_SSD1307 For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" drivers/video/fbdev/Kconfig:2462: symbol FB_SSD1307 depends on GPIOLIB Basically we should either always use 'depends on' or always use 'select' to avoid this kind of loop. Using 'depends on' is more useful here, as it still allows users to turn off the symbol of they really want to, without having to track down every driver selecting it. Signed-off-by: Arnd Bergmann Fixes: cbd9d95b2b27 ("dell-wmi, dell-laptop: select DMI") --- drivers/platform/x86/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 659e13b1e6f0..a65d974f387a 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -105,6 +105,7 @@ config DELL_LAPTOP tristate "Dell Laptop Extras" depends on X86 depends on DELL_SMBIOS + depends on DMI depends on BACKLIGHT_CLASS_DEVICE depends on ACPI_VIDEO || ACPI_VIDEO = n depends on RFKILL || RFKILL = n @@ -112,7 +113,6 @@ config DELL_LAPTOP select POWER_SUPPLY select LEDS_CLASS select NEW_LEDS - select DMI default n ---help--- This driver adds support for rfkill and backlight control to Dell @@ -121,10 +121,10 @@ config DELL_LAPTOP config DELL_WMI tristate "Dell WMI extras" depends on ACPI_WMI + depends on DMI depends on INPUT depends on ACPI_VIDEO || ACPI_VIDEO = n select INPUT_SPARSEKMAP - select DMI ---help--- Say Y here if you want to support WMI-based hotkeys on Dell laptops.