From patchwork Fri Mar 4 13:09:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 8503641 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9F395C0553 for ; Fri, 4 Mar 2016 13:08:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B07C5201CE for ; Fri, 4 Mar 2016 13:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C452D20225 for ; Fri, 4 Mar 2016 13:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750832AbcCDNIN (ORCPT ); Fri, 4 Mar 2016 08:08:13 -0500 Received: from mail-lb0-f194.google.com ([209.85.217.194]:36418 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbcCDNIK (ORCPT ); Fri, 4 Mar 2016 08:08:10 -0500 Received: by mail-lb0-f194.google.com with SMTP id gn5so4867925lbc.3 for ; Fri, 04 Mar 2016 05:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GVYt8+I1cHHLVwbyg83CpdDXAWX1wp0yG1pG5qdWoyk=; b=I44yJlINEsxWDo8gXxGNXxEx5BA7O3geHlN14C7nw0+x5uMTPI4ZsfgFNQO/Xm2eSZ xIk8sFF5nmZVv+IcSp9YIHMvJpx75kXgQ9CjFcczjojHdME2i4WJHRc41YkVdaVzC71K UkGu/og/zvC/RB4y4hMNm7GhEqNmXEHIttf0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GVYt8+I1cHHLVwbyg83CpdDXAWX1wp0yG1pG5qdWoyk=; b=EXudN1IFg6AS6DtkjOX6z7BXxcoU0ArosoDfxzwUJH7VndUxaTjYe9jGF5sf2PImjW fv3W4k286kAavFs05Jcvf71q+7r3McHmLDNh6Q1kdHXmBjoEXp33o+Rh7+h3FrVQAQAI YIi5JGOWmZ0IEk6xT/FVcGUGqWqAsKTbztkR1PsFX8y4Fkuab6magyN+Wm8oRUK/HGjH ZhGvV8sfnKm7vO5ZKK1gA/Bh3YCS3Ds5GyfujYmmxi1DODIZ6dDEAh7Wk4xb6n9cOcGy UsawyLyyZUGu8TRnA8LV+zMx+yAlJD7HT3lS3eAu5sMzMJSztXCCwkSK9Pm4rtHQFsfk EMRw== X-Gm-Message-State: AD7BkJJDZMys9jd+3i5FFO/9iMg9ctwrFtS4Q1TVG8FbnsUzBmsQdzW5C6vkyxiCK/celA== X-Received: by 10.25.218.1 with SMTP id r1mr2378567lfg.63.1457096888668; Fri, 04 Mar 2016 05:08:08 -0800 (PST) Received: from eudyptula.hq.kempniu.pl. (eudyptula.hq.kempniu.pl. [2001:6a0:200:83b0::fd5a]) by smtp.googlemail.com with ESMTPSA id t12sm582103lfe.46.2016.03.04.05.08.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Mar 2016 05:08:07 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Matthew Garrett , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Darren Hart Cc: Darek Stojaczyk , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/5] dell-laptop: move dell_smi_error() to dell-smbios Date: Fri, 4 Mar 2016 14:09:06 +0100 Message-Id: <1457096950-29838-2-git-send-email-kernel@kempniu.pl> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1457096950-29838-1-git-send-email-kernel@kempniu.pl> References: <1456298416-29683-1-git-send-email-kernel@kempniu.pl> <1457096950-29838-1-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dell_smi_error() method could be used by modules other than dell-laptop for convenient translation of SMBIOS request errors into errno values. Thus, move it to dell-smbios. Signed-off-by: Micha? K?pie? Reviewed-by: Pali Rohár --- drivers/platform/x86/dell-laptop.c | 14 -------------- drivers/platform/x86/dell-smbios.c | 16 ++++++++++++++++ drivers/platform/x86/dell-smbios.h | 2 ++ 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 76064c8..cbafb95 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -273,20 +273,6 @@ static const struct dmi_system_id dell_quirks[] __initconst = { { } }; -static inline int dell_smi_error(int value) -{ - switch (value) { - case 0: /* Completed successfully */ - return 0; - case -1: /* Completed with error */ - return -EIO; - case -2: /* Function not supported */ - return -ENXIO; - default: /* Unknown error */ - return -EINVAL; - } -} - /* * Derived from information in smbios-wireless-ctl: * diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 2a4992a..942572f 100644 --- a/drivers/platform/x86/dell-smbios.c +++ b/drivers/platform/x86/dell-smbios.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -39,6 +40,21 @@ static int da_command_code; static int da_num_tokens; static struct calling_interface_token *da_tokens; +int dell_smi_error(int value) +{ + switch (value) { + case 0: /* Completed successfully */ + return 0; + case -1: /* Completed with error */ + return -EIO; + case -2: /* Function not supported */ + return -ENXIO; + default: /* Unknown error */ + return -EINVAL; + } +} +EXPORT_SYMBOL_GPL(dell_smi_error); + struct calling_interface_buffer *dell_smbios_get_buffer(void) { mutex_lock(&buffer_mutex); diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h index 4f69b16..52febe6 100644 --- a/drivers/platform/x86/dell-smbios.h +++ b/drivers/platform/x86/dell-smbios.h @@ -35,6 +35,8 @@ struct calling_interface_token { }; }; +int dell_smi_error(int value); + struct calling_interface_buffer *dell_smbios_get_buffer(void); void dell_smbios_clear_buffer(void); void dell_smbios_release_buffer(void);