diff mbox

hp_accel: Add support for HP ProBook 440 G3

Message ID 1459620673-10633-1-git-send-email-martin.vajnar@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Martin Vajnar April 2, 2016, 6:11 p.m. UTC 
HP ProBook 440 G3 laptop needs a non-standard mapping (x_inverted_usd).

Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>
---
 drivers/platform/x86/hp_accel.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Darren Hart April 10, 2016, 3:10 a.m. UTC | #1 
On Sat, Apr 02, 2016 at 08:11:13PM +0200, Martin Vajnar wrote:
> HP ProBook 440 G3 laptop needs a non-standard mapping (x_inverted_usd).
> 
> Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>

Eric, this looks good to me. Any concerns?

> ---
>  drivers/platform/x86/hp_accel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
> index 10ce6cb..263002b 100644
> --- a/drivers/platform/x86/hp_accel.c
> +++ b/drivers/platform/x86/hp_accel.c
> @@ -173,6 +173,7 @@ static int lis3lv02d_dmi_matched(const struct dmi_system_id *dmi)
>  DEFINE_CONV(normal, 1, 2, 3);
>  DEFINE_CONV(y_inverted, 1, -2, 3);
>  DEFINE_CONV(x_inverted, -1, 2, 3);
> +DEFINE_CONV(x_inverted_usd, -1, 2, -3);
>  DEFINE_CONV(z_inverted, 1, 2, -3);
>  DEFINE_CONV(xy_swap, 2, 1, 3);
>  DEFINE_CONV(xy_rotated_left, -2, 1, 3);
> @@ -236,6 +237,7 @@ static const struct dmi_system_id lis3lv02d_dmi_ids[] = {
>  	AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
>  	AXIS_DMI_MATCH("HDX18", "HP HDX 18", x_inverted),
>  	AXIS_DMI_MATCH("HPB432x", "HP ProBook 432", xy_rotated_left),
> +	AXIS_DMI_MATCH("HPB440G3", "HP ProBook 440 G3", x_inverted_usd),
>  	AXIS_DMI_MATCH("HPB442x", "HP ProBook 442", xy_rotated_left),
>  	AXIS_DMI_MATCH("HPB452x", "HP ProBook 452", y_inverted),
>  	AXIS_DMI_MATCH("HPB522x", "HP ProBook 522", xy_swap),
> -- 
> 2.5.0
> 
>
Éric Piel April 11, 2016, 9:06 p.m. UTC | #2 
On 10-04-16 05:10, Darren Hart wrote:
> On Sat, Apr 02, 2016 at 08:11:13PM +0200, Martin Vajnar wrote:
>> HP ProBook 440 G3 laptop needs a non-standard mapping (x_inverted_usd).
>>
>> Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>
>
> Eric, this looks good to me. Any concerns?
Hi Darren, Martin,

Indeed it looks fine :-)

Here is my:
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>

Darren, could you pick it up in your tree?

Thanks,
Éric

>
>> ---
>>   drivers/platform/x86/hp_accel.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
>> index 10ce6cb..263002b 100644
>> --- a/drivers/platform/x86/hp_accel.c
>> +++ b/drivers/platform/x86/hp_accel.c
>> @@ -173,6 +173,7 @@ static int lis3lv02d_dmi_matched(const struct dmi_system_id *dmi)
>>   DEFINE_CONV(normal, 1, 2, 3);
>>   DEFINE_CONV(y_inverted, 1, -2, 3);
>>   DEFINE_CONV(x_inverted, -1, 2, 3);
>> +DEFINE_CONV(x_inverted_usd, -1, 2, -3);
>>   DEFINE_CONV(z_inverted, 1, 2, -3);
>>   DEFINE_CONV(xy_swap, 2, 1, 3);
>>   DEFINE_CONV(xy_rotated_left, -2, 1, 3);
>> @@ -236,6 +237,7 @@ static const struct dmi_system_id lis3lv02d_dmi_ids[] = {
>>   	AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
>>   	AXIS_DMI_MATCH("HDX18", "HP HDX 18", x_inverted),
>>   	AXIS_DMI_MATCH("HPB432x", "HP ProBook 432", xy_rotated_left),
>> +	AXIS_DMI_MATCH("HPB440G3", "HP ProBook 440 G3", x_inverted_usd),
>>   	AXIS_DMI_MATCH("HPB442x", "HP ProBook 442", xy_rotated_left),
>>   	AXIS_DMI_MATCH("HPB452x", "HP ProBook 452", y_inverted),
>>   	AXIS_DMI_MATCH("HPB522x", "HP ProBook 522", xy_swap),
>> --
>> 2.5.0
>>
>>
>

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Darren Hart April 15, 2016, 3:31 a.m. UTC | #3 
On Mon, Apr 11, 2016 at 11:06:53PM +0200, Éric Piel wrote:
> On 10-04-16 05:10, Darren Hart wrote:
> >On Sat, Apr 02, 2016 at 08:11:13PM +0200, Martin Vajnar wrote:
> >>HP ProBook 440 G3 laptop needs a non-standard mapping (x_inverted_usd).
> >>
> >>Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>
> >
> >Eric, this looks good to me. Any concerns?
> Hi Darren, Martin,
> 
> Indeed it looks fine :-)
> 
> Here is my:
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> 
> Darren, could you pick it up in your tree?

Will do, queued to fixes for 4.6.
diff mbox

Patch

diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
index 10ce6cb..263002b 100644
--- a/drivers/platform/x86/hp_accel.c
+++ b/drivers/platform/x86/hp_accel.c
@@ -173,6 +173,7 @@  static int lis3lv02d_dmi_matched(const struct dmi_system_id *dmi)
 DEFINE_CONV(normal, 1, 2, 3);
 DEFINE_CONV(y_inverted, 1, -2, 3);
 DEFINE_CONV(x_inverted, -1, 2, 3);
+DEFINE_CONV(x_inverted_usd, -1, 2, -3);
 DEFINE_CONV(z_inverted, 1, 2, -3);
 DEFINE_CONV(xy_swap, 2, 1, 3);
 DEFINE_CONV(xy_rotated_left, -2, 1, 3);
@@ -236,6 +237,7 @@  static const struct dmi_system_id lis3lv02d_dmi_ids[] = {
 	AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
 	AXIS_DMI_MATCH("HDX18", "HP HDX 18", x_inverted),
 	AXIS_DMI_MATCH("HPB432x", "HP ProBook 432", xy_rotated_left),
+	AXIS_DMI_MATCH("HPB440G3", "HP ProBook 440 G3", x_inverted_usd),
 	AXIS_DMI_MATCH("HPB442x", "HP ProBook 442", xy_rotated_left),
 	AXIS_DMI_MATCH("HPB452x", "HP ProBook 452", y_inverted),
 	AXIS_DMI_MATCH("HPB522x", "HP ProBook 522", xy_swap),