From patchwork Thu Apr 7 20:20:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giedrius Statkevi?ius X-Patchwork-Id: 8776871 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1B98DC0553 for ; Thu, 7 Apr 2016 20:20:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 40C942020F for ; Thu, 7 Apr 2016 20:20:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 445E020204 for ; Thu, 7 Apr 2016 20:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755544AbcDGUUU (ORCPT ); Thu, 7 Apr 2016 16:20:20 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33811 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755466AbcDGUUT (ORCPT ); Thu, 7 Apr 2016 16:20:19 -0400 Received: by mail-wm0-f67.google.com with SMTP id n3so24211734wmn.1; Thu, 07 Apr 2016 13:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a1/Yp6qzkKpD4M7lilQsdECSB5/q/GoyGzOhG/v/Swk=; b=BFIOEDk8eE5izRhExw/8jfbuPJ3j9Vs3N8WhdBt0oGPIOS59Yt8/2fmD0hQOIE3cDB mc+tz+YBoM7mjx2Q/i9r1Roebd1Ztl3WyH0k2Q44b0qYIDSCWHR+2+fk4aTsNoxGIuC3 FGQ2X1wf5B32yL+Kpriy7SDFpr7qqzUFpWb11fnCWOu53iRoRZfWUO+ifQ+cBx7H2RS1 2eIfqbfi5laufda/TDvCLyAToSaGAu6mH4j8iHtMHZWA0gFgG74RMUhDekjpeuqMxeUj TkmUvoHm5Zzotzq5VwUVRtrzm7vN9PohNRphmmSdOJuYCla3uZKSvD3n/WsapAFcU2fM LYQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a1/Yp6qzkKpD4M7lilQsdECSB5/q/GoyGzOhG/v/Swk=; b=kiiKxw0IjEXS97z7CJnNE1elR/Wt/loCA8mDbmC5kW24PiF2PSWuzDurz9vJhZFfQv 73FGuX8cHdbEh0SZ+CLAlv+ZLr/o5lGsWKenbHcsN54/ZKLHR/c0b0aMowymc8r6ag0N CSszbyUcC//+UlHv15FunM/LqZkZ5UnBNHqJKYSt+wXxYcvRhRAmiLqXXOIZ4FGPwa52 5H/Q8B3wEu9EjOoI6eBRvtfaeEBzMe+tIRRQHuD7tLFrYqM8/WSKMKJRtppbKmayFggf 36ztWKc4ja3I8VrXjFzmdyZvdcdKnUI4uoRW9VaYuy9mbu4gDdaYlilaZmQYHxDXs2uI ZjPw== X-Gm-Message-State: AD7BkJKJ6pAoJn2vaPX+5V5ugZwS3e1HEThMBOYlQO9n4o5qMz4/egCc90wcgcIVv0Xmjw== X-Received: by 10.28.189.10 with SMTP id n10mr27668102wmf.101.1460060416195; Thu, 07 Apr 2016 13:20:16 -0700 (PDT) Received: from tyrael.localdomain (78-57-189-147.static.zebra.lt. [78.57.189.147]) by smtp.gmail.com with ESMTPSA id ck9sm5050981wjc.22.2016.04.07.13.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Apr 2016 13:20:15 -0700 (PDT) From: =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= To: corentin.chary@gmail.com, dvhart@infradead.org Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= Subject: [PATCH 1/2] asus-laptop: remove redundant initializers Date: Thu, 7 Apr 2016 23:20:00 +0300 Message-Id: <1460060401-20742-1-git-send-email-giedrius.statkevicius@gmail.com> X-Mailer: git-send-email 2.8.0 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevi?ius --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index f2b5d0a..d86d42e 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd) { struct asus_laptop *asus = bl_get_data(bd); unsigned long long value; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET, NULL, &value); @@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, int len = 0; unsigned long long temp; char buf[16]; /* enough for all info */ - acpi_status rv = AE_OK; + acpi_status rv; /* * We use the easy way, we don't care of off and count, @@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value); static int asus_gps_status(struct asus_laptop *asus) { unsigned long long status; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS, NULL, &status);