| Message ID | 1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote: > Initializing rv to AE_OK is pointless because later function results are > assigned to them and only then the variable is used > > Signed-off-by: Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> Fine to me: Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/platform/x86/asus-laptop.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index f2b5d0a..d86d42e 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd) > { > struct asus_laptop *asus = bl_get_data(bd); > unsigned long long value; > - acpi_status rv = AE_OK; > + acpi_status rv; > > rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET, > NULL, &value); > @@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, > int len = 0; > unsigned long long temp; > char buf[16]; /* enough for all info */ > - acpi_status rv = AE_OK; > + acpi_status rv; > > /* > * We use the easy way, we don't care of off and count, > @@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value); > static int asus_gps_status(struct asus_laptop *asus) > { > unsigned long long status; > - acpi_status rv = AE_OK; > + acpi_status rv; > > rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS, > NULL, &status); > -- > 2.8.0 >
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index f2b5d0a..d86d42e 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd) { struct asus_laptop *asus = bl_get_data(bd); unsigned long long value; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET, NULL, &value); @@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, int len = 0; unsigned long long temp; char buf[16]; /* enough for all info */ - acpi_status rv = AE_OK; + acpi_status rv; /* * We use the easy way, we don't care of off and count, @@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value); static int asus_gps_status(struct asus_laptop *asus) { unsigned long long status; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS, NULL, &status);
Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)