From patchwork Sat Apr 16 00:01:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giedrius Statkevi?ius X-Patchwork-Id: 8859771 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 93A0C9F1E6 for ; Sat, 16 Apr 2016 00:02:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8C7FB20256 for ; Sat, 16 Apr 2016 00:02:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88C7C20204 for ; Sat, 16 Apr 2016 00:02:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbcDPACo (ORCPT ); Fri, 15 Apr 2016 20:02:44 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35303 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbcDPACn (ORCPT ); Fri, 15 Apr 2016 20:02:43 -0400 Received: by mail-wm0-f66.google.com with SMTP id a140so9764127wma.2; Fri, 15 Apr 2016 17:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a1/Yp6qzkKpD4M7lilQsdECSB5/q/GoyGzOhG/v/Swk=; b=scNU1np8ApbSdSzLgHsRHLQzcniVOhP/8OHrNjttG/045noLg8ufVpC1YrPxis5CbS cLarCgNVH6KhjWujA47j1elo//41+FEGKk8tFYz9Z7CrWFuIkvpNhBJW4hJHyWMe9p7z NLf9nKeEnz+dB04PRKI0pBvZnGlXzdw8aWU9cIi8b+qcCzQ8yU/d/aKBhY6+40NPpJV1 7UKIGhWLHG3/C+rhRShGbZvNHhXbNmgn4j4EE+RNY1ZE7tjvYi8IpvKkADscoL6Ws1Cr BI3nuEP7QK5rHlHnP1T2TSgT05Lpi89Xb5F4+JK/pcKwa0EiI/4JvmmtiALjvWpIqk1r nESw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a1/Yp6qzkKpD4M7lilQsdECSB5/q/GoyGzOhG/v/Swk=; b=ILyhRcKJ34eQFMfaqm/8akVgjRyFaovchiwtmykaAPDTlH2FJWtwNKquXwQ4/0CJPh Fw1pCbjq5FX+BD9BXhEF7WIp8OnknC1QTtG/thjK+HzYUakOyjQIt4xMbyq+mrE1IbRW eLBh4+HbyZuHd3q/WdUNt7srDswHaw9Z4mdJWkX2ftSJi5sZbAsbkLrQ9NsO47Ca69y+ fICwNz/fpwEqcIifacVFiNX+5smSL6yrHT8i4PPS0RGy8Ph7fR2+tVaQExfq3Gyh+ZT3 B650a412j/vvI9nBGJ5JFVp9sQKBrXuuS8HZ+e2lcgbmrCVPLKMhAmhGNSGkbmOQZ3rt rFuQ== X-Gm-Message-State: AOPr4FVxfQJRbwi8uZTwCAshowWUERBOoGqKFR161BddVLMxvoBcY0XoVSN/yYI56e5Jag== X-Received: by 10.28.26.138 with SMTP id a132mr6783354wma.20.1460764962345; Fri, 15 Apr 2016 17:02:42 -0700 (PDT) Received: from tyrael.localdomain (78-57-189-147.static.zebra.lt. [78.57.189.147]) by smtp.gmail.com with ESMTPSA id r8sm51215352wjz.34.2016.04.15.17.02.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Apr 2016 17:02:41 -0700 (PDT) From: =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= To: corentin.chary@gmail.com, dvhart@infradead.org Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= Subject: [PATCH v2 1/2] asus-laptop: remove redundant initializers Date: Sat, 16 Apr 2016 03:01:56 +0300 Message-Id: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com> X-Mailer: git-send-email 2.8.0 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevi?ius Acked-by: Andy Shevchenko --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index f2b5d0a..d86d42e 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd) { struct asus_laptop *asus = bl_get_data(bd); unsigned long long value; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET, NULL, &value); @@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, int len = 0; unsigned long long temp; char buf[16]; /* enough for all info */ - acpi_status rv = AE_OK; + acpi_status rv; /* * We use the easy way, we don't care of off and count, @@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value); static int asus_gps_status(struct asus_laptop *asus) { unsigned long long status; - acpi_status rv = AE_OK; + acpi_status rv; rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS, NULL, &status);