| Message ID | 1466665198-14446-2-git-send-email-ong.hock.yu@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote: > From: "Yu, Ong Hock" <ong.hock.yu@intel.com> > > Telemetry capability does not depend on Monitor MWAIT feature. > > Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com> Souvik, any objection? > --- > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > drivers/platform/x86/intel_telemetry_pltdrv.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c > index f5134ac..d76ee59 100644 > --- a/drivers/platform/x86/intel_telemetry_debugfs.c > +++ b/drivers/platform/x86/intel_telemetry_debugfs.c > @@ -78,7 +78,7 @@ > #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0])) > > #define TELEM_DEBUGFS_CPU(model, data) \ > - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data} > + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data} > > #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \ > if (evtlog[index].telem_evtid == (EVTID)) { \ > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c > index 09c84a2..e62cee9 100644 > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c > @@ -82,7 +82,7 @@ > #define TELEM_SET_VERBOSITY_BITS(x, y) ((x) |= ((y) << 27)) > > #define TELEM_CPU(model, data) \ > - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data } > + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data } > > enum telemetry_action { > TELEM_UPDATE = 0, > -- > 1.9.1 > >
> -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Wednesday, June 29, 2016 1:54 AM > To: Yu, Ong Hock <ong.hock.yu@intel.com> > Cc: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; platform-driver- > x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] platform:x86 Remove Monitor MWAIT feature > dependency > > On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote: > > From: "Yu, Ong Hock" <ong.hock.yu@intel.com> > > > > Telemetry capability does not depend on Monitor MWAIT feature. > > > > Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com> Acked-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> > > Souvik, any objection? Seems reasonable, since I have not heard anything break from the Chrome guys as well. > > > --- > > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > > drivers/platform/x86/intel_telemetry_pltdrv.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote: > From: "Yu, Ong Hock" <ong.hock.yu@intel.com> > > Telemetry capability does not depend on Monitor MWAIT feature. Thank you Ong Hock, queued to testing for 4.8. > > Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com> > --- > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > drivers/platform/x86/intel_telemetry_pltdrv.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c > index f5134ac..d76ee59 100644 > --- a/drivers/platform/x86/intel_telemetry_debugfs.c > +++ b/drivers/platform/x86/intel_telemetry_debugfs.c > @@ -78,7 +78,7 @@ > #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0])) > > #define TELEM_DEBUGFS_CPU(model, data) \ > - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data} > + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data} > > #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \ > if (evtlog[index].telem_evtid == (EVTID)) { \ > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c > index 09c84a2..e62cee9 100644 > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c > @@ -82,7 +82,7 @@ > #define TELEM_SET_VERBOSITY_BITS(x, y) ((x) |= ((y) << 27)) > > #define TELEM_CPU(model, data) \ > - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data } > + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data } > > enum telemetry_action { > TELEM_UPDATE = 0, > -- > 1.9.1 > >
diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c index f5134ac..d76ee59 100644 --- a/drivers/platform/x86/intel_telemetry_debugfs.c +++ b/drivers/platform/x86/intel_telemetry_debugfs.c @@ -78,7 +78,7 @@ #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0])) #define TELEM_DEBUGFS_CPU(model, data) \ - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data} + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data} #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \ if (evtlog[index].telem_evtid == (EVTID)) { \ diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c index 09c84a2..e62cee9 100644 --- a/drivers/platform/x86/intel_telemetry_pltdrv.c +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c @@ -82,7 +82,7 @@ #define TELEM_SET_VERBOSITY_BITS(x, y) ((x) |= ((y) << 27)) #define TELEM_CPU(model, data) \ - { X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data } + { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data } enum telemetry_action { TELEM_UPDATE = 0,