diff mbox

[-next] x86/platform/mellanox: Fix return value check in mlxplat_init()

Message ID 1474718174-10818-1-git-send-email-weiyj.lk@gmail.com (mailing list archive)
State Deferred, archived
Headers show

Commit Message

Wei Yongjun Sept. 24, 2016, 11:56 a.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function platform_device_register_simple()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/x86/platform/mellanox/mlx-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/platform/mellanox/mlx-platform.c b/arch/x86/platform/mellanox/mlx-platform.c
index e1dc152..7dcfcca 100644
--- a/arch/x86/platform/mellanox/mlx-platform.c
+++ b/arch/x86/platform/mellanox/mlx-platform.c
@@ -200,8 +200,8 @@  static int __init mlxplat_init(void)
 					mlxplat_lpc_resources,
 					ARRAY_SIZE(mlxplat_lpc_resources));
 
-	if (!mlxplat_dev)
-		return -ENOMEM;
+	if (IS_ERR(mlxplat_dev))
+		return PTR_ERR(mlxplat_dev);
 
 	priv = devm_kzalloc(&mlxplat_dev->dev, sizeof(struct mlxplat_priv),
 			    GFP_KERNEL);