diff mbox

[v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig

Message ID 1477226727-160036-1-git-send-email-vadimp@mellanox.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Vadim Pasternak Oct. 23, 2016, 12:45 p.m. UTC 
From: Vadim Pasternak <vadimp@mellanox.com>

Add select HWMON for mlxcpld-hotplug driver config, since it requires
hwmon APIs.

Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Darren Hart Oct. 23, 2016, 2:51 p.m. UTC | #1 
On Sun, Oct 23, 2016 at 12:45:27PM +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
> 
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.

Is this in response to the 0-day Error report?

> 
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>  	tristate "Mellanox platform hotplug driver support"
>  	default n
>  	depends on MLX_PLATFORM
> +	select HWMON
>  	select I2C
>  	---help---
>  	  This driver handles hot-plug events for the power suppliers, power
> -- 
> 2.1.4
> 
>
Randy Dunlap Oct. 23, 2016, 4:57 p.m. UTC | #2 
On 10/23/16 05:45, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
> 
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
> 
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>  	tristate "Mellanox platform hotplug driver support"
>  	default n
>  	depends on MLX_PLATFORM
> +	select HWMON
>  	select I2C
>  	---help---
>  	  This driver handles hot-plug events for the power suppliers, power
> 

Hi,
did you test this?  I would expect it to cause a kconfig warning,
something about HWMON having a dependency on HAS_IOMEM.

thanks.
Vadim Pasternak Oct. 24, 2016, 5:33 a.m. UTC | #3 
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Sunday, October 23, 2016 5:52 PM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: fengguang.wu@intel.com; davem@davemloft.net; geert@linux-m68k.org;
> akpm@linux-foundation.org; kvalo@codeaurora.org;
> gregkh@linuxfoundation.org; mchehab@kernel.org; linux@roeck-us.net; linux-
> kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
> 
> On Sun, Oct 23, 2016 at 12:45:27PM +0000, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> 
> Is this in response to the 0-day Error report?

Yes.
> 
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> >  drivers/platform/x86/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >  	tristate "Mellanox platform hotplug driver support"
> >  	default n
> >  	depends on MLX_PLATFORM
> > +	select HWMON
> >  	select I2C
> >  	---help---
> >  	  This driver handles hot-plug events for the power suppliers, power
> > --
> > 2.1.4
> >
> >
> 
> --
> Darren Hart
> Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vadim Pasternak Oct. 24, 2016, 5:41 a.m. UTC | #4 
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
> 
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> >  drivers/platform/x86/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >  	tristate "Mellanox platform hotplug driver support"
> >  	default n
> >  	depends on MLX_PLATFORM
> > +	select HWMON
> >  	select I2C
> >  	---help---
> >  	  This driver handles hot-plug events for the power suppliers, power
> >
> 
> Hi,
> did you test this?  I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.

Hi Randy,

Yes, 
I built tree with this fix with the attached .config file.
Didn't see kconfig warnings.
I can have a look again.

Thanks,
Vadim.

> 
> thanks.
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vadim Pasternak Oct. 24, 2016, 6:01 a.m. UTC | #5 
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Sunday, October 23, 2016 7:57 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> fengguang.wu@intel.com
> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> andriy.shevchenko@linux.intel.com
> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> hotplug driver in Kconfig
> 
> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> > From: Vadim Pasternak <vadimp@mellanox.com>
> >
> > Add select HWMON for mlxcpld-hotplug driver config, since it requires
> > hwmon APIs.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> > ---
> >  drivers/platform/x86/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >  	tristate "Mellanox platform hotplug driver support"
> >  	default n
> >  	depends on MLX_PLATFORM
> > +	select HWMON
> >  	select I2C
> >  	---help---
> >  	  This driver handles hot-plug events for the power suppliers, power
> >
> 
> Hi,
> did you test this?  I would expect it to cause a kconfig warning, something about
> HWMON having a dependency on HAS_IOMEM.

I re-tested it again.
I don't see any warning from kconfig. It just set " CONFIG_HWMON=m" with no warnings.
Could I miss something?

Thanks,
Vadim.
> 
> thanks.
> --
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andy Shevchenko Oct. 24, 2016, 8:58 a.m. UTC | #6 
On Sun, 2016-10-23 at 12:45 +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
> 
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
> 
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>  	tristate "Mellanox platform hotplug driver support"


>  	default n

Btw, I thought the _default_ is 'n' and thus this line is not needed.

>  	depends on MLX_PLATFORM
> +	select HWMON
>  	select I2C
>  	---help---
>  	  This driver handles hot-plug events for the power
> suppliers, power
Randy Dunlap Oct. 24, 2016, 5:11 p.m. UTC | #7 
On 10/23/16 22:41, Vadim Pasternak wrote:
> 
> 
>> -----Original Message-----
>> From: Randy Dunlap [mailto:rdunlap@infradead.org]
>> Sent: Sunday, October 23, 2016 7:57 PM
>> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
>> fengguang.wu@intel.com
>> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
>> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
>> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
>> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
>> andriy.shevchenko@linux.intel.com
>> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
>> hotplug driver in Kconfig
>>
>> On 10/23/16 05:45, vadimp@mellanox.com wrote:
>>> From: Vadim Pasternak <vadimp@mellanox.com>
>>>
>>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
>>> hwmon APIs.
>>>
>>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
>>> ---
>>>  drivers/platform/x86/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig
>>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>>>  	tristate "Mellanox platform hotplug driver support"
>>>  	default n
>>>  	depends on MLX_PLATFORM
>>> +	select HWMON
>>>  	select I2C
>>>  	---help---
>>>  	  This driver handles hot-plug events for the power suppliers, power
>>>
>>
>> Hi,
>> did you test this?  I would expect it to cause a kconfig warning, something about
>> HWMON having a dependency on HAS_IOMEM.
> 
> Hi Randy,
> 
> Yes, 
> I built tree with this fix with the attached .config file.
> Didn't see kconfig warnings.
> I can have a look again.

No need. lib/Kconfig handles it:

config HAS_IOMEM
	bool
	depends on !NO_IOMEM
	select GENERIC_IO
	default y


thanks.
Darren Hart Oct. 24, 2016, 6:10 p.m. UTC | #8 
On Mon, Oct 24, 2016 at 10:11:27AM -0700, Randy Dunlap wrote:
> On 10/23/16 22:41, Vadim Pasternak wrote:
> > 
> > 
> >> -----Original Message-----
> >> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> >> Sent: Sunday, October 23, 2016 7:57 PM
> >> To: Vadim Pasternak <vadimp@mellanox.com>; dvhart@infradead.org;
> >> fengguang.wu@intel.com
> >> Cc: davem@davemloft.net; geert@linux-m68k.org; akpm@linux-
> >> foundation.org; kvalo@codeaurora.org; gregkh@linuxfoundation.org;
> >> mchehab@kernel.org; linux@roeck-us.net; linux-kernel@vger.kernel.org;
> >> platform-driver-x86@vger.kernel.org; jiri@resnulli.us;
> >> andriy.shevchenko@linux.intel.com
> >> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
> >> hotplug driver in Kconfig
> >>
> >> On 10/23/16 05:45, vadimp@mellanox.com wrote:
> >>> From: Vadim Pasternak <vadimp@mellanox.com>
> >>>
> >>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> >>> hwmon APIs.
> >>>
> >>> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> >>> ---
> >>>  drivers/platform/x86/Kconfig | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/platform/x86/Kconfig
> >>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
> >>> --- a/drivers/platform/x86/Kconfig
> >>> +++ b/drivers/platform/x86/Kconfig
> >>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> >>>  	tristate "Mellanox platform hotplug driver support"
> >>>  	default n
> >>>  	depends on MLX_PLATFORM
> >>> +	select HWMON
> >>>  	select I2C
> >>>  	---help---
> >>>  	  This driver handles hot-plug events for the power suppliers, power
> >>>
> >>
> >> Hi,
> >> did you test this?  I would expect it to cause a kconfig warning, something about
> >> HWMON having a dependency on HAS_IOMEM.
> > 
> > Hi Randy,
> > 
> > Yes, 
> > I built tree with this fix with the attached .config file.
> > Didn't see kconfig warnings.
> > I can have a look again.
> 
> No need. lib/Kconfig handles it:
> 
> config HAS_IOMEM
> 	bool
> 	depends on !NO_IOMEM
> 	select GENERIC_IO
> 	default y
> 
> 
> thanks.
> -- 
> ~Randy
> 

Thanks for the review all. I've merged this with the original commit, now in
next.
diff mbox

Patch

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 65d9b04..1853769 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1032,6 +1032,7 @@  config MLX_CPLD_PLATFORM
 	tristate "Mellanox platform hotplug driver support"
 	default n
 	depends on MLX_PLATFORM
+	select HWMON
 	select I2C
 	---help---
 	  This driver handles hot-plug events for the power suppliers, power