| Message ID | 1500609488-30813-1-git-send-email-alex.hung@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Thu, Jul 20, 2017 at 08:58:08PM -0700, Alex Hung wrote: > Unsupported events is only useful for developers and does not meaningful > for users. Using dev_dbg makes more sense and reduces noise in kernel > messages. Similar thoughts here as to intel-vbtn. Let's discuss on that thread and apply the same decision here. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > drivers/platform/x86/intel-hid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c > index 8519e0f..4f70b82 100644 > --- a/drivers/platform/x86/intel-hid.c > +++ b/drivers/platform/x86/intel-hid.c > @@ -219,7 +219,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) > if (event != 0xc0) { > if (!priv->array || > !sparse_keymap_report_event(priv->array, event, 1, true)) > - dev_info(&device->dev, "unknown event 0x%x\n", event); > + dev_dbg(&device->dev, "unknown event 0x%x\n", event); > return; > } > > @@ -230,7 +230,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) > } > > if (!sparse_keymap_report_event(priv->input_dev, ev_index, 1, true)) > - dev_info(&device->dev, "unknown event index 0x%llx\n", > + dev_dbg(&device->dev, "unknown event index 0x%llx\n", > ev_index); > } > > -- > 2.7.4 > >
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index 8519e0f..4f70b82 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -219,7 +219,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) if (event != 0xc0) { if (!priv->array || !sparse_keymap_report_event(priv->array, event, 1, true)) - dev_info(&device->dev, "unknown event 0x%x\n", event); + dev_dbg(&device->dev, "unknown event 0x%x\n", event); return; } @@ -230,7 +230,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) } if (!sparse_keymap_report_event(priv->input_dev, ev_index, 1, true)) - dev_info(&device->dev, "unknown event index 0x%llx\n", + dev_dbg(&device->dev, "unknown event index 0x%llx\n", ev_index); }
Unsupported events is only useful for developers and does not meaningful for users. Using dev_dbg makes more sense and reduces noise in kernel messages. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/platform/x86/intel-hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)