diff mbox

[1/3] platform/x86: intel_telemetry: Fix load failure info

Message ID 1507629919-31299-1-git-send-email-rajneesh.bhardwaj@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Andy Shevchenko
Headers show

Commit Message

Rajneesh Bhardwaj Oct. 10, 2017, 10:05 a.m. UTC 
Intel Telemetry driver depends on IPC1 interface. If IPC1 interface is
disabled on a given platform by the system firmware, the driver does not
load but prints misleading information in the dmesg logs.

Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
 drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko Oct. 14, 2017, 2:10 p.m. UTC | #1 
On Tue, Oct 10, 2017 at 1:05 PM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@intel.com> wrote:
> Intel Telemetry driver depends on IPC1 interface. If IPC1 interface is
> disabled on a given platform by the system firmware, the driver does not
> load but prints misleading information in the dmesg logs.

All pushed to my review queue, thanks!

>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> ---
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index e0424d5a795a..136507a0d391 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -1234,7 +1234,6 @@ static struct platform_driver telemetry_soc_driver = {
>
>  static int __init telemetry_module_init(void)
>  {
> -       pr_info(DRIVER_NAME ": version %s loaded\n", DRIVER_VERSION);
>         return platform_driver_register(&telemetry_soc_driver);
>  }
>
> --
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index e0424d5a795a..136507a0d391 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -1234,7 +1234,6 @@  static struct platform_driver telemetry_soc_driver = {
 
 static int __init telemetry_module_init(void)
 {
-	pr_info(DRIVER_NAME ": version %s loaded\n", DRIVER_VERSION);
 	return platform_driver_register(&telemetry_soc_driver);
 }