| Message ID | 1516352307-20123-4-git-send-email-rajneesh.bhardwaj@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
On Fri, Jan 19, 2018 at 10:58 AM, Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> wrote: > From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > Export lpit_read_residency_count_address(), so that it can be used from > drivers built as module. With the recent changes, the builtin_pci > functionality of the intel_pmc_core driver is removed and now it can be > built as a module to read this exported interface to calculate the PMC base > address. > This needs Ack from ACPI maintainer(s). Rafael, are you OK with exporting this method? > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: Len Brown <lenb@kernel.org> > Cc: linux-acpi@vger.kernel.org > > Tested-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > > drivers/acpi/acpi_lpit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c > index e94e478dd18b..cf4fc0161164 100644 > --- a/drivers/acpi/acpi_lpit.c > +++ b/drivers/acpi/acpi_lpit.c > @@ -100,6 +100,7 @@ int lpit_read_residency_count_address(u64 *address) > > return 0; > } > +EXPORT_SYMBOL_GPL(lpit_read_residency_count_address); > > static void lpit_update_residency(struct lpit_residency_info *info, > struct acpi_lpit_native *lpit_native) > -- > 2.7.4 >
On Fri, Jan 26, 2018 at 10:48 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Jan 19, 2018 at 10:58 AM, Rajneesh Bhardwaj > <rajneesh.bhardwaj@intel.com> wrote: >> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> >> >> Export lpit_read_residency_count_address(), so that it can be used from >> drivers built as module. With the recent changes, the builtin_pci >> functionality of the intel_pmc_core driver is removed and now it can be >> built as a module to read this exported interface to calculate the PMC base >> address. >> > > This needs Ack from ACPI maintainer(s). > > Rafael, are you OK with exporting this method? I have no particular objection at this point.
On Mon, Jan 29, 2018 at 5:09 AM, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Fri, Jan 26, 2018 at 10:48 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Fri, Jan 19, 2018 at 10:58 AM, Rajneesh Bhardwaj >> <rajneesh.bhardwaj@intel.com> wrote: >>> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> >>> >>> Export lpit_read_residency_count_address(), so that it can be used from >>> drivers built as module. With the recent changes, the builtin_pci >>> functionality of the intel_pmc_core driver is removed and now it can be >>> built as a module to read this exported interface to calculate the PMC base >>> address. >>> >> >> This needs Ack from ACPI maintainer(s). >> >> Rafael, are you OK with exporting this method? > > I have no particular objection at this point. I took it as an ACK. Tell me if I'm wrong.
diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c index e94e478dd18b..cf4fc0161164 100644 --- a/drivers/acpi/acpi_lpit.c +++ b/drivers/acpi/acpi_lpit.c @@ -100,6 +100,7 @@ int lpit_read_residency_count_address(u64 *address) return 0; } +EXPORT_SYMBOL_GPL(lpit_read_residency_count_address); static void lpit_update_residency(struct lpit_residency_info *info, struct acpi_lpit_native *lpit_native)