| Message ID | 1519747014-17561-1-git-send-email-mario.limonciello@dell.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello <mario.limonciello@dell.com> wrote: > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least > - 6 bytes of entry */ > + * 6 bytes of entry > + */ I would prefer not to mix with net style, since you are fixing this, perhaps /* * 4 ... * 6 ... */ ?
> -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86- > owner@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Tuesday, February 27, 2018 10:04 AM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: Darren Hart <dvhart@infradead.org>; Pali Rohár <pali.rohar@gmail.com>; > LKML <linux-kernel@vger.kernel.org>; Platform Driver <platform-driver- > x86@vger.kernel.org> > Subject: Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings > > On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello > <mario.limonciello@dell.com> wrote: > > > /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least > > - 6 bytes of entry */ > > + * 6 bytes of entry > > + */ > > I would prefer not to mix with net style, since you are fixing this, perhaps > > /* > * 4 ... > * 6 ... > */ > > ? > Thanks, will adjust again when I resubmit with changes for 3/3.
diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 8541cde..4850658 100644 --- a/drivers/platform/x86/dell-smbios.c +++ b/drivers/platform/x86/dell-smbios.c @@ -36,7 +36,7 @@ static DEFINE_MUTEX(smbios_mutex); struct smbios_device { struct list_head list; struct device *device; - int (*call_fn)(struct calling_interface_buffer *); + int (*call_fn)(struct calling_interface_buffer *arg); }; struct smbios_call { @@ -353,7 +353,8 @@ static void __init parse_da_table(const struct dmi_header *dm) container_of(dm, struct calling_interface_structure, header); /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least - 6 bytes of entry */ + * 6 bytes of entry + */ if (dm->length < 17) return;
WARNING: function definition argument 'struct calling_interface_buffer *' should also have an identifier name + int (*call_fn)(struct calling_interface_buffer *); WARNING: Block comments use * on subsequent lines + /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> --- drivers/platform/x86/dell-smbios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)