From patchwork Fri Apr 20 17:42:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10353385 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C5F61600CC for ; Fri, 20 Apr 2018 17:42:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7BA7287CB for ; Fri, 20 Apr 2018 17:42:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AC3832880D; Fri, 20 Apr 2018 17:42:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AC3D287CB for ; Fri, 20 Apr 2018 17:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbeDTRmR (ORCPT ); Fri, 20 Apr 2018 13:42:17 -0400 Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:52896 "EHLO esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbeDTRmQ (ORCPT ); Fri, 20 Apr 2018 13:42:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1524246136; x=1555782136; h=from:to:cc:subject:date:message-id; bh=0EoYI79QlZP5vOPC8z62FnGWt3J72ynVfsxzDWrpw/I=; b=rg+03mW+FLL1flR5rWpQ+ocNs/EW3DA4qBz1JOe3pZwSuHnkoCE1kaBI AiwLamMj1C62HZKWFz6ne/mvjPrGVcOGh0u7K9nZlFPOugQvl7Lqs4OVr NamzO90gWx23PPPMYVgz5WwEfG0DvEsxYwTjeguVTddgBtZDPGEhqMb+3 Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HHAAABJtpah2Ka6ERbhU4omGSDA5J4g?= =?us-ascii?q?XgLhGmCSCE0GAECAQEBAQEBAgEBAhABAQEIDQkIKC+CNSQBg0pPbwEShQ2pDYh?= =?us-ascii?q?BgimIBoFUP4hWhgsCjGmLCAiBYYxeAoxLAZApgSUcggtwgxOCLo4+UY0ggkYBA?= =?us-ascii?q?Q?= X-IPAS-Result: =?us-ascii?q?A2HHAAABJtpah2Ka6ERbhU4omGSDA5J4gXgLhGmCSCE0GAE?= =?us-ascii?q?CAQEBAQEBAgEBAhABAQEIDQkIKC+CNSQBg0pPbwEShQ2pDYhBgimIBoFUP4hWh?= =?us-ascii?q?gsCjGmLCAiBYYxeAoxLAZApgSUcggtwgxOCLo4+UY0ggkYBAQ?= Received: from esa4.dell-outbound2.iphmx.com ([68.232.154.98]) by esa2.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2018 12:42:15 -0500 Received: from ausxippc101.us.dell.com ([143.166.85.207]) by esa4.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2018 23:42:14 +0600 X-LoopCount0: from 10.208.86.39 X-IronPort-AV: E=Sophos;i="5.49,302,1520917200"; d="scan'208";a="1078926322" X-DLP: DLP_GlobalPCIDSS From: Mario Limonciello To: dvhart@infradead.org, Andy Shevchenko Cc: LKML , platform-driver-x86@vger.kernel.org, Mario Limonciello Subject: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain. Date: Fri, 20 Apr 2018 12:42:11 -0500 Message-Id: <1524246131-17621-1-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As reported by Randy Dunlap: >> WARNING: unmet direct dependencies detected for DELL_SMBIOS >> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] >> && (DCDBAS [=m] || >> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n) >> Selected by [y]: >> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] >> && DMI [=y] >> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || >> ACPI_VIDEO [=n]=n) >> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y] >> Right now it's possible to set dell laptop to compile in but this causes dell-smbios to compile in which breaks if dcdbas is a module. Dell laptop shouldn't select dell-smbios anymore, but depend on it. Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on DCDBAS) Reported-by: Randy Dunlap Signed-off-by: Mario Limonciello Tested-by: Randy Dunlap --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 39d06dd..bc309c5 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -154,7 +154,7 @@ config DELL_LAPTOP depends on ACPI_VIDEO || ACPI_VIDEO = n depends on RFKILL || RFKILL = n depends on SERIO_I8042 - select DELL_SMBIOS + depends on DELL_SMBIOS select POWER_SUPPLY select LEDS_CLASS select NEW_LEDS