| Message ID | 1560966464-27644-1-git-send-email-cai@lca.pw (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | [v2] x86/efi: fix a -Wtype-limits compilation warning | expand |
> Compiling a kernel with W=1 generates this warning, > > arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned > expression >= 0 is always true [-Wtype-limits] > > Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI > runtime services") > Signed-off-by: Qian Cai <cai@lca.pw> > --- > > v2: Add a "Fixes" tag. Makes sense. Thanks for the fix Qian Cai. Regards, Sai
On Wed, 19 Jun 2019 at 19:53, Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com> wrote: > > > Compiling a kernel with W=1 generates this warning, > > > > arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned > > expression >= 0 is always true [-Wtype-limits] > > > > Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI > > runtime services") > > Signed-off-by: Qian Cai <cai@lca.pw> > > --- > > > > v2: Add a "Fixes" tag. > > Makes sense. > Thanks for the fix Qian Cai. > Queued as a fix with Sai's ack Thanks,
diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c index 632b83885867..3b9fd679cea9 100644 --- a/arch/x86/platform/efi/quirks.c +++ b/arch/x86/platform/efi/quirks.c @@ -728,7 +728,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr) * Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so * page faulting on these addresses isn't expected. */ - if (phys_addr >= 0x0000 && phys_addr <= 0x0fff) + if (phys_addr <= 0x0fff) return; /*
Compiling a kernel with W=1 generates this warning, arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI runtime services") Signed-off-by: Qian Cai <cai@lca.pw> --- v2: Add a "Fixes" tag. arch/x86/platform/efi/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)